[Bug 35947] New: Accounting transactions do not show managing librarian if HidePatronName is set to yes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Bug ID: 35947 Summary: Accounting transactions do not show managing librarian if HidePatronName is set to yes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org A new bug 34377: Accounting transactions should show managing librarian info for credits/debits, allows librarians to see the librarian who did the accounting transaction. However, if the system preference, hidepatronname is set to Show, the name of the person is not shown, it says "a patron from X branch". This does not seem helpful nor connected to the hidepatronname system preference description, "Show/Don't Show the names of patrons that have items checked out or on hold on detail pages or the "Place Hold" screen." As this is not the checked out screen or the place hold screen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 --- Comment #1 from Kelly McElligott <kelly@bywatersolutions.com> --- Sorry, I meant if the library has the system preference, HidePatronName, set to Don't Show. ^^ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 167673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167673&action=edit Bug 35947: Show managing librarian in accounting transaction regardless of HidePatronName status This patch removes the 'hide_patron_infos_if_needed => 1' passing into 'patron-title.inc' from 'accountline-details.tt'. Doing so allows for the managing librarian to be shown in the accounting details. In order to correctly link to this librarian, necessary changes were also made to the 'patron-title.inc' 1) Set 'HidePatronName' sys. pref. to 'Don't show' 2) Go to a patron's page 3) Click on the accounting tab 4) Select 'Create manual invoice', put in an amount and press save. 5) In the transactions tab, click on the details of that specifc transaction 6) Note that in the "Details of debit" table, the Librarian is set to 'a patron from X branch' 7) Apply patch, restart_all 8) Go to the same transaction, notice that now it says the actual librarian who was in charge of creating transaction. 9) Click on this name and make sure the link works 10) Go back to accounting section and now make a payment. 11) View details of this transaction and ensure the librarian is present -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |samalau@gmail.com |ity.org | CC| |samalau@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167673|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 173802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173802&action=edit Bug 35947: Show managing librarian in accounting transaction regardless of HidePatronName status This patch removes the 'hide_patron_infos_if_needed => 1' passing into 'patron-title.inc' from 'accountline-details.tt'. Doing so allows for the managing librarian to be shown in the accounting details. In order to correctly link to this librarian, necessary changes were also made to the 'patron-title.inc' 1) Set 'HidePatronName' sys. pref. to 'Don't show' 2) Go to a patron's page 3) Click on the accounting tab 4) Select 'Create manual invoice', put in an amount and press save. 5) In the transactions tab, click on the details of that specifc transaction 6) Note that in the "Details of debit" table, the Librarian is set to 'a patron from X branch' 7) Apply patch, restart_all 8) Go to the same transaction, notice that now it says the actual librarian who was in charge of creating transaction. 9) Click on this name and make sure the link works 10) Go back to accounting section and now make a payment. 11) View details of this transaction and ensure the librarian is present Signed-off-by: Laura ONeil <laura@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- -[%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%] +[%- IF ( display_patron_name OR display_cardnumber ) -%] -[%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%] +[%- IF ( display_patron_name OR display_cardnumber ) -%] Changes in patron-title.inc affect a lot of places. So removing that check here seems wrong. Please prove me wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #4)
-[%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%] +[%- IF ( display_patron_name OR display_cardnumber ) -%]
-[%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%] +[%- IF ( display_patron_name OR display_cardnumber ) -%]
Changes in patron-title.inc affect a lot of places. So removing that check here seems wrong. Please prove me wrong.
You're not wrong, it is used in a lot of place. Could we just not use patron-title.inc in this case? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 183515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183515&action=edit Bug 35947: Show account manager info regardless of HidePatronName pref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183515|0 |1 is obsolete| | --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 183516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183516&action=edit Bug 35947: Show account manager info regardless of HidePatronName pref 1) Set 'HidePatronName' sys. pref. to 'Don't show' 2) Go to a patron's page 3) Click on the accounting tab 4) Select 'Create manual invoice', put in an amount and press save. 5) In the transactions tab, click on the details of that specifc transaction 6) Note that in the "Details of debit" table, the Librarian is set to 'a patron from X branch' 7) Apply patch, restart_all 8) Go to the same transaction, notice that now it says the actual librarian who was in charge of creating transaction. 9) Click on this name and make sure the link works 10) Go back to accounting section and now make a payment. 11) View details of this transaction and ensure the librarian is present -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173802|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|samalau@gmail.com |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183516|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183550&action=edit Bug 35947: Show account manager info regardless of HidePatronName pref 1) Set 'HidePatronName' sys. pref. to 'Don't show' 2) Go to a patron's page 3) Click on the accounting tab 4) Select 'Create manual invoice', put in an amount and press save. 5) In the transactions tab, click on the details of that specifc transaction 6) Note that in the "Details of debit" table, the Librarian is set to 'a patron from X branch' 7) Apply patch, restart_all 8) Go to the same transaction, notice that now it says the actual librarian who was in charge of creating transaction. 9) Click on this name and make sure the link works 10) Go back to accounting section and now make a payment. 11) View details of this transaction and ensure the librarian is present Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy@rijksmuseum.nl CC| |jonathan.druart@gmail.com Status|Signed Off |Failed QA --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- We are removing here: hide_patron_infos_if_needed => 1 Feels like we should use that and perhaps fix patron-title? Pass hide=false ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Marcel de Rooy from comment #9)
We are removing here: hide_patron_infos_if_needed => 1
Feels like we should use that and perhaps fix patron-title? Pass hide=false ?
Why? I would simply remove hide_patron_infos_if_needed actually. We know it's a librarian and not a patron. However I do agree that we should keep the use of patron-title.inc. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org