[Bug 34341] New: Revert Bug 34072: Holds queue search interface hidden on small screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34341 Bug ID: 34341 Summary: Revert Bug 34072: Holds queue search interface hidden on small screens Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: andrewfh@dubcolib.org, gmcharlt@gmail.com, kyle.m.hall@gmail.com, lucas@bywatersolutions.com, testopia@bugs.koha-community.org Depends on: 34072 I am not able to reproduce Bug 34072 in Koha before the patch. In my test, the holds queue sidebar filter doesn't disappear, it just gets moved down to below the holds queue table when the browser window is below a certain width. This is to be expected with anything in the sidebar. I think the should be reverted. It has unwanted side-effects (changing margins around fieldsets and submit buttons) and doesn't seem to fix any bug as far as I can tell. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 [Bug 34072] Holds queue search interface hidden on small screens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34341 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34341 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34341 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154651&action=edit Bug 34341: Revert Bug 34072: Holds queue search interface hidden on small screens This patch undoes the changes made by 34072 because they have had a more far-reaching effect than was expected. I have never been able to reproduce Bug 34072 before the patch. To test, apply the patch and rebuild the staff interface CSS. - Go to Circulation -> Holds queue - Try adjusting the width of the browser window to confirm that it is responsive at various widths. - When the viewport width is below 768 the page layout will adjust, and the contents of the sidebar will drop below the table of holds. This is consistent with other pages in the staff interface. - Check that the corrected CSS has resulted in a correction to the layout of submit buttons in forms: - For example, in Administration -> Cities and towns -> New city. - Before the patch there was no padding between the submit button and the white fieldset containing the form fields. - After the patch the correct padding has been restored. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34341 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34341 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154651|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 154655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154655&action=edit Bug 34341: Revert Bug 34072: Holds queue search interface hidden on small screens This patch undoes the changes made by 34072 because they have had a more far-reaching effect than was expected. I have never been able to reproduce Bug 34072 before the patch. To test, apply the patch and rebuild the staff interface CSS. - Go to Circulation -> Holds queue - Try adjusting the width of the browser window to confirm that it is responsive at various widths. - When the viewport width is below 768 the page layout will adjust, and the contents of the sidebar will drop below the table of holds. This is consistent with other pages in the staff interface. - Check that the corrected CSS has resulted in a correction to the layout of submit buttons in forms: - For example, in Administration -> Cities and towns -> New city. - Before the patch there was no padding between the submit button and the white fieldset containing the form fields. - After the patch the correct padding has been restored. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34341 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34341 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34341 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154655|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154754&action=edit Bug 34341: Revert Bug 34072: Holds queue search interface hidden on small screens This patch undoes the changes made by 34072 because they have had a more far-reaching effect than was expected. I have never been able to reproduce Bug 34072 before the patch. To test, apply the patch and rebuild the staff interface CSS. - Go to Circulation -> Holds queue - Try adjusting the width of the browser window to confirm that it is responsive at various widths. - When the viewport width is below 768 the page layout will adjust, and the contents of the sidebar will drop below the table of holds. This is consistent with other pages in the staff interface. - Check that the corrected CSS has resulted in a correction to the layout of submit buttons in forms: - For example, in Administration -> Cities and towns -> New city. - Before the patch there was no padding between the submit button and the white fieldset containing the form fields. - After the patch the correct padding has been restored. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34341 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34341 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34341 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.04 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34341 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34341 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org