[Bug 24789] New: Remove 'ITS' macro format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 Bug ID: 24789 Summary: Remove 'ITS' macro format Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl During development there was support added for a secondary macro format, however, I do not believe it was fully supported or documented. It was based on another ILS macro format I believe As the rancor format was documented and explained I think we should remove the other format. According to original developer this was intended to be done before submission. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100005&action=edit Bug 24789: Remove ITS macro format To test: 1 - Apply patches 2 - Confirm you can save, load, and run macros 3 - Confirm you have no choice of format -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17268 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |carnold@dgiinc.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, I think I thought the ITS format may be marginally more functional that our own so I wondered if rather than removal we should fully document it. Were there copyright issues that required it's removal perhaps.. if so I'd love to see any missing functionality added into our own macro format as part of a removal? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 --- Comment #3 from Cori Lynn Arnold <carnold@dgiinc.com> --- Martin, In our (DGI's) experience, the ITS functionality in Koha isn't completely compatible with a macro exported out of ITS. In all cases I was able to create a Koha macro functionally the same as the ITS macro (albeit in multiple lines where the ITS version may have had 1). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- That's good to know Cori, sounds like we can indeed nuke it then. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100005|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100578&action=edit Bug 24789: Remove ITS macro format To test: 1 - Apply patches 2 - Confirm you can save, load, and run macros 3 - Confirm you have no choice of format Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100578|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 100700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100700&action=edit Bug 24789: Remove ITS macro format To test: 1 - Apply patches 2 - Confirm you can save, load, and run macros 3 - Confirm you have no choice of format Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please update text to go into release notes for this one! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |During the initial Rancor release notes| |(advanced cataloging | |editor) development an | |existing macro language was | |copied. As development | |continued a Rancor macro | |language was developed. The | |new language accomplished | |all needs of the prior | |language. The old macro | |language was intended to be | |removed before submission | |to community, but was | |missed. These patches | |remove the legacy support | |in favour of the Koha | |specific model. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100757&action=edit Bug 24789: [follow-up] Fix saving of macros Saving was accidentally commented out in patches, this restores that To test: 1 - Create a new macro 2 - Add some content 3 - Reload the macro, no content 4 - Apply patch 5 - Repeat 6 - Macro saves/loads correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.05 released in| | --- Comment #11 from Joy Nelson <joy@bywatersolutions.com> --- backported to 19.11.x branch for 19.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in| |19.05.10 --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #13 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Enhancement/minor will not be backported to 18.11.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org