[Bug 6353] New: Erroneous prefixes before the singleBranchMode preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6353 Bug #: 6353 Summary: Erroneous prefixes before the singleBranchMode preference Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: januszop@gmail.com QAContact: koha-bugs@lists.koha-community.org Created attachment 4146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4146 Proposed patch In new templates, in some cases (I have found four) the singleBranchMode preference, when appearing in a loop, has been prefixed with the loop name, which is wrong. As a result of changing the singleBranchMode preference has no impact on e.g. whether the library name is displayed or not in opac search results view. A patch is attached. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6353 januszop@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff AssignedTo|oleonard@myacpl.org |januszop@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6353 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4146|0 |1 is patch| | Attachment #4146|application/octet-stream |text/plain mime type| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6353 januszop@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6353 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Does not apply --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-18 05:53:12 UTC --- This patch does not apply with git: Patch format detection failed. I am marking 'Does not apply' - perhaps someone can reformat? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6353 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5917 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6353 januszop@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff --- Comment #2 from januszop@gmail.com 2011-05-18 11:26:36 UTC --- Katrin, I have just resent the patch again to the list (yesterday my e-mail program introduced line breaks). Please test it now. Thank you. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6353 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-19 05:59:24 UTC --- Can you attach your new patch to the bug plz? You can mark the old one obsolete, so there will be no confusion about which patch should be used. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6353 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4146|0 |1 is obsolete| | --- Comment #4 from Janusz Kaczmarek <januszop@gmail.com> 2011-05-19 07:19:29 UTC --- Created attachment 4181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4181 Proposed patch (with the header) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6353 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6347 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6353 --- Comment #5 from Janusz Kaczmarek <januszop@gmail.com> 2011-05-19 20:43:54 UTC --- Hi Katrin, Could you, please, explain, why do you consider this bug as dependent on 6347? I do not get the point. It seems to me that these two bugs are fully independent. As to opac-results.tt: singleBranchMode is a "global" parameter/preference -- all I propose in my patch is removing the erroneous loop prefix from before it... Best regards! Janusz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6353 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-19 20:58:30 UTC --- Hi Janusz, I can't test the part on reserve.tt because it applies to item level holds - which are currently broken. See here from the code: [% IF ( OPACItemHolds ) %] [% IF ( bibitemloo.holdable ) %] <tr class="copiesrow" id="copiesrow_[% bibitemloo.biblionumber %]"> <td colspan="1"> </td> <td colspan="[% bibitemloo.itemtable_colspan %]"> <table> <caption>Select a specific copy:</caption> <tr> <th>Copy</th> [% IF ( item_level_itypes ) %] <th>Item Type</th> [% END %] <th>Barcode</th> line you fixed > [% UNLESS ( bibitemloo.singleBranchMode ) %] <th>Home Library</th> <th>Last Location</th> I believe your patch works, but at the moment I can't test properly. I tried to sign off the fix for item level holds, but ran into some problems. Hope that explains. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6353 --- Comment #7 from Janusz Kaczmarek <januszop@gmail.com> 2011-05-20 21:38:50 UTC --- Thank you, Katrin, for the explanation--now I get the point. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6353 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-29 21:00:22 UTC --- Created attachment 4295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4295 [SIGNED-OFF] Bug 6353: Erroneous prefixes before the singleBranchMode preference removed Patch resent due to errors in formating in previous e-mail Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked: - library facet - library limit on advanced search - library shown in item level hold table -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6353 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6353 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2011-06-10 03:48:05 UTC --- TT error, pushed please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6353 Bug 6353 depends on bug 6347, which changed state. Bug 6347 Summary: Bug in opac-reserve.pl stopping item level holds http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6347 What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org