[Bug 43321] New: Remove event attribute from search filter administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43321 Bug ID: 43321 Summary: Remove event attribute from search filter administration Initiative type: --- Sponsorship Sponsored status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, testopia@bugs.koha-community.org Blocks: 38407 Target Milestone: --- On the search filter administration page there is an onclick attribute on the delete button which should be removed in favor of defining the event in the page's JavaScript. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 [Bug 38407] Eliminate event handler attributes in the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43321 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Athens County Public list of Sponsors| |Libraries Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43321 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203687&action=edit Bug 43321: Remove event attribute from search filter administration This patch updates the search filter administration template in order to remove an "onclick" event attribute. The patch also adds a confirmation to the delete action. The patch also adds some white space between the action buttons in order to prevent them from looking crowded. To test: - If necessary, enable the SavedSearchFilters system preference. - If you have no search filters defined, perform a catalog search and click "Save search as filter." Save the filter. - Go to Administration -> Search filters. - Click "Delete" on one of your search filters. - You should be asked to confirm, "Are you sure you want to delete this search filter?" - If you cancel, the filter should not be deleted. - If you confirm, the filter should be deleted. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43321 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43321 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43321 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43321 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203687|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43321 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 204232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204232&action=edit Bug 43321: Remove event attribute from search filter administration This patch updates the search filter administration template in order to remove an "onclick" event attribute. The patch also adds a confirmation to the delete action. The patch also adds some white space between the action buttons in order to prevent them from looking crowded. To test: - If necessary, enable the SavedSearchFilters system preference. - If you have no search filters defined, perform a catalog search and click "Save search as filter." Save the filter. - Go to Administration -> Search filters. - Click "Delete" on one of your search filters. - You should be asked to confirm, "Are you sure you want to delete this search filter?" - If you cancel, the filter should not be deleted. - If you confirm, the filter should be deleted. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43321 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 205890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205890&action=edit Bug 43321: (follow-up) Avoid jQuery for new or refactored code -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org