[Bug 10965] New: Sample itemtypes can't load on new install
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Bug ID: 10965 Summary: Sample itemtypes can't load on new install Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: bgkriegel@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Sample itemtypes can't load with new itemtypes table structure. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21551&action=edit Bug 10965 - Sample itemtypes can't load on new install Bug 10513 added two columns to table itemtypes, but sample_itemtypes can't be loaded because it relies on old structure. This patch rewrites sample_itemtypes.sql, stating explicitly columns, removing backticks and consolidates all in one insertion. To test: 1) On master with current DB structure, delete item types 2) try loading sample_itemtyes.sql It fails with "ERROR 1136 (21S01) at line 1: Column count doesn't match value count at row 1" 3) apply patch 4) try again, this time it will load and itemtypes created -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21551|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 21567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21567&action=edit Bug 10965 - Sample itemtypes can't load on new install Bug 10513 added two columns to table itemtypes, but sample_itemtypes can't be loaded because it relies on old structure. This patch rewrites sample_itemtypes.sql, stating explicitly columns, removing backticks and consolidates all in one insertion. To test: 1) On master with current DB structure, delete item types 2) try loading sample_itemtyes.sql It fails with "ERROR 1136 (21S01) at line 1: Column count doesn't match value count at row 1" 3) apply patch 4) try again, this time it will load and itemtypes created Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we need follow-ups to fix the translated installers as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21567|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21597&action=edit [PASSED QA] Bug 10965 - Sample itemtypes can't load on new install Bug 10513 added two columns to table itemtypes, but sample_itemtypes can't be loaded because it relies on old structure. This patch rewrites sample_itemtypes.sql, stating explicitly columns, removing backticks and consolidates all in one insertion. To test: 1) On master with current DB structure, delete item types 2) try loading sample_itemtyes.sql It fails with "ERROR 1136 (21S01) at line 1: Column count doesn't match value count at row 1" 3) apply patch 4) try again, this time it will load and itemtypes created Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> SQL change only. Tested by running the web installer on an empty database. All sample data loads without errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Working on a follow-up for translated installers. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10969 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Katrin Fischer from comment #6)
Working on a follow-up for translated installers.
If you like I can do this. Somehow I forget other languages :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Already done - bug 10969 :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Depends on| |10513 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org