[Bug 11277] New: Bootstrap theme: error in link for showing all facets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Bug ID: 11277 Summary: Bootstrap theme: error in link for showing all facets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: mathieu.saby@univ-rennes2.fr QA Contact: testopia@bugs.koha-community.org The "show more" link under a facet list in Bootstrap theme is wrong. It redirects to the advanced search. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 --- Comment #1 from Frédéric Demians <frederic@tamil.fr> --- In the same area, search result limitation on Library facet, doesn't work. It returns all biblio records of the selected library. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |frederic@tamil.fr --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 23155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23155&action=edit Proposed patch Bug 11277 Bootstrap theme facets doesn't work properly Two errors: 1. When selecting 'show more' above a facet, the advanced search page is displayed. 2. When restricting search on a library facet, all the biblio records of this library are returned. The patch fixes the way URL are encoded with TT filter. See that: http://search.cpan.org/~abw/Template-Toolkit-2.25/lib/Template/Manual/Filter... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- After applying this patch I find that the "show more" links work, but the "limit to available" link returns no results, and clicking any facet returns no results. I'm continuing to test. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Owen Leonard from comment #3)
After applying this patch I find that the "show more" links work, but the "limit to available" link returns no results, and clicking any facet returns no results. I'm continuing to test.
Thanks for testing. I confirm that for me on an UNIMAC-DB, this patch solves the two bugs: (1) 'show more' facets, and (2) library limitation facet--without breaking neither other facets selection, nor availability restriction. Do you confirm the two bugs before applying the patch? Is it solved with the patch? And other facet selection were working? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can confirm the bug and the patch seems to fix it nicely for me - testd on a MARC21 database on current master with German data. I made sure to try some facets with umlauts as well. Owen, I am adding my sign-off here, but would feel better if you could take another look? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23155|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23495&action=edit [SIGNED OFF] Bug 11277 Bootstrap theme facets doesn't work properly Two errors: 1. When selecting 'show more' above a facet, the advanced search page is displayed. 2. When restricting search on a library facet, all the biblio records of this library are returned. The patch fixes the way URL are encoded with TT filter. See that: http://search.cpan.org/~abw/Template-Toolkit-2.25/lib/Template/Manual/Filter... Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch works nicely. Tests done: - 'More' link on facets redirects to advanced search before applying the patch. After appyling the link works correctly. - In my tests, the facet links themselves worked nicely, limiting the search as expected. - Availability search works ok for me with patch applied. - Also made sure to click on some links containing diacricits (German umlauts). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23495|0 |1 is obsolete| | --- Comment #7 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 23496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23496&action=edit Bug 11277 Bootstrap theme facets doesn't work properly Two errors: 1. When selecting 'show more' above a facet, the advanced search page is displayed. 2. When restricting search on a library facet, all the biblio records of this library are returned. The patch fixes the way URL are encoded with TT filter. See that: http://search.cpan.org/~abw/Template-Toolkit-2.25/lib/Template/Manual/Filter... Signed-off-by: Liz Rea <liz@catalyst.net.nz> Current status: Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23496|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23558&action=edit [PASSED QA] Bug 11277 Bootstrap theme facets doesn't work properly Two errors: 1. When selecting 'show more' above a facet, the advanced search page is displayed. 2. When restricting search on a library facet, all the biblio records of this library are returned. The patch fixes the way URL are encoded with TT filter. See that: http://search.cpan.org/~abw/Template-Toolkit-2.25/lib/Template/Manual/Filter... Signed-off-by: Liz Rea <liz@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch works nicely. Tests done: - 'More' link on facets redirects to advanced search before applying the patch. After appyling the link works correctly. - In my tests, the facet links themselves worked nicely, limiting the search as expected. - Availability search works ok for me with patch applied. - Also made sure to click on some links containing diacricits (German umlauts). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The more links being broken is quite an annyoing bug - upping severity a bit. Liz signed off, so taking the liberty to change my sign off into a QA review :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Frédéric! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patches pushed to 3.14.x, will be in 3.14.3 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org