[Bug 16864] New: Silence warnings in t/db_dependent/ILSDI_Services.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 Bug ID: 16864 Summary: Silence warnings in t/db_dependent/ILSDI_Services.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: mtompset@hotmail.com Reporter: mtompset@hotmail.com QA Contact: gmcharlt@gmail.com $cgi->param() is used in an ambiguous context, so it doesn't realize it should be scalar. Clarify the context while maintaining readability by novices. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 53151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53151&action=edit Bug 16864: Silence warnings in t/db_dependent/ILSDI_Services.t prove t/db_dependent/ILSDI_Services.t generates noisy output as a result of the ambiguous context of two $cgi->param() calls. By storing into scalar variables, and then using the scalar variables, the code maintains readability and fixes the problem. TEST PLAN --------- 1) prove t/db_dependent/ILSDI_Services.t -- noisy. 2) apply patch 3) prove t/db_dependent/ILSDI_Services.t -- not noisy 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|gmcharlt@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53151|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 53730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53730&action=edit Bug 16864: Silence warnings in t/db_dependent/ILSDI_Services.t prove t/db_dependent/ILSDI_Services.t generates noisy output as a result of the ambiguous context of two $cgi->param() calls. By storing into scalar variables, and then using the scalar variables, the code maintains readability and fixes the problem. TEST PLAN --------- 1) prove t/db_dependent/ILSDI_Services.t -- noisy. 2) apply patch 3) prove t/db_dependent/ILSDI_Services.t -- not noisy 4) run koha qa test tools Signed-off-by: Marc <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53730|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53881&action=edit Bug 16864: Silence warnings in t/db_dependent/ILSDI_Services.t prove t/db_dependent/ILSDI_Services.t generates noisy output as a result of the ambiguous context of two $cgi->param() calls. By storing into scalar variables, and then using the scalar variables, the code maintains readability and fixes the problem. TEST PLAN --------- 1) prove t/db_dependent/ILSDI_Services.t -- noisy. 2) apply patch 3) prove t/db_dependent/ILSDI_Services.t -- not noisy 4) run koha qa test tools Signed-off-by: Marc <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15809 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to master. Should be in the November 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.03. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16864 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org