[Bug 29303] New: quick add form duplicates HTML ID's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29303 Bug ID: 29303 Summary: quick add form duplicates HTML ID's Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com We noticed while trying to add some jQuery to the quick add from that there are duplicate id's on the page for each input. The jQuery on memberentrygen.tt checks to see what fields should be present on the quick_add_form and then uses jQuery clone() to add them to the quick_add_form. The problem is this creates duplicate ID's which is invalid HTML. We should change those cloned ID's so they are not duplicates. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29303 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29303 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 126681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126681&action=edit Bug 29303: Give quick add form fields new ID and for attributes To test: 1.Go to the quick add patron form 2. Use the browser dev tools to notice that there are duplicate ID's for every input on the qa form. One is showing and one is hidden. 3. These duplicate ID's won't show up in the page source because they are added with JS. 4. Apply patch 5. Try step 2 again, the quick add form fields should have an ID starting with 'qa_'. The labels 'for' attribute should aslo have this. 6. Make sure the patron quick add form still works. 7. Add several new fields to the patron qa form and make sure everything is right. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29303 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19249 CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29303 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- It looks like this is adding a duplicate id to <label>s: <label for="qa_surname" class="required" id="qa_surname">Surname: </label> <input type="text" id="qa_surname" name="surname"... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29303 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 127436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127436&action=edit Bug 29330: (QA follow-up) Use passed MIME type Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29303 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29303 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127436|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29303 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|quick add form duplicates |Quick add form duplicates |HTML ID's |HTML ID's -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29303 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #4 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Hi Lucas, Is there any chance you could take another look at this? I'd love to be able to use jQuery on the quick add form and the duplicate ids are a real problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29303 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29303 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #5 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Appears to have been resolved as part of Bug 31497 *** This bug has been marked as a duplicate of bug 31497 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org