[Bug 28965] New: Add public routes for lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Bug ID: 28965 Summary: Add public routes for lists Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18148 Depends on| |28959 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 [Bug 18148] Make list of lists in OPAC sortable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 [Bug 28959] virtualshelves.category is really a boolean -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28948 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948 [Bug 28948] Add a /public counterpart for the libraries REST endpoints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124635&action=edit Bug 28965: filter_by_public() and filter_by_readable() This patch adds helper methods for lists resultsets. Tests are added for their behavior. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Virtualshelves.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 124636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124636&action=edit Bug 28965: Add /public/lists This patch adds a route for publicly retrieving lists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com Status|NEW |Needs Signoff --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Submitting early to highlight the coolness of what we did on bug 28948. It still needs tests. I will file a separate bug for all the CRUD (staff/public). The barebones are done anyway :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #4 from David Nind <david@davidnind.com> --- Tests fail for me after applying patch (and dependencies) 8-(... root@kohadevbox:koha(bz28965)$ prove t/db_dependent/Virtualshelves.t t/db_dependent/Virtualshelves.t .. No method count found for Koha::Virtualshelves DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'public' in 'where clause' at /kohadevbox/koha/Koha/Objects.pm line 601 at /kohadevbox/koha/Koha/Virtualshelf.pm line 99. DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'public' in 'field list' at /kohadevbox/koha/Koha/Object.pm line 170 # Looks like you planned 13 tests but ran 1. t/db_dependent/Virtualshelves.t .. 1/8 # Failed test 'CRUD' # at t/db_dependent/Virtualshelves.t line 110. DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'public' in 'field list' at /kohadevbox/koha/Koha/Object.pm line 170 # Looks like your test exited with 11 just after 1. t/db_dependent/Virtualshelves.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 8/8 subtests Test Summary Report ------------------- t/db_dependent/Virtualshelves.t (Wstat: 2816 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 11 Parse errors: Bad plan. You planned 8 tests but ran 1. Files=1, Tests=1, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.58 cusr 0.15 csys = 1.75 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Nind from comment #4)
Tests fail for me after applying patch (and dependencies) 8-(...
root@kohadevbox:koha(bz28965)$ prove t/db_dependent/Virtualshelves.t t/db_dependent/Virtualshelves.t .. No method count found for Koha::Virtualshelves DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'public' in 'where clause' at /kohadevbox/koha/Koha/Objects.pm line 601
This failure is because you didn't run the updatedatabase script with bug 28959 applied. That said, I found some missing bits on that bug as well. So hold on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Bug 28965 depends on bug 28948, which changed state. Bug 28948 Summary: Add a /public counterpart for the libraries REST endpoints https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Bug 28965 depends on bug 28959, which changed state. Bug 28959 Summary: virtualshelves.category is really a boolean https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #5)
This failure is because you didn't run the updatedatabase script with bug 28959 applied. That said, I found some missing bits on that bug as well. So hold on.
Now that the dependencies are pushed, what else needs to be done to move this into Needs Signoff? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 34577 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Seems like there's a few of us keen on this one. Let's get this one in? I'm hoping to tackle bug 18148 before the end of the year, but it relies on having a public list endpoint. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124635|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165976&action=edit Bug 28965: filter_by_public() and filter_by_readable() This patch adds helper methods for lists resultsets. Tests are added for their behavior. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Virtualshelves.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124636|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165977&action=edit Bug 28965: Add /public/lists This patch adds a route for publicly retrieving lists. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've rebased this and got it passing QA scripts.. however it needs a good testing and QA run. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Still applies.. would be nice to see someone QA it soon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize (ashimema) from comment #12)
Still applies.. would be nice to see someone QA it soon.
I've got quite the backlog at the moment, but since this blocks bug 18148 it's definitely on my radar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38050 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 --- Comment #14 from David Cook <dcook@prosentient.com.au> --- I know I'm being slow on this one, but this is one of those ones I'm really going to do at some point, as it relates to a customer request. I figure November/December timeline. Hopefully sooner rather than later but we'll see... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165976|0 |1 is obsolete| | Attachment #165977|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 173624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173624&action=edit Bug 28965: filter_by_public() and filter_by_readable() This patch adds helper methods for lists resultsets. Tests are added for their behavior. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Virtualshelves.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 --- Comment #16 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 173625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173625&action=edit Bug 28965: Add /public/lists This patch adds a route for publicly retrieving lists. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 --- Comment #17 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 173626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173626&action=edit Bug 28965: (QA follow-up) Fix misc qa issues * Tidy code * Fix number of unit tests * Remove unecessary use of delete Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Tomas, can you add api unit tests? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173626|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 173627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173627&action=edit Bug 28965: (QA follow-up) Fix misc qa issues * Tidy code * Fix number of unit tests * Fix use of delete Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #20 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Kyle M Hall (khall) from comment #18)
Tomas, can you add api unit tests?
Oops. Sure! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173624|0 |1 is obsolete| | Attachment #173625|0 |1 is obsolete| | Attachment #173627|0 |1 is obsolete| | --- Comment #21 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 173687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173687&action=edit Bug 28965: filter_by_public() and filter_by_readable() This patch adds helper methods for lists resultsets. Tests are added for their behavior. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Virtualshelves.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 --- Comment #22 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 173688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173688&action=edit Bug 28965: Add /public/lists This patch adds a route for publicly retrieving lists. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 --- Comment #23 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 173689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173689&action=edit Bug 28965: (QA follow-up) Fix misc qa issues * Tidy code * Fix number of unit tests * Fix use of delete Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 --- Comment #24 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 173690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173690&action=edit Bug 28965: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 --- Comment #25 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Kyle M Hall (khall) from comment #18)
Tomas, can you add api unit tests?
Done, please review the changes and let me know if there's something else missing. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173687|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173780&action=edit Bug 28965: filter_by_public() and filter_by_readable() This patch adds helper methods for lists resultsets. Tests are added for their behavior. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Virtualshelves.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173688|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173781&action=edit Bug 28965: Add /public/lists This patch adds a route for publicly retrieving lists. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173689|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173782&action=edit Bug 28965: (QA follow-up) Fix misc qa issues * Tidy code * Fix number of unit tests * Fix use of delete Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173690|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173783&action=edit Bug 28965: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #30 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- All looking good here now, thanks :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38050 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38050 [Bug 38050] Add REST endpoints for working with "lists"/"virtual shelves" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main Text to go in the| |This enhancement adds new release notes| |public API endpoint for | |retrieving lists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #32 from David Nind <david@davidnind.com> --- API not covered in the manual, so no updates required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 --- Comment #33 from David Cook <dcook@prosentient.com.au> --- Looks like it might be missing fields "allow_change_from_staff" and "allow_change_from_permitted_staff" I'm guessing those fields came after this change but haven't looked in depth yet... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 --- Comment #34 from David Cook <dcook@prosentient.com.au> --- @Tomas: have you used this endpoint anywhere outside of Koha yet? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org