[Bug 41367] New: Staff user interface - no sidebar menu when on record sources pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 Bug ID: 41367 Summary: Staff user interface - no sidebar menu when on record sources pages Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl There are no sidebar menu items when you are on record sources pages: 1. Go to Administration > Catalog > Record sources. 2. Note that there are no standard sidebar menu items on the left-hand side. 3. Add a new record source. 4. Note the same as step 2. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |Needs Signoff Sponsorship status|--- |Sponsored Comma delimited| |OpenFifth list of Sponsors| |<https://openfifth.co.uk> Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193535&action=edit Bug 41367: add AdminMenu island and integrate into Record sources - Replace static TT admin-menu sidebar with AdminMenu.vue island web component registered in the islands componentRegistry - Fix NavigationItem to conditionally apply breadcrumb-item class via isBreadcrumb prop, fixing incorrect class on left-menu items - Update record_sources.tt to use sub-header/main-container wrappers with aside='admin-menu', rendering the admin sidebar and breadcrumbs - Update RecordSources/Main.vue to use Teleport for breadcrumbs into the sub-header container and remove self-contained layout Test plan: 1. Go to Administration > Additional parameters > Record sources 2. Confirm the administration sidebar menu appears on the left side of the page, with all sections visible according to your permissions (System preferences, Basic parameters, Catalog, etc.) 3. Confirm the breadcrumb trail at the top reads: Koha > Administration > Record sources 4. Confirm the "Additional parameters" section of the sidebar is expanded and "Record sources" is not highlighted as current (it lives in the main content area, not the sidebar) 5. Click another link in the sidebar (e.g. "System preferences") and confirm navigation works normally 6. Return to Record sources and add, edit, and delete a record source to confirm the sidebar does not interfere with the SPA behaviour 7. Navigate to any other admin page (e.g. Libraries, Item types) and confirm the sidebar still renders correctly on those pages Sponsored-by: OpenFifth <https://openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39224 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39224 [Bug 39224] Move Shibboleth config from koha-conf to the DB -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 193593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193593&action=edit Bug 41367: Add AdminMenu island and integrate into Record sources - Replace static TT admin-menu sidebar with AdminMenu.vue island web component registered in the islands componentRegistry - Fix NavigationItem to conditionally apply breadcrumb-item class via isBreadcrumb prop, fixing incorrect class on left-menu items - Update record_sources.tt to use sub-header/main-container wrappers with aside='admin-menu', rendering the admin sidebar and breadcrumbs - Update RecordSources/Main.vue to use Teleport for breadcrumbs into the sub-header container and remove self-contained layout Test plan: 1. Go to Administration > Catalog > Record sources 2. Confirm the administration sidebar menu appears on the left side of the page, with all sections visible according to your permissions (System preferences, Basic parameters, Catalog, etc.) 3. Confirm the breadcrumb trail at the top reads: Koha > Administration > Record sources 4. Confirm the "Catalog" section of the sidebar is expanded and "Record sources" is not highlighted as current (it lives in the main content area, not the sidebar) 5. Click another link in the sidebar (e.g. "System preferences") and confirm navigation works normally 6. Return to Record sources and add, edit, and delete a record source to confirm the sidebar does not interfere with the SPA behaviour 7. Navigate to any other admin page (e.g. Libraries, Item types) and confirm the sidebar still renders correctly on those pages Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193535|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Comment on attachment 193535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193535 Bug 41367: add AdminMenu island and integrate into Record sources Thanks Martin! I amended the patch test plan to reflect that "Record sources" is under the Catalog section, rather than "Additional parameters" (everything worked as expected). Testing notes using KTD: 1. After applying the patch: yarn build then restart_all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds the missing release notes| |sidebar menu when using | |Administration > Catalog > | |Record sources. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193593|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 --- Comment #4 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 195194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195194&action=edit Bug 41367: Add AdminMenu island and integrate into Record sources - Replace static TT admin-menu sidebar with AdminMenu.vue island web component registered in the islands componentRegistry - Fix NavigationItem to conditionally apply breadcrumb-item class via isBreadcrumb prop, fixing incorrect class on left-menu items - Update record_sources.tt to use sub-header/main-container wrappers with aside='admin-menu', rendering the admin sidebar and breadcrumbs - Update RecordSources/Main.vue to use Teleport for breadcrumbs into the sub-header container and remove self-contained layout Test plan: 1. Go to Administration > Catalog > Record sources 2. Confirm the administration sidebar menu appears on the left side of the page, with all sections visible according to your permissions (System preferences, Basic parameters, Catalog, etc.) 3. Confirm the breadcrumb trail at the top reads: Koha > Administration > Record sources 4. Confirm the "Catalog" section of the sidebar is expanded and "Record sources" is not highlighted as current (it lives in the main content area, not the sidebar) 5. Click another link in the sidebar (e.g. "System preferences") and confirm navigation works normally 6. Return to Record sources and add, edit, and delete a record source to confirm the sidebar does not interfere with the SPA behaviour 7. Navigate to any other admin page (e.g. Libraries, Item types) and confirm the sidebar still renders correctly on those pages Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Really nice one. I love Teleport (didn't know about it). I think we should use it in the vendors page as well. QA script happy, functionality matches expectations and test plan. Well done! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42163 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42163 [Bug 42163] wrapper-staff-tool-plugin.inc no longer loads the admin menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Why did we remove Help? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42534 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42534 [Bug 42534] wrapper-staff-tool-plugin.inc interferes with js and includes in template files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #9 from David Cook <dcook@prosentient.com.au> --- There's a missing dependency for this bug. Someone will want to figure out what it is before deciding whether this needs to be backported to 25.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41367 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Quite an involved display fix, not backporting to 25.05 The manual screenshots don't appear to show a missing sidebar so no changes needed to documentation -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org