https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 128858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128858&action=edit Bug 29750: Reserves.pm should check if a patron is eligible to reserve and item before confirming the reserve Test plan: 1. Create two patrons, with the following patron categories: - Patron A -> Patron - Patron B -> Student 2. Create two items attached to a single biblio record: - Book - Continuing resource 3. Create the following circ rules: Patron category, item type, Holds allowed (total), Holds allowed (daily), Holds per record (count) - Patron, Book, 0, 0, 0 - Student, Book, 1, 1, 1 - All, Continuing resources, 1, 1, 1 4. Place a title level hold on the biblio for patron A 5. Place a title level hold on the biblio for patron B 6. Checkin the Book and notice you are prompted to confirm the hold by Patron A - even though according to circ rules they cannot reserve Books 7. Apply patch and restart services 9. Checkin the Book, and notice you're prompted to confirm the hold by Patron B Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- I have attached the following fixed unit tests: - t/db_dependent/Holds.t - t/db_dependent/Reserves.t I still have to fix these failing unit test files: - t/db_dependent/Circulation.t - t/db_dependent/Holds/HoldItemtypeLimit.t - t/db_dependent/Holds/LocalHoldsPriority.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23172 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 [Bug 23172] Holds queue should check patron category hold policies when mapping items to pending reserves -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128858|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 154140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154140&action=edit Bug 29750: Reserves.pm should check if a patron is eligible to reserve and item before confirming the reserve Test plan: 1. Create two patrons, with the following patron categories: - Patron A -> Patron - Patron B -> Student 2. Create two items attached to a single biblio record: - Book - Continuing resource 3. Create the following circ rules: Patron category, item type, Holds allowed (total), Holds allowed (daily), Holds per record (count) - Patron, Book, 0, 0, 0 - Student, Book, 1, 1, 1 - All, Continuing resources, 1, 1, 1 4. Place a title level hold on the biblio for patron A 5. Place a title level hold on the biblio for patron B 6. Checkin the Book and notice you are prompted to confirm the hold by Patron A - even though according to circ rules they cannot reserve Books 7. Apply patch and restart services 9. Checkin the Book, and notice you're prompted to confirm the hold by Patron B Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23172 | Status|ASSIGNED |Needs Signoff Change sponsored?|--- |Sponsored --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #4)

Hi Alex, should this have a different status?

Hi Katrin, My apologies for the late reply. Yes you're right this should be 'Needs signoff' As this is an old bug report I've just checked upstream and this bug can still be replicated. I've tidied up the patches a bit, they apply cleanly, and they actually don't depend on bug 23172 so I've removed that dependency. Ready for testing. Kind regards Alex Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 [Bug 23172] Holds queue should check patron category hold policies when mapping items to pending reserves -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154140|0 |1 is obsolete| | --- Comment #8 from Sam Lau <samalau@gmail.com> --- Created attachment 154159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154159&action=edit Bug 29750: Reserves.pm should check if a patron is eligible to reserve and item before confirming the reserve Test plan: 1. Create two patrons, with the following patron categories: - Patron A -> Patron - Patron B -> Student 2. Create two items attached to a single biblio record: - Book - Continuing resource 3. Create the following circ rules: Patron category, item type, Holds allowed (total), Holds allowed (daily), Holds per record (count) - Patron, Book, 0, 0, 0 - Student, Book, 1, 1, 1 - All, Continuing resources, 1, 1, 1 4. Place a title level hold on the biblio for patron A 5. Place a title level hold on the biblio for patron B 6. Checkin the Book and notice you are prompted to confirm the hold by Patron A - even though according to circ rules they cannot reserve Books 7. Apply patch and restart services 9. Checkin the Book, and notice you're prompted to confirm the hold by Patron B Sponsored-By: Catalyst IT Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Alex Buckley from comment #0)

Bug 23172 introduced a check for patron categories hold policies when the holds queue maps items to pending reserves.

Just noting that 23172 is still In discussion and not moving. What impact does that have on this report? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- I don't know if I agree with these patches. Rules for placing a hold and rules for filling a hold are not the same. Being allowed to place 0 holds is different than these holds are not allowed. It's subtle, and confusing, but its designed this way and libraries use overrides to place holds that a patron can't place, but they expect to fill -- You are receiving this mail because: You are watching all bug changes.