http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging C4/Installer/PerlDependencies.pm CONFLICT (content): Merge conflict in C4/Installer/PerlDependencies.pm Failed to merge in the changes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Place some holds for two or more branches 4) Run misc/cronjobs/holds/print_holds_to_pull_on_demand.pl --test --printer MPL,lp,printserver,515 --printer CPL,lp2,printserver,516 Each --printer switch is the configuration for a given branch. Each branch can have a separate printer, or multiple branches can use the same printer. The switch value is the branchcode, printer name, server name and server port separated by commas. If a printer is not defined for a given branch, notices for that branch will not be printed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |alex.arnaud@biblibre.com --- Comment #9 from Alex Arnaud <alex.arnaud@biblibre.com> --- Patch does not apply on master: error: patch failed: C4/Installer/PerlDependencies.pm:633 error: C4/Installer/PerlDependencies.pm: patch does not apply error: patch failed: installer/data/mysql/en/mandatory/sample_notices.sql:10 error: installer/data/mysql/en/mandatory/sample_notices.sql: patch does not apply error: patch failed: installer/data/mysql/updatedatabase.pl:6339 error: installer/data/mysql/updatedatabase.pl: patch does not apply -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14394|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16338&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- Now that somebody has actively called my attention to this: +1 to using Net::Printer. +1 to taking advantage of the existing structure for defining print queues. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Galen Charlton from comment #14)

+1 to taking advantage of the existing structure for defining print queues.

I'm afraid I don't believe this to be as good an idea as it may have seemed at first. It appears that admin/printers.pl has been hidden since 2008, 8 years ago. The schema for this table would need to be completely recreated as the existing one does not fit with the data needed for Net::Printer. Even worse, the code itself is extremely broken and would have to be rewritten from scratch. So, in short, we wouldn't be taking advantage of the existing structure for defining print queues, because it would all need to be completely thrown away and totally rewritten, including the printers table itself. I'm not really seeing what the advantage would be to defining the printers from the web interface either. In fact, it seems even a bit unwanted perhaps. Printer configuration is a system administration task. I don't see a great advantage to allowing librarians to alter the printer data from a web interface. Any thoughts? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #18 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Kyle M Hall from comment #16)

(In reply to Galen Charlton from comment #14)

...

+1 to taking advantage of the existing structure for defining print queues.

I'm afraid I don't believe this to be as good an idea as it may have seemed at first. It appears that admin/printers.pl has been hidden since 2008, 8 years ago. The schema for this table would need to be completely recreated as the existing one does not fit with the data needed for Net::Printer. Even worse, the code itself is extremely broken and would have to be rewritten from scratch.

I've sent Chris a query regarding whether he's got the current print queue stuff working for any of his libraries.

So, in short, we wouldn't be taking advantage of the existing structure for defining print queues, because it would all need to be completely thrown away and totally rewritten, including the printers table itself.

Agreed there are some changes that would be required.

I'm not really seeing what the advantage would be to defining the printers from the web interface either. In fact, it seems even a bit unwanted perhaps. Printer configuration is a system administration task. I don't see a great advantage to allowing librarians to alter the printer data from a web interface.

Disagree. Particularly since Net::Printer talks to the printer directly, there isn't any server-side configuration of setting up lpr queues as seems to be required for the current printer queue approach. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some notes after talking to Kyle about this feature: - The prints will happen when the hold is places, the printer used is the pickup branch. This means, that will work for single brnach libraries, but might be a problem to multi branch libraries. Also if the item is - The printed flag being on reserves will make it a bit harder to extend this later, I think I would like a separate table with a time queued and a time printed better. We could also extend that later for other automated prints. - If the flag stays on reserves, we might want to make it a datetime instead for the time it was printed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27127|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28333&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28334|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28335&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28651|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28652&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28653|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28654&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart@biblibre.co | |m --- Comment #29 from Jonathan Druart <jonathan.druart@biblibre.com> --- I fixed the conflict on the first patch bug get fatal: sha1 information is lacking or useless (installer/data/mysql/updatedatabase.pl). on applying the second one. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28333|0 |1 is obsolete| | Attachment #28654|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36833&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #32)

Hi, on your first patch you add on kohastructure.pl `printed` tinyint(1) DEFAULT NULL, for reserves and old_reserves

But on final updatedatabase.pl (needs to be on atomicupdate!), you "only" alter reserves but using a different type

$dbh->do("ALTER TABLE reserves ADD printed DATETIME NULL AFTER suspend_until");

Both patches have conflicts

Good catch! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36833|0 |1 is obsolete| | Attachment #36834|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40749&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40751&action=edit Bug 8352 [QA Followup] - Fix column type in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Kyle, 1/ You propose a --test option to the script, but I think the test behavior should be the default and --confirm should sent the job to the printer, don't you think? 2/ Please avoid sql queries in pl scripts. 3/ You should also address Bernardo's concern. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40749|0 |1 is obsolete| | Attachment #40750|0 |1 is obsolete| | Attachment #40751|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41579&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41581&action=edit Bug 8352 [QA Followup] - Fix column type in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #43 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41583&action=edit Bug 8352 [QA Followup] - Don't use SQL in pl files -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- svc/printer does not follow the coding guidelines. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli@cineca.it Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44360&action=edit [SIGNED-OFF] Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server Signed-off-by: Jenice Tate <jtate@mdah.state.ms.us> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44362&action=edit [SIGNED-OFF] Bug 8352 [QA Followup] * Add --confirm option to print_holds.pl * Modify old_reserves to match reserves Signed-off-by: Jenice Tate <jtate@mdah.state.ms.us> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please rebase - there are several conflicts. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44359|0 |1 is obsolete| | Attachment #44360|0 |1 is obsolete| | Attachment #44361|0 |1 is obsolete| | Attachment #44362|0 |1 is obsolete| | Attachment #44363|0 |1 is obsolete| | --- Comment #53 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45275&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45277&action=edit Bug 8352 [QA Followup] - Fix column type in kohastructure.sql Signed-off-by: Jenice Tate <jtate@mdah.state.ms.us> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45279&action=edit Bug 8352 [QA Followup] - Don't use SQL in pl files Signed-off-by: Jenice Tate <jtate@mdah.state.ms.us> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #59 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is it possible both modules are not packaged for Ubuntu? I couldn't install/find either via apt-get? I think the dependency questions need to be resolved first, before we can move this further through QA! Starting with a code review anyway: 1) QA script FAIL koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/printers.tt FAIL spelling recieve ==> receive FAIL misc/cronjobs/holds/print_holds.pl FAIL pod *** ERROR: =over on line 135 without closing =back (at head1) in file misc/cronjobs/holds/print_holds.pl 2) New notice a) The insert statements are missing the message_transport_type: +INSERT INTO `letter` (`module`,`code`,`branchcode`,`name`,`is_html`,`title`,`content`) b) HOLD_PLACED_PRINT sounds like there is a connection to the existing HOLD_PLACED feature. If this is the case, should this be just the 'print' version of the HOLD_PLACED notice? And if not, should we rename to make the difference clear? c) Notice is missing from the translated web installers. 3) Templates a) Icons need to be switched to Font Awesome. For example: koha-tmpl/intranet-tmpl/prog/en/includes/printers-toolbar.inc. b) koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt changes the heading and description of one of the toolbar items back to the old one, should be: Z39.50/SRU searvers c) I think page title/breadcrumbs and the new entry on Administration should match. Personally I'd prefer the simpler 'Printers' to 'Printer editor' as it's more in line with our other pages. d) This would be nicer to translate using the newer syntax and a placeholder: else if (confirm(_("Are you sure you wish to delete printer(s) ") + idsToDelete + "?")) See: Bug 12138 - Use placeholders in translatable javascript strings 4) Terminology Holds!! :) koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/printers.tt print automatic reserve notices 5) Copyright Is the copyright correct on the new file svc/printer? +# Copyright 2014 ByWater Solutions +# Copyright 2012 Foundations Bible College Inc. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45278|0 |1 is obsolete| | --- Comment #61 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45362&action=edit Bug 8352 [QA Followup] -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #63 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Kyle, can you verify that the dependencies both need packaging? Are there possible alternatives? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #65 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kyle M Hall from comment #60)

I have no experience packaging modules nor do I see any documentation on the Koha wiki.

http://wiki.koha-community.org/wiki/Building_Debian_Dependencies/Dependency_... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #68 from Galen Charlton <gmcharlt@gmail.com> --- Noting licenses of the proposed dependencies: Net::Printer - BSD; GPL- and DFSG-compatible Printer - Artistic License; not GPL-compatible, but DFSG-free. (Ancient module, though, and doesn't appear to be currently maintained). HTML::HTMLDoc - Perl license. (Also ancient, doesn't appear to be currently maintained, and has 23 open issues on CPAN). I wonder if Net::CUPS might be a better bet; it's currently packaged for Debian, but on the other hand, the Perl module doesn't appear to be maintained either. :/ -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #70 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Moving this to FQA to get feedback from Kyle about the proposed alternatives. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #72 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45652&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server Signed-off-by: Jenice Tate <jtate@mdah.state.ms.us> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #74 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45654&action=edit Bug 8352 [QA Followup] - Don't use SQL in pl files Signed-off-by: Jenice Tate <jtate@mdah.state.ms.us> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #76 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45656&action=edit Bug 8352 [QA Followup] - Notices for translation -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45657|0 |1 is obsolete| | --- Comment #78 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45658&action=edit Bug 8352 [QA Followup] - Remove use of HTML::HTMLDoc -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #80 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #70)

Moving this to FQA to get feedback from Kyle about the proposed alternatives.

I've switch to PDF::FromHTML due to the encoding and other issues related to HTML::HTMLDoc. I don't think there is a compelling reason to switch to Net::CUPS considering it is no more active than the currently used modules, and doesn't have very good documentation. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8034 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #83 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- fatal: sha1 information is lacking or useless (C4/Installer/PerlDependencies.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 8352 - Add printer administration, update script to use Koha defined printers -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45651|0 |1 is obsolete| | Attachment #45652|0 |1 is obsolete| | Attachment #45653|0 |1 is obsolete| | Attachment #45654|0 |1 is obsolete| | Attachment #45655|0 |1 is obsolete| | Attachment #45656|0 |1 is obsolete| | Attachment #45659|0 |1 is obsolete| | --- Comment #84 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46878&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #86 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46880&action=edit Bug 8352 [QA Followup] - Fix column type in kohastructure.sql Signed-off-by: Jenice Tate <jtate@mdah.state.ms.us> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #88 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46882&action=edit Bug 8352 [QA Followup] -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #90 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46884&action=edit Bug 8352 [QA Followup] - Remove use of HTML::HTMLDoc -- You are receiving this mail because: You are watching all bug changes.