[Bug 33010] New: CheckinSlip doesn't return checkins if checkout branch and checkin branch differ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Bug ID: 33010 Summary: CheckinSlip doesn't return checkins if checkout branch and checkin branch differ Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org If one tries to print checkin slip for checkins that have been checked out from different branch, list of checkins is empty. One has to change their branch as checkout library to be able to print checkins. To test: 1. Checkout items for patron from branch A. 2. Switch to branch B and checkin items. 3. Print checkin slip. => Checkins list is empty. 4. Switch back to branch A. 5. Print checkin slip again. => Checkins are printed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 146943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146943&action=edit Bug 33010: Do not filter checkins with logged in patrons branch in printslip.pl If one tries to print checkin slip for checkins that have been checked out from different branch, list of checkins is empty. One has to change their branch as checkout library to be able to print checkins. This happens because we filter (or rather search) patrons old checkouts with logged in patrons branch. This patch removes this search so that checkout are filtered using just filter_by_todays_checkins. To test: 1. Checkout items for patron from branch A. 2. Switch to branch B and checkin items. 3. Print checkin slip. => Checkins list is empty. 4. Switch back to branch A. 5. Print checkin slip again. => Checkins are printed. 6. Apply this patch, restart services if needed. 7. Switch back to branch B and print checkin slip. => Checkins should now print. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think the idea might have been to limit on the checkin library, as this is the library that will print on the slip. But I gather it's currently looking at the checkout library? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Katrin Fischer from comment #2)
Hm, I think the idea might have been to limit on the checkin library, as this is the library that will print on the slip. But I gather it's currently looking at the checkout library?
Yes, it's using branch for logged in patron but looking at the checkout library. It seems this happens because (old_)reserves branchcode column is filled with info of the checkout library. If we had returnbranch column or something like that, we could search with it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146943|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 150174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150174&action=edit Bug 33010: Do not filter checkins with logged in patrons branch in printslip.pl If one tries to print checkin slip for checkins that have been checked out from different branch, list of checkins is empty. One has to change their branch as checkout library to be able to print checkins. This happens because we filter (or rather search) patrons old checkouts with logged in patrons branch. This patch removes this search so that checkout are filtered using just filter_by_todays_checkins. To test: 1. Checkout items for patron from branch A. 2. Switch to branch B and checkin items. 3. Print checkin slip. => Checkins list is empty. 4. Switch back to branch A. 5. Print checkin slip again. => Checkins are printed. 6. Apply this patch, restart services if needed. 7. Switch back to branch B and print checkin slip. => Checkins should now print. Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150174|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 150429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150429&action=edit Bug 33010: Do not filter checkins with logged in patrons branch in printslip.pl If one tries to print checkin slip for checkins that have been checked out from different branch, list of checkins is empty. One has to change their branch as checkout library to be able to print checkins. This happens because we filter (or rather search) patrons old checkouts with logged in patrons branch. This patch removes this search so that checkout are filtered using just filter_by_todays_checkins. To test: 1. Checkout items for patron from branch A. 2. Switch to branch B and checkin items. 3. Print checkin slip. => Checkins list is empty. 4. Switch back to branch A. 5. Print checkin slip again. => Checkins are printed. 6. Apply this patch, restart services if needed. 7. Switch back to branch B and print checkin slip. => Checkins should now print. Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33641 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 [Bug 33641] We should record return branch in old checkouts (oldissues) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|CheckinSlip doesn't return |CheckinSlip doesn't return |checkins if checkout branch |checkins if checkout |and checkin branch differ |library and checkin library | |differ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- It would be very nice if this one could be backported into 22.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.07 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org