[Bug 36154] New: Add images to the lists and loan histories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Bug ID: 36154 Summary: Add images to the lists and loan histories Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: matthias.le-gac@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Display images in lists and loan histories in both OPAC and the staff interface, similar to when conducting a search. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |matthias.le-gac@inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |matthias.le-gac@inlibro.com | |, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|matthias.le-gac@inlibro.com |hammat.wele@inlibro.com CC| |hammat.wele@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add images to the lists and |Add the ability for some |loan histories |pages to be able to use | |images coming from plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #1 from Hammat wele <hammat.wele@inlibro.com> --- The patch adds images in the list page in staff interface and make the summary page(opac-user), the list pages (opac-shelves.pl, shelves.pl) and the Checkout history page (opac-readingrecord.pl) to be able to display images comming from plugin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #2 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 163744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163744&action=edit Bug 36154: Add the ability for some pages to be able to use images comming from plugin The patch adds images in the list page in staff interface and make the summary page(opac-user), the list pages (opac-shelves.pl, shelves.pl) and the Checkout history page (opac-readingrecord.pl) to be able to display images comming from plugin. To test 1. Log in to the staff interface 2. Make sure the system preference LocalCoverImages has «Show» value 3. Create a nwalist 4.1. Click on «More» menu then click on «List» and click on «New List» 4. Search for a record and add a local image to it 5. Add the record to the list created on step 4.1 6. Check the list ----> The image is not displayed 7. Apply the patch 8. Check the list again ----> the image is now display in a new column named «Cover» -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|matthias.le-gac@inlibro.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com --- Comment #3 from Esther Melander <esther.melander@bywatersolutions.com> --- I tested this. I added some local cover images to a few items in a list. I could see the Cover column for the list, but not the local images. I checked the Opac and did not see any local cover images. I turned on the system preference OPACLocalCoverImages to see the images in the OPAC and they did not show in the Patron Summary, Patron Checkout History, or in the public list. There was no separate column for the Cover image in the Patron Summary or Checkout History. I then turned on: AmazonCoverImages OPACAmazonCoverImages This then displayed Amazon cover images and my local cover images in the OPAC. The cover images still did not show in the staff interface list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163744|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #4 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 168157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168157&action=edit Bug 36154: Showing LocalCoverImages and CustomCoverImages in the list page in staff interface To test 1. Log in to the staff interface 2. Make sure the system preference LocalCoverImages has «Show» value 3. Create a new list 4.1. Click on «More» menu then click on «List» and click on «New List» 4. Search for a record and add a local image to it 5. Add the record to the list created on step 4.1 6. Check the list ----> The image is not displayed 7. Apply the patch 8. Check the list again ----> the image is now display in a new column named «Cover» 9. Put the system preference LocalCoverImages to «Don't show» and CustomCoverImages to « Show » and add an image url to CustomCoverImagesURL (https://upload.wikimedia.org/wikipedia/commons/thumb/3/3a/Cat03.jpg/481px-Ca...) 10. Check the list again ----> the image in CustomCoverImagesURL is display in the column named «Cover» -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #5 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 168158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168158&action=edit Bug 36154: Display images coming from plugin this patch makes the summary page(opac-user), the list pages (opac-shelves.pl, shelves.pl), the Checkout history page (opac-readingrecord.pl) and shelfbrowser to be able to display images coming from plugin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #6 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 168925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168925&action=edit Bug 36154: Make shelfbrowser.tt to be able to use images coming from plugins -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168157|0 |1 is obsolete| | --- Comment #7 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 170295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170295&action=edit Bug 36154: Showing LocalCoverImages and CustomCoverImages in the list page in staff interface To test 1. Log in to the staff interface 2. Make sure the system preference LocalCoverImages has «Show» value 3. Create a new list 4.1. Click on «More» menu then click on «List» and click on «New List» 4. Search for a record and add a local image to it 5. Add the record to the list created on step 4.1 6. Check the list ----> The image is not displayed 7. Apply the patch 8. Check the list again ----> the image is now display in a new column named «Cover» 9. Put the system preference LocalCoverImages to «Don't show» and CustomCoverImages to « Show » and add an image url to CustomCoverImagesURL (https://upload.wikimedia.org/wikipedia/commons/thumb/3/3a/Cat03.jpg/481px-Ca...) 10. Check the list again ----> the image in CustomCoverImagesURL is display in the column named «Cover» -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168158|0 |1 is obsolete| | --- Comment #8 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 170296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170296&action=edit Bug 36154: Display images coming from plugin this patch makes the summary page(opac-user), the list pages (opac-shelves.pl, shelves.pl), the Checkout history page (opac-readingrecord.pl) and shelfbrowser to be able to display images coming from plugin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168925|0 |1 is obsolete| | --- Comment #9 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 170297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170297&action=edit Bug 36154: Make shelfbrowser.tt to be able to use images coming from plugins -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170295|0 |1 is obsolete| | --- Comment #10 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 173593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173593&action=edit Bug 36154: Showing LocalCoverImages and CustomCoverImages in the list page in staff interface To test 1. Log in to the staff interface 2. Make sure the system preference LocalCoverImages has «Show» value 3. Create a new list 4.1. Click on «More» menu then click on «List» and click on «New List» 4. Search for a record and add a local image to it 5. Add the record to the list created on step 4.1 6. Check the list ----> The image is not displayed 7. Apply the patch 8. Check the list again ----> the image is now display in a new column named «Cover» 9. Put the system preference LocalCoverImages to «Don't show» and CustomCoverImages to « Show » and add an image url to CustomCoverImagesURL (https://upload.wikimedia.org/wikipedia/commons/thumb/3/3a/Cat03.jpg/481px-Ca...) 10. Check the list again ----> the image in CustomCoverImagesURL is display in the column named «Cover» https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170296|0 |1 is obsolete| | --- Comment #11 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 173594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173594&action=edit Bug 36154: Display images coming from plugin this patch makes the summary page(opac-user), the list pages (opac-shelves.pl, shelves.pl), the Checkout history page (opac-readingrecord.pl) and shelfbrowser to be able to display images coming from plugin. https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170297|0 |1 is obsolete| | --- Comment #12 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 173595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173595&action=edit Bug 36154: Make shelfbrowser.tt to be able to use images coming from plugins https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173593|0 |1 is obsolete| | --- Comment #13 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 175490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175490&action=edit Bug 36154: Showing LocalCoverImages and CustomCoverImages in the list page in staff interface To test 1. Log in to the staff interface 2. Make sure the system preference LocalCoverImages has «Show» value 3. Create a new list 4.1. Click on «More» menu then click on «List» and click on «New List» 4. Search for a record and add a local image to it 5. Add the record to the list created on step 4.1 6. Check the list ----> The image is not displayed 7. Apply the patch 8. Check the list again ----> the image is now display in a new column named «Cover» 9. Put the system preference LocalCoverImages to «Don't show» and CustomCoverImages to « Show » and add an image url to CustomCoverImagesURL (https://upload.wikimedia.org/wikipedia/commons/thumb/3/3a/Cat03.jpg/481px-Ca...) 10. Check the list again ----> the image in CustomCoverImagesURL is display in the column named «Cover» https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173594|0 |1 is obsolete| | --- Comment #14 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 175491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175491&action=edit Bug 36154: Display images coming from plugin this patch makes the summary page(opac-user), the list pages (opac-shelves.pl, shelves.pl), the Checkout history page (opac-readingrecord.pl) and shelfbrowser to be able to display images coming from plugin. https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173595|0 |1 is obsolete| | --- Comment #15 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 175492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175492&action=edit Bug 36154: Make shelfbrowser.tt to be able to use images coming from plugins https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175490|0 |1 is obsolete| | --- Comment #16 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 179892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179892&action=edit Bug 36154: Showing LocalCoverImages and CustomCoverImages in the list page in staff interface To test 1. Log in to the staff interface 2. Make sure the system preference LocalCoverImages has «Show» value 3. Create a new list 4.1. Click on «More» menu then click on «List» and click on «New List» 4. Search for a record and add a local image to it 5. Add the record to the list created on step 4.1 6. Check the list ----> The image is not displayed 7. Apply the patch 8. Check the list again ----> the image is now display in a new column named «Cover» 9. Put the system preference LocalCoverImages to «Don't show» and CustomCoverImages to « Show » and add an image url to CustomCoverImagesURL (https://upload.wikimedia.org/wikipedia/commons/thumb/3/3a/Cat03.jpg/481px-Ca...) 10. Check the list again ----> the image in CustomCoverImagesURL is display in the column named «Cover» https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175491|0 |1 is obsolete| | --- Comment #17 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 179893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179893&action=edit Bug 36154: Display images coming from plugin this patch makes the summary page(opac-user), the list pages (opac-shelves.pl, shelves.pl), the Checkout history page (opac-readingrecord.pl) and shelfbrowser to be able to display images coming from plugin. https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175492|0 |1 is obsolete| | --- Comment #18 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 179894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179894&action=edit Bug 36154: Make shelfbrowser.tt to be able to use images coming from plugins https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179892|0 |1 is obsolete| | --- Comment #19 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 181290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181290&action=edit Bug 36154: Showing LocalCoverImages and CustomCoverImages in the list page in staff interface To test 1. Log in to the staff interface 2. Make sure the system preference LocalCoverImages has «Show» value 3. Create a new list 4.1. Click on «More» menu then click on «List» and click on «New List» 4. Search for a record and add a local image to it 5. Add the record to the list created on step 4.1 6. Check the list ----> The image is not displayed 7. Apply the patch 8. Check the list again ----> the image is now display in a new column named «Cover» 9. Put the system preference LocalCoverImages to «Don't show» and CustomCoverImages to « Show » and add an image url to CustomCoverImagesURL (https://upload.wikimedia.org/wikipedia/commons/thumb/3/3a/Cat03.jpg/481px-Ca...) 10. Check the list again ----> the image in CustomCoverImagesURL is display in the column named «Cover» https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179893|0 |1 is obsolete| | --- Comment #20 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 181291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181291&action=edit Bug 36154: Display images coming from plugin this patch makes the summary page(opac-user), the list pages (opac-shelves.pl, shelves.pl), the Checkout history page (opac-readingrecord.pl) and shelfbrowser to be able to display images coming from plugin. https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179894|0 |1 is obsolete| | --- Comment #21 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 181292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181292&action=edit Bug 36154: Make shelfbrowser.tt to be able to use images coming from plugins https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shi-yao.wang@inLibro.com --- Comment #22 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #23 from Esther Melander <esther.melander@bywatersolutions.com> --- I could sign-off on this by following the test plan in comment 19. However comment 20 suggests the cover images should show in more places. I wasn't sure if there should be some additional steps for the test plan to account for all of the places the cover images should show? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #24 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 186379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186379&action=edit Bug 36154: (follow-up) fix column alignment when no cover source enabled (Local, Custom, or Plugin) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #25 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 186535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186535&action=edit Bug 36154: (follow-up) Add missing CoverImagePlugins in shelves.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181290|0 |1 is obsolete| | --- Comment #26 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 188217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188217&action=edit Bug 36154: Showing LocalCoverImages and CustomCoverImages in the list page in staff interface To test 1. Log in to the staff interface 2. Make sure the system preference LocalCoverImages has «Show» value 3. Create a new list 4.1. Click on «More» menu then click on «List» and click on «New List» 4. Search for a record and add a local image to it 5. Add the record to the list created on step 4.1 6. Check the list ----> The image is not displayed 7. Apply the patch 8. Check the list again ----> the image is now display in a new column named «Cover» 9. Put the system preference LocalCoverImages to «Don't show» and CustomCoverImages to « Show » and add an image url to CustomCoverImagesURL (https://upload.wikimedia.org/wikipedia/commons/thumb/3/3a/Cat03.jpg/481px-Ca...) 10. Check the list again ----> the image in CustomCoverImagesURL is display in the column named «Cover» https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181291|0 |1 is obsolete| | --- Comment #27 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 188218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188218&action=edit Bug 36154: Display images coming from plugin this patch makes the summary page(opac-user), the list pages (opac-shelves.pl, shelves.pl), the Checkout history page (opac-readingrecord.pl) and shelfbrowser to be able to display images coming from plugin. https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181292|0 |1 is obsolete| | --- Comment #28 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 188219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188219&action=edit Bug 36154: Make shelfbrowser.tt to be able to use images coming from plugins https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186379|0 |1 is obsolete| | --- Comment #29 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 188220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188220&action=edit Bug 36154: (follow-up) fix column alignment when no cover source enabled (Local, Custom, or Plugin) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186535|0 |1 is obsolete| | --- Comment #30 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 188221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188221&action=edit Bug 36154: (follow-up) Add missing CoverImagePlugins in shelves.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #31 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188217|0 |1 is obsolete| | --- Comment #32 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 189811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189811&action=edit Bug 36154: Showing LocalCoverImages and CustomCoverImages in the list page in staff interface To test 1. Log in to the staff interface 2. Make sure the system preference LocalCoverImages has «Show» value 3. Create a new list 4.1. Click on «More» menu then click on «List» and click on «New List» 4. Search for a record and add a local image to it 5. Add the record to the list created on step 4.1 6. Check the list ----> The image is not displayed 7. Apply the patch 8. Check the list again ----> the image is now display in a new column named «Cover» 9. Put the system preference LocalCoverImages to «Don't show» and CustomCoverImages to « Show » and add an image url to CustomCoverImagesURL (https://upload.wikimedia.org/wikipedia/commons/thumb/3/3a/Cat03.jpg/481px-Ca...) 10. Check the list again ----> the image in CustomCoverImagesURL is display in the column named «Cover» https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188218|0 |1 is obsolete| | --- Comment #33 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 189812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189812&action=edit Bug 36154: Display images coming from plugin this patch makes the summary page(opac-user), the list pages (opac-shelves.pl, shelves.pl), the Checkout history page (opac-readingrecord.pl) and shelfbrowser to be able to display images coming from plugin. https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188219|0 |1 is obsolete| | --- Comment #34 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 189813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189813&action=edit Bug 36154: Make shelfbrowser.tt to be able to use images coming from plugins https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188220|0 |1 is obsolete| | --- Comment #35 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 189814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189814&action=edit Bug 36154: (follow-up) fix column alignment when no cover source enabled (Local, Custom, or Plugin) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188221|0 |1 is obsolete| | --- Comment #36 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 189815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189815&action=edit Bug 36154: (follow-up) Add missing CoverImagePlugins in shelves.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #37 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189811|0 |1 is obsolete| | --- Comment #38 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 190397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190397&action=edit Bug 36154: Showing LocalCoverImages and CustomCoverImages in the list page in staff interface To test 1. Log in to the staff interface 2. Make sure the system preference LocalCoverImages has «Show» value 3. Create a new list 4.1. Click on «More» menu then click on «List» and click on «New List» 4. Search for a record and add a local image to it 5. Add the record to the list created on step 4.1 6. Check the list ----> The image is not displayed 7. Apply the patch 8. Check the list again ----> the image is now display in a new column named «Cover» 9. Put the system preference LocalCoverImages to «Don't show» and CustomCoverImages to « Show » and add an image url to CustomCoverImagesURL (https://upload.wikimedia.org/wikipedia/commons/thumb/3/3a/Cat03.jpg/481px-Ca...) 10. Check the list again ----> the image in CustomCoverImagesURL is display in the column named «Cover» https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189812|0 |1 is obsolete| | --- Comment #39 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 190398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190398&action=edit Bug 36154: Display images coming from plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189813|0 |1 is obsolete| | --- Comment #40 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 190399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190399&action=edit Bug 36154: Make shelfbrowser.tt to be able to use images coming from plugins https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189814|0 |1 is obsolete| | --- Comment #41 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 190400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190400&action=edit Bug 36154: (follow-up) fix column alignment when no cover source enabled (Local, Custom, or Plugin) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189815|0 |1 is obsolete| | --- Comment #42 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 190401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190401&action=edit Bug 36154: (follow-up) Add missing CoverImagePlugins in shelves.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190397|0 |1 is obsolete| | --- Comment #43 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 192827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192827&action=edit Bug 36154: Showing LocalCoverImages and CustomCoverImages in the list page in staff interface To test 1. Log in to the staff interface 2. Make sure the system preference LocalCoverImages has «Show» value 3. Create a new list 4.1. Click on «More» menu then click on «List» and click on «New List» 4. Search for a record and add a local image to it 5. Add the record to the list created on step 4.1 6. Check the list ----> The image is not displayed 7. Apply the patch 8. Check the list again ----> the image is now display in a new column named «Cover» 9. Put the system preference LocalCoverImages to «Don't show» and CustomCoverImages to « Show » and add an image url to CustomCoverImagesURL (https://upload.wikimedia.org/wikipedia/commons/thumb/3/3a/Cat03.jpg/481px-Ca...) 10. Check the list again ----> the image in CustomCoverImagesURL is display in the column named «Cover» https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190398|0 |1 is obsolete| | --- Comment #44 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 192828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192828&action=edit Bug 36154: Display images coming from plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190399|0 |1 is obsolete| | --- Comment #45 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 192829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192829&action=edit Bug 36154: Make shelfbrowser.tt to be able to use images coming from plugins https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190400|0 |1 is obsolete| | --- Comment #46 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 192830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192830&action=edit Bug 36154: (follow-up) fix column alignment when no cover source enabled (Local, Custom, or Plugin) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190401|0 |1 is obsolete| | --- Comment #47 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 192831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192831&action=edit Bug 36154: (follow-up) Add missing CoverImagePlugins in shelves.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #48 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192827|0 |1 is obsolete| | --- Comment #49 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 195621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195621&action=edit Bug 36154: Showing LocalCoverImages and CustomCoverImages in the list page in staff interface To test 1. Log in to the staff interface 2. Make sure the system preference LocalCoverImages has «Show» value 3. Create a new list 4.1. Click on «More» menu then click on «List» and click on «New List» 4. Search for a record and add a local image to it 5. Add the record to the list created on step 4.1 6. Check the list ----> The image is not displayed 7. Apply the patch 8. Check the list again ----> the image is now display in a new column named «Cover» 9. Put the system preference LocalCoverImages to «Don't show» and CustomCoverImages to « Show » and add an image url to CustomCoverImagesURL (https://upload.wikimedia.org/wikipedia/commons/thumb/3/3a/Cat03.jpg/481px-Ca...) 10. Check the list again ----> the image in CustomCoverImagesURL is display in the column named «Cover» https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192828|0 |1 is obsolete| | --- Comment #50 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 195622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195622&action=edit Bug 36154: Display images coming from plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192829|0 |1 is obsolete| | --- Comment #51 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 195623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195623&action=edit Bug 36154: Make shelfbrowser.tt to be able to use images coming from plugins https://bugs.koha-community.org/show_bug.cgi?id=37916 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192830|0 |1 is obsolete| | --- Comment #52 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 195624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195624&action=edit Bug 36154: (follow-up) fix column alignment when no cover source enabled (Local, Custom, or Plugin) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192831|0 |1 is obsolete| | --- Comment #53 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 195625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195625&action=edit Bug 36154: (follow-up) Add missing CoverImagePlugins in shelves.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #54 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #55 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I'm going to take this on to get it over the line, but I'd like to point out that had you interacted with the bug and replied to Esther's comments this bug would have been in the QA queue over a year ago. Esther when to the effort of testing the bug ready for signoff and all it needed was a little bit of feedback given her comments. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195621|0 |1 is obsolete| | Attachment #195622|0 |1 is obsolete| | Attachment #195623|0 |1 is obsolete| | Attachment #195624|0 |1 is obsolete| | Attachment #195625|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #56 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203644&action=edit Bug 36154: Show LocalCoverImages and CustomCoverImages in the staff interface list view Adds a "Cover" column to the list contents table (virtualshelves/shelves.pl) so that local and custom cover images, already shown on the bibliographic detail page, are also visible when browsing the titles on a list. Test plan: 1. Log in to the staff interface 2. Set the LocalCoverImages system preference to "Show" 3. Search the catalogue, open a record that has a local cover image attached, and add it to a new list (More > Lists > New list) 4. Open the list => No "Cover" column/image is shown 5. Apply the patch and reload the list => A "Cover" column now shows the local cover image 6. Set LocalCoverImages to "Don't show", set CustomCoverImages to "Show" and CustomCoverImagesURL to, e.g. https://upload.wikimedia.org/wikipedia/commons/thumb/3/3a/Cat03.jpg/481px-Ca... 7. Reload the list => The custom cover image is now shown in the "Cover" column instead 8. Set both LocalCoverImages and CustomCoverImages to "Don't show" and reload the list => The "Cover" column is no longer displayed (see the follow-up patches later in this series for the column-alignment fix this relies on) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #57 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203645&action=edit Bug 36154: Display cover images coming from plugins in the OPAC Adds the [% CoverImagePlugins | $raw %] output to the OPAC "Your summary" (opac-user.tt) and "Your reading history" (opac-readingrecord.tt) pages, and extends the shelf browser's (shelfbrowser.inc) cover-image gating condition, so that a plugin implementing the opac_cover_images plugin hook can inject cover images on these pages the same way it already can elsewhere in the OPAC. Test plan: 1. Enable plugins (<enable_plugins> in koha-conf.xml) and install/enable a plugin implementing the opac_cover_images hook. For example, add the following method to any installed plugin (see t/lib/plugins/Koha/Plugin/Test.pm for the shape of a minimal plugin package): sub opac_cover_images { my $self = shift; return q{<script>console.log("opac_cover_images hook fired");</script>}; } 2. Log in to the OPAC and check out/return a title so it appears in your history, then go to "Your summary" (opac-user.pl) => Before the patch, "View page source" shows no trace of the plugin's output => After the patch, the <script> block returned by opac_cover_images is present in the page source and its console.log fires 3. Go to "Your reading history" (opac-readingrecord.pl) => Same check as step 2 4. Open the title's detail page in the OPAC and click "Browse shelf" => The shelf browser's cover-image condition now also accounts for CoverImagePlugins (the script injection for the shelf browser itself is wired up by the next patch in this series, which updates svc/shelfbrowser.tt) 5. Disable the plugin (or turn off enable_plugins) and confirm the three pages above still behave exactly as before, and that GoogleJackets/ Amazon/Syndetics/local/custom cover images are unaffected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #58 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203646&action=edit Bug 36154: Inject plugin cover images into the OPAC shelf browser widget The shelf browser widget ("Browse shelf" on opac-detail.pl) is rendered server-side by svc/shelfbrowser.tt, which processes shelfbrowser.inc directly and is never routed through opac-bottom.inc. Because of that, the CoverImagePlugins output added for the rest of the OPAC in the previous patch is not automatically available here and has to be set up and printed explicitly in this template too. Test plan: 1. Enable plugins and install/enable a plugin implementing opac_cover_images (see the previous patch in this series for a minimal example method) 2. In the OPAC, open a bibliographic detail page for a title shelved near other items, and click "Browse shelf" to open the shelf browser 3. View the page source of the shelf browser response (/cgi-bin/koha/svc/shelfbrowser) => Before the patch, the plugin's <script> output is absent => After the patch, it is present and its console.log fires 4. Disable the plugin and confirm the shelf browser still renders normally for titles using Local/Custom/Amazon/Syndetics/GoogleJackets/Coce cover sources -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #59 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203647&action=edit Bug 36154: (follow-up) Fix "Cover" column alignment in the staff list view when no cover source is enabled The "Cover" <th> header added earlier in this series is only rendered when at least one cover source (CoverImagePlugins, LocalCoverImages, or CustomCoverImages) is enabled, but the corresponding <td> for each row was always rendered regardless, producing one more <td> than <th> and shifting every following column out of alignment with its header. This wraps the per-row <td> in the same condition already used for the header. Test plan: 1. Set LocalCoverImages, CustomCoverImages, and any cover-image plugin all to disabled 2. Log in to the staff interface, open a list containing at least one title, and view it => Before the patch, the "Item type" column and everything after it is shifted one column to the left relative to its header 3. Apply the patch and reload the list => Columns line up correctly with their headers again 4. Re-enable LocalCoverImages (or CustomCoverImages, or a cover-image plugin) and confirm the "Cover" column and its header both reappear and stay aligned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #60 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203648&action=edit Bug 36154: (follow-up) Add missing CoverImagePlugins output to shelves.tt The staff list view (virtualshelves/shelves.pl) already gated the "Cover" column on CoverImagePlugins and reserved a <td> for it, but never actually printed the [% CoverImagePlugins | $raw %] script block, so a plugin's cover-image JS was never injected into the page. A library relying solely on a cover-image plugin (no LocalCoverImages/CustomCoverImages) would see an empty "Cover" column with nothing able to fill it. This is the last patch of the series. The test plan below exercises every page touched by this patchset, end to end. Test plan: 1. Enable plugins (<enable_plugins> in koha-conf.xml). Install/enable a plugin implementing both intranet_cover_images and opac_cover_images, for example by adding to any installed plugin (see t/lib/plugins/Koha/Plugin/Test.pm for the shape of a minimal plugin package): sub intranet_cover_images { my $self = shift; return q{<script>console.log("intranet_cover_images hook fired");</script>}; } sub opac_cover_images { my $self = shift; return q{<script>console.log("opac_cover_images hook fired");</script>}; } 2. Staff interface list view (virtualshelves/shelves.pl): a. With LocalCoverImages, CustomCoverImages and the plugin all disabled, open a list => no "Cover" column, columns aligned correctly b. Enable only the plugin above, reload the list => the "Cover" column header appears and "View page source" shows the plugin's <script> block; opening devtools confirms the console.log fires c. Enable LocalCoverImages, add a title with a local cover image to the list => its image is shown in the "Cover" column d. Disable LocalCoverImages, enable CustomCoverImages/ CustomCoverImagesURL => the custom cover image is shown instead 3. OPAC "Your summary" (opac-user.pl) and "Your reading history" (opac-readingrecord.pl): a. With the plugin still enabled, log in to the OPAC and check out/ return a title so it appears on both pages b. View page source on each page and confirm the plugin's opac_cover_images <script> block is present and its console.log fires 4. OPAC shelf browser: a. With the plugin enabled, open the title's detail page in the OPAC and click "Browse shelf" b. Confirm the plugin's <script> block is present in the /cgi-bin/koha/svc/shelfbrowser response and executes 5. Disable the plugin again and re-confirm steps 2-4 behave exactly as they do on main for Local/Custom/Amazon/Syndetics/GoogleJackets/Coce cover images (regression check for the intermittent report that cover images were not appearing anywhere in these views without AmazonCoverImages enabled) 6. Sign off only once a comment on the bug confirms step 5 above, since that report against an earlier version of this patchset was never explicitly re-confirmed as fixed 7. koha-qa.pl -c 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #61 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 203649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203649&action=edit Bug 36154: (QA follow-up) Rework cover-image-plugin integration around the existing .cover-slider contract QA review of this patchset (and live testing with the community's BDS Covers plugin, https://github.com/PTFS-Europe/koha-plugin-addBDSCovers) found that none of the five templates this bug touches actually let a cover-image plugin render anything: - virtualshelves/shelves.tt, opac-user.tt (checkouts/overdues), and opac-readingrecord.tt each rendered a bare <td> for the plugin-only case, with no id/class/data attribute a plugin's JS could use to find the row. Koha already has an established contract for this -- a ".cover-slider"/".cover-slides" container carrying data-biblionumber, used by cover-images.inc (OPAC lists/results) and catalogue/results.tt (staff search results) -- that this patchset never reused. Confirmed with the BDS Covers plugin installed: the "Cover" column/header appeared and the plugin's <script> was present in the page, but the cell stayed empty because there was nothing for the script to target. - shelfbrowser.inc had a second, unrelated regression: a static <img> was added inside the local-cover div, which used to be populated purely by KOHA.LocalCover.GetCoverFromBibnumber(). That JS reads the div's whole class attribute as the biblionumber, so once the div was no longer empty it fired a second, malformed request per item (.../opac-image.pl?biblionumber=73 thumbnail-shelfbrowser) and left a broken image and a "No cover image available" message shown at the same time. Confirmed via network capture while paging through the shelf browser with OPACLocalCoverImages and the plugin both enabled. - svc/shelfbrowser.tt printed the plugin's script without the `| $raw` filter Koha's QA tooling requires (koha-qa.pl: filters/missing_filter). - shelves.tt referenced an img_title variable that nothing in the file ever set, so the tooltip on the local cover thumbnail was always empty (a leftover from copying shelfbrowser.inc's pattern without its earlier `[% img_title = ... %]` assignment). This patch: - Wraps the plugin/Local/Custom cover markup in virtualshelves/shelves.tt in a `.cover-slider.cover-slides[data-biblionumber]` container, matching catalogue/results.tt's existing intranet pattern. - Wraps the Amazon/Google/Custom/Syndetics cover markup in opac-user.tt (checkouts and overdues) and opac-readingrecord.tt in the same `.cover-slider.cover-slides[data-biblionumber]` container OPAC pages already use via cover-images.inc, without changing any of the existing per-source behaviour. - Reverts the static <img> added to shelfbrowser.inc's local-cover div, restoring the original JS-driven rendering (the plugin case there already works via the pre-existing .shelfbrowser_cover anchor, so no further change was needed for that element). - Adds the missing `| $raw` filter in svc/shelfbrowser.tt. - Removes the dangling img_title reference in shelves.tt (the markup it was on has been replaced by the cover-images.inc-style pattern above). Test plan: 1. Enable plugins (<enable_plugins> in koha-conf.xml) and install/enable a cover-image plugin implementing intranet_cover_images and/or opac_cover_images (the community's koha-plugin-addBDSCovers is a convenient real one; see bug 32680 comment 2 for a copy). 2. With LocalCoverImages, CustomCoverImages and all other cover-image sources left at their default (off) and only the plugin enabled: a. Staff list view: add a title with an ISBN to a list and view it. The "Cover" column appears and the plugin's cover now renders inside it (verify via "View page source" / devtools if the plugin's image host isn't reachable from your test network). b. OPAC "Your summary" and "Your reading history": check out and/or return that title, then confirm the plugin's cover renders on both pages. c. OPAC shelf browser ("Browse shelf" from the detail page): confirm covers render, including after using the Previous/Next pagination inside the shelf browser widget. 3. Re-enable LocalCoverImages/CustomCoverImages (staff and OPAC) and confirm those still render exactly as before in all of the above (regression check) -- local and custom covers should appear alongside, not instead of, the plugin's. 4. Specifically for the shelf-browser regression: with OPACLocalCoverImages on and a title with a local cover image, open the shelf browser and click "Next"/"Previous" repeatedly. Confirm each item shows at most one image (no duplicate/broken image plus a simultaneous "No cover image available" message), and check the browser's network tab for no malformed opac-image.pl?biblionumber=<n>%20thumbnail-shelfbrowser requests. 5. koha-qa.pl -c 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #62 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- OK.. in my testing pretty much none of this worked.. so I added a large QA follow-up that basically reworks it entirely. Leaving at NSO.. I've re-written the commit message with decent test plans to help Esther -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #63 from Esther Melander <esther.melander@bywatersolutions.com> --- I tested using a sandbox, so there may be some anomalies because of it. 1. I enabled the plugin and could see cover images on the bibliographic detail view of the record from both Staff and OPAC. 2. Added items with an ISBN to a list. The cover images did not load and were not viewable in the list from the Staff side. However, I could see the cover images in a public list from the OPAC. 3. Checked out an item to a patron. The cover image did not load in the patron summary or reading history list, though the column was present and said "Image from BDS" 4. Enabled local cover images and uploaded a local cover image to a title. The local cover image appeared along side all of the examples except for the Staff list, which did not load any cover images. This is the html I saw for the shelf-browser, which I do not think was mal-formed as the images appeared in the OPAC. <div class="cover-image local-coverimg"> <a href="/cgi-bin/koha/opac-image.pl?imagenumber=1" title="Local cover image"> <img src="/cgi-bin/koha/opac-image.pl?thumbnail=1&imagenumber=1" alt="Local cover image" data-link="/cgi-bin/koha/opac-imageviewer.pl?biblionumber=343&imagenumber=1" /> </a> <div class="hint">Local cover image</div> </div> From what I can see, the only problems were the cover images (local and from BDS) not loading in the list from the Staff interface, patron summary, and reading history. This could be an anomaly due to using a sandbox. If I can test with my dev box, I will try, but other testers are welcome to step-in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 --- Comment #64 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Ooh, I wonder if BDS block non-UK fetching of images. They're a UK service, I bet that plays into this testing. I'll have a little hunt around, see if I can find a US provider plugin we can test against and also look into better handling such blocks in our UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36154 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43741 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43741 [Bug 43741] [Omnibus] Make Intranet header search customizable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org