[Bug 31624] New: REST API: Add endpoint for generated covers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31624 Bug ID: 31624 Summary: REST API: Add endpoint for generated covers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: paul.derscheid@lmscloud.de QA Contact: testopia@bugs.koha-community.org This endpoint returns base64 encoded images that are generated based on url parameters you can supply (currently title, author). It's part of my attempt to get the current shelfbrowser replaced (https://wiki.koha-community.org/wiki/User:Paulderscheid ; This will be updated shortly, but I'm still on vacation). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31624 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |paul.derscheid@lmscloud.de CC| |tomascohen@gmail.com Component|OPAC |REST API Status|NEW |ASSIGNED QA Contact|testopia@bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31624 --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 144726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144726&action=edit Bug 31624: REST API: Add endpoint for generated covers This commit contains the main changes for the endpoint and the controller for the image generation. To test this, if you don't have a very elaborate setup: 1. Apply the patch 2. Request the endpoint, for example using: http://localhost:8080/api/v1/public/biblios/1/default_cover 3. Now you could use this JS in your console to get an unescaped version of the JSON response const response = await fetch('http://localhost:8080/api/v1/public/biblios/1/default_cover'); const result = await response.json(); console.log(result); 4. Copy the response and check whether it actually is a valid base64 encoded image. For example using this tool: https://base64.guru/converter/decode/file 5. Give me your thoughts on this patch I'm still in the process of using unit tests and hunting bugs, so it's now ready for a sign-off but I thought I'd already show it to whoever is interested. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31624 --- Comment #2 from Paul Derscheid <paul.derscheid@lmscloud.de> --- The preliminary test plan assumes ktd, btw. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31624 --- Comment #3 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I made some typos. The patch is not ready for a sign-off (not 'now' ready). And of course I'm in the process of writing unit tests, not using them. 😬 See #c1 for reference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31624 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org