[Bug 8497] New: Strange behavior when modifying the 'timeout' system preference.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8497 Priority: P5 - low Change sponsored?: --- Bug ID: 8497 CC: gmcharlt@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Strange behavior when modifying the 'timeout' system preference. Severity: enhancement Classification: Unclassified OS: All Reporter: kyle@bywatersolutions.com Hardware: All Status: NEW Version: master Component: System Administration Product: Koha The timeout system preference works fine, until I try to define the timeout in days ( e.g. '1d', or '3d' ). Once I have done so, I cannot change it to anything else. I get an error message from the pref system that says I'm logged out and need to log back in. If I click a link, I'm brought to the login page. If I log back in and try to modify the preference, I will get another 'not logged in' message and will start the loop all over again. If I edit the db row directly and change the value back to an integer, everything goes back to normal. I can modify the pref as much as I want, as long as it is an integer. As soon as I use the 'd' option, everything goes haywire again. I noticed in the database, 'timeout' is set to 'Integer'. I tried changing it to 'free' but that did not make a difference. If I dump the value of $timeout in C4::Auth::checkauth, it appears to be correct, even when using the 'd' option, but I end up logged out every time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8497 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8497 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 12629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12629&action=edit Proposed patch The use of 1d (=one day) in "timeout" syspref was only checked in normal authentication (Auth.pm checkauth), it was missing in check_api_auth() and check_cookie_auth(). I add a private method in Auth.pm : _timeout_syspref(). Test plan : - Set timeout syspref to 1d - Login in intranet (uses checkauth) - In header, use borrower auto-completion in "check out" (uses check_cookie_auth) - Go to Administration/System preferences, modify a syspref and save (check_api_auth) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8497 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5998 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8497 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8497 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8497 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12629|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12645&action=edit [SIGNED-OFF] Bug 8497: Strange behavior when modifying the timeout system preference Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested standard login, patron auto-complete, and system preferences. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8497 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #3 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #2)
Created attachment 12645 [details] [SIGNED-OFF] Bug 8497: Strange behavior when modifying the timeout system preference
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Tested standard login, patron auto-complete, and system preferences.
passing QA, works as expected $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit 0a35b26) * dec46ae Bug 8497: Strange behavior when modifying the timeout system preference C4/Auth.pm * C4/Auth.pm OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8497 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8497 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org