[Bug 7552] New: Remove wrong line endings in NORMARC record.abs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7552 Bug #: 7552 Summary: Remove wrong line endings in NORMARC record.abs Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support AssignedTo: magnus@enger.priv.no ReportedBy: magnus@enger.priv.no QAContact: koha.sekjal@gmail.com Blocks: 7537 As can be seen here, record.abs for NORMARC contains wrong line-endings: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=etc/zebradb/marc_d... This does not seem to have affected the indexing, since several libraries have been using this file in production for years. But it seems to be causing problems for the fix to bug 7537, so I better fix it! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7552 --- Comment #1 from Magnus Enger <magnus@enger.priv.no> 2012-02-17 14:10:49 UTC --- Created attachment 7711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7711 Bug 7552 - Remove wrong line endings in NORMARC record.abs Line endings contain erroneous \r 's. Also remove a useless comment at the top of the file. This patch was produced by doing the following operations: git config --global core.autocrlf true git rm --cached -r etc/zebradb/marc_defs/normarc/biblios/record.abs git diff --cached --name-only -z | xargs -0 git add as recommended here: http://help.github.com/line-endings/ To test: - Open etc/zebradb/marc_defs/normarc/biblios/record.abs in a file editor that will let you search for \r - gedit seems to work nicely for this. Check that there are occurences of \r in the file - Apply the patch - Open etc/zebradb/marc_defs/normarc/biblios/record.abs in the editor and check that it can not find any \r -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7552 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7552 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7711|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@enger.priv.no> 2012-02-17 14:28:21 UTC --- Created attachment 7712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7712 Bug 7552 - Remove wrong line endings in NORMARC record.abs Line endings contain erroneous \r 's. Also remove a useless comment at the top of the file. This patch was produced by doing the following operations: git config --global core.autocrlf true git rm --cached -r etc/zebradb/marc_defs/normarc/biblios/record.abs git diff --cached --name-only -z | xargs -0 git add as recommended here: http://help.github.com/line-endings/ First version of this file resulted in whitespaceerrors. Trying to fix that now. To test: - Open etc/zebradb/marc_defs/normarc/biblios/record.abs in a file editor that will let you search for \r - gedit seems to work nicely for this. Check that there are occurences of \r in the file - Apply the patch - Open etc/zebradb/marc_defs/normarc/biblios/record.abs in the editor and check that it can not find any \r -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7552 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7712|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2012-02-19 07:03:56 UTC --- Created attachment 7753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7753 Bug 7552 - Remove wrong line endings in NORMARC record.abs Line endings contain erroneous \r 's. Also remove a useless comment at the top of the file. This patch was produced by doing the following operations: git config --global core.autocrlf true git rm --cached -r etc/zebradb/marc_defs/normarc/biblios/record.abs git diff --cached --name-only -z | xargs -0 git add as recommended here: http://help.github.com/line-endings/ First version of this file resulted in whitespaceerrors. Trying to fix that now. To test: - Open etc/zebradb/marc_defs/normarc/biblios/record.abs in a file editor that will let you search for \r - gedit seems to work nicely for this. Check that there are occurences of \r in the file - Apply the patch - Open etc/zebradb/marc_defs/normarc/biblios/record.abs in the editor and check that it can not find any \r Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Still a few \r But only on comments, safe to push -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7552 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7552 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-21 16:37:20 UTC --- QA comment: none, magnus will endorse responsibility for any mistake ;-) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7552 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7552 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #5 from Magnus Enger <magnus@enger.priv.no> --- Looks good in current master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org