[Bug 17443] New: Make possible to renew patron by later of expiry and current date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17443 Bug ID: 17443 Summary: Make possible to renew patron by later of expiry and current date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In our we need to base patron's new expiry date on the later of expiry and current date. To be more clear: if patron registration expires in the past, use current date, if patron registration expires in the future, use expiry date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17443 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | CC| |black23@gmail.com, | |rbit@rbit.cz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17443 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17443 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56443&action=edit Bug 17443: Make possible to renew patron by later of expiry and current date Test plan 1) Apply the patch 2) Go to system preferences and find the BorrowerRenewalPeriodBase and note there is new option "the later of current and expiry date" 3) Try all three options and confirm they work as expected 3.1) The new options should be tested et least with two patrons - one with expiry date in past and one with expiry date in future -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17443 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56443|0 |1 is obsolete| | --- Comment #2 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 56457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56457&action=edit Bug 17443: Make possible to renew patron by later of expiry and current date Test plan 1) Apply the patch 2) Go to system preferences and find the BorrowerRenewalPeriodBase and note there is new option "the later of current and expiry date" 3) Try all three options and confirm they work as expected 3.1) The new options should be tested et least with two patrons - one with expiry date in past and one with expiry date in future Signed-off-by: radiuscz <radek.siman@centrum.cz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17443 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17443 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please provide tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17443 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17443 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17443 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56845&action=edit Bug 17443: Added tests Test plan: prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17443 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17443 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56457|0 |1 is obsolete| | Attachment #56845|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56849&action=edit Bug 17443: Make possible to renew patron by later of expiry and current date Test plan 1) Apply the patch 2) Go to system preferences and find the BorrowerRenewalPeriodBase and note there is new option "the later of current and expiry date" 3) Try all three options and confirm they work as expected 3.1) The new options should be tested et least with two patrons - one with expiry date in past and one with expiry date in future Signed-off-by: radiuscz <radek.siman@centrum.cz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17443 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56850&action=edit Bug 17443: Added tests Test plan: prove t/db_dependent/Koha/Patrons.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17443 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17443 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Josef! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17443 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.06. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org