[Bug 24404] New: Add missing space on invoices page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 Bug ID: 24404 Summary: Add missing space on invoices page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: katrin.fischer@bsz-bw.de Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org There is a space missing after "Adjustments plus shipping:" showing the amount directly after the text. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97263&action=edit Bug 24404: Add missing space on invoices page / remove . from status On the bottom of the invoices page the summary of adjustments and shipping shows as: Adjustments plus shipping:2.00 The patch adds the missing space between text and amount. To test: - 'Receive shipment' from a result in your vendor search - Start a new invoice by entering an invoice number, amount for shipping cost and fund. - Finish receive (you don't need to receive anything) - You should now be on invoice.pl - Verify Status is 'Open.' and in 'Invoice details' we have the amount with the missing space. - Apply patch, reload the page. - Verify the missing space is there and the . is gone. - Close invoice, no . there either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97263|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 97348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97348&action=edit Bug 24404: Add missing space on invoices page / remove . from status On the bottom of the invoices page the summary of adjustments and shipping shows as: Adjustments plus shipping:2.00 The patch adds the missing space between text and amount. To test: - 'Receive shipment' from a result in your vendor search - Start a new invoice by entering an invoice number, amount for shipping cost and fund. - Finish receive (you don't need to receive anything) - You should now be on invoice.pl - Verify Status is 'Open.' and in 'Invoice details' we have the amount with the missing space. - Apply patch, reload the page. - Verify the missing space is there and the . is gone. - Close invoice, no . there either. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97348|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 97478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97478&action=edit Bug 24404: Add missing space on invoices page / remove . from status On the bottom of the invoices page the summary of adjustments and shipping shows as: Adjustments plus shipping:2.00 The patch adds the missing space between text and amount. To test: - 'Receive shipment' from a result in your vendor search - Start a new invoice by entering an invoice number, amount for shipping cost and fund. - Finish receive (you don't need to receive anything) - You should now be on invoice.pl - Verify Status is 'Open.' and in 'Invoice details' we have the amount with the missing space. - Apply patch, reload the page. - Verify the missing space is there and the . is gone. - Close invoice, no . there either. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #7 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Hayley Mapley from comment #7)
Enhancement will not be backported to 18.11.x series.
Really just a typo fix (adds one space) - but causes a string change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 --- Comment #9 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Yeah, I should have specified because of string change sorry! It's on my list for review for next minor point release :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Hayley! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org