[Bug 17579] New: Add the Koha::Patron->is_expired method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Bug ID: 17579 Summary: Add the Koha::Patron->is_expired method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17578 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 [Bug 17578] Replace GetMemberDetails with GetMember -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57297&action=edit Bug 17579: Add the Koha::Patron->is_expired This new method will be handy for further uses Test plan: prove t/db_dependent/Koha/Patrons.t should return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57297|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57320&action=edit [SIGNED-OFF] Bug 17579: Add the Koha::Patron->is_expired This new method will be handy for further uses Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17583 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 [Bug 17583] Use Koha::Patron->is_expired from circulation.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57332&action=edit Bug 17579: Add the Koha::Patron->is_expired This new method will be handy for further uses Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17580 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 [Bug 17580] Add the Koha::Patron->get_overdues method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Attachment #57320|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57386&action=edit Bug 17579: Make sure we are testing the real life Without this patch, the tests are not testing the same things as what happens on the interface. We need to refresh the object to make sure the date set into dateexpiry is the one in DB. Without this patch, ->is_expired test a datetime object, with this patch it compares with a date oject Without the changes made in Koha::Patron->is_expired, a patron which has a dateexpiry set to today was marked as expired on the interface. This is a change in the behavior, what this refactoring does not want to do. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17594 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17594 [Bug 17594] Make Koha::Object->discard_changes available -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17522 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17522 [Bug 17522] opac-user.pl gives error of OpacRenewalAllowed is enabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57332|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57411&action=edit Bug 17579: Add the Koha::Patron->is_expired This new method will be handy for further uses Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57386|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57412&action=edit Bug 17579: Make sure we are testing the real life Without this patch, the tests are not testing the same things as what happens on the interface. We need to refresh the object to make sure the date set into dateexpiry is the one in DB. Without this patch, ->is_expired test a datetime object, with this patch it compares with a date oject Without the changes made in Koha::Patron->is_expired, a patron which has a dateexpiry set to today was marked as expired on the interface. This is a change in the behavior, what this refactoring does not want to do. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17580 | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have removed the dependency on bug 17580 to make these patches reusable by other patches. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 [Bug 17580] Add the Koha::Patron->get_overdues method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57411|0 |1 is obsolete| | Attachment #57412|0 |1 is obsolete| | --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57475&action=edit [SIGNED-OFF] Bug 17579: Add the Koha::Patron->is_expired This new method will be handy for further uses Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57476&action=edit [SIGNED-OFF] Bug 17579: Make sure we are testing the real life Without this patch, the tests are not testing the same things as what happens on the interface. We need to refresh the object to make sure the date set into dateexpiry is the one in DB. Without this patch, ->is_expired test a datetime object, with this patch it compares with a date oject Without the changes made in Koha::Patron->is_expired, a patron which has a dateexpiry set to today was marked as expired on the interface. This is a change in the behavior, what this refactoring does not want to do. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57475|0 |1 is obsolete| | Attachment #57476|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57498&action=edit Bug 17579: Add the Koha::Patron->is_expired This new method will be handy for further uses Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57499&action=edit Bug 17579: Make sure we are testing the real life Without this patch, the tests are not testing the same things as what happens on the interface. We need to refresh the object to make sure the date set into dateexpiry is the one in DB. Without this patch, ->is_expired test a datetime object, with this patch it compares with a date oject Without the changes made in Koha::Patron->is_expired, a patron which has a dateexpiry set to today was marked as expired on the interface. This is a change in the behavior, what this refactoring does not want to do. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57500&action=edit Bug 17579 [QA Followup] - Fix the number of tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org