[Bug 19365] New: link_bibs_to_authorities.pl doesn' t work with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Bug ID: 19365 Summary: link_bibs_to_authorities.pl doesn't work with Elasticsearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: Linux Status: NEW Severity: blocker Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: frank.hansen@ub.lu.se We need to run the script on daily basis to link bibliographic records to matching authority records. We know this worked with Zebra. But with Elasticsearch it don't. Our current system preference settings is the following: AutoCreateAuthorites: no. BiblioAddsAuthorities: no. UseAuthoritiesForTracing: yes. CatalogModuleRelink: yes. LinkerKeepStale: yes. LinkerModule: Default. LinkerOptions: broader_headings LinkerRelink: yes In the future we want to AutoCreateAuthorites when matching authority headings does not exist. The link_bibs_to_authorities.pl runs normally with no errors but no bibliographic records are linked to matching authority records. Here is tha last reports: Bib authority heading linking report ======================================================= Linker module: C4::Linker::Default Run started at: 09/24/17 06:25:04 Run ended at: 09/25/17 07:53:13 Total run time: 91688923 ms Number of bibs checked: 654037 Number of bibs modified: 0 Number of bibs with errors: 0 Number of headings linked: 0 Number of headings unlinked: 178717 Number of headings fuzzily linked: 1598619 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |major CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |nick@bywatersolutions.com --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is not blocker, ES is not considered as stable yet. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala@helsinki.fi Assignee|koha-bugs@lists.koha-commun |ere.maijala@helsinki.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18825 [Bug 18825] Elasticsearch - Update default authority mappings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #2 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 71109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71109&action=edit Bug 19365 - link_bibs_to_authorities.pl doesn't work with Elasticsearch Fix several issues with the Elasticsearch code and optimize it to be usable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Ere Maijala <ere.maijala@helsinki.fi> --- Attached patch provides a slew of fixes and optimizations to the Elasticsearch code and related linking functionality. The optimizations are crucial for a usable process. On my development machine I could only achieve speed of about 1 record per second before the changes. After that it can handle 10-20 modified records and 100 checked records per second. Additionally, avoiding creating a new indexer or searcher every time it's used avoids crashing after a few thousand records due to file handles being exhausted in the Catmandu or Elasticsearch modules. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71109|0 |1 is obsolete| | --- Comment #4 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 71114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71114&action=edit Bug 19365 - link_bibs_to_authorities.pl doesn't work with Elasticsearch Fix the copyrightdate cast when it's empty. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71109|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Ere, this patch looks good at a first read through, can you provide a test plan for the linker? I am not so familiar with this tool. I un-obsoleted the first patch, squashing the followup would be good too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #6 from Ere Maijala <ere.maijala@helsinki.fi> --- I have biblios and authorities imported from another ILS so it's a perfect place to test the linking, but it's difficult without proper authority records. To test it properly you need biblio and authority data. You might get away with enabling AutoCreateAuthorities and BiblioAddsAuthorities so that authorities are created in the process. Then run "link_bibs_to_authorities.pl -v -l" twice and observe the results. Another option would be to import authorities first e.g. from LoC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |brendan@bywatersolutions.co | |m --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- I was able to run my linker with zebra enabled (check) Switched to Elastic Search in system preferences. Applied this patch. Confirmed that I can search in Elastic search. Run link_bibs_to_authorities.pl -v -l - failed on first record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #8 from Ere Maijala <ere.maijala@helsinki.fi> --- How did it fail? Did you rebuild the authority index too? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #9 from Brendan Gallagher <brendan@bywatersolutions.com> --- Yes - reindex auths and the linker failed on the first one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #10 from Ere Maijala <ere.maijala@helsinki.fi> --- What's the error? Or did it just not find a match? Did you notice this depends on bug 18825? Without proper mappings it's not going to work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #11 from Brendan Gallagher <brendan@bywatersolutions.com> --- yes followed all the way through dependencies :) here is the error Can't locate object method "field" via package "<?xml version="1.0" encoding="UTF-8"?> <record xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.loc.gov/MARC21/slim" xsi:schemaLocation="http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd"> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #12 from Ere Maijala <ere.maijala@helsinki.fi> --- I'm unable to reproduce, but it might be something specific to settings and my environment. Can you find the file and line where the error happens? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71109|0 |1 is obsolete| | Attachment #71114|0 |1 is obsolete| | --- Comment #13 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 73382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73382&action=edit Bug 19365 - link_bibs_to_authorities.pl doesn't work with Elasticsearch Fix several issues with the Elasticsearch code and optimize it to be usable. Test plan: 1. To test it properly you need biblio and authority data. You might get away with enabling AutoCreateAuthorities and BiblioAddsAuthorities so that authorities are created in the process. Another option would be to import authorities first e.g. from LoC. 2. Make sure the authority index has been properly created with "misc/search_tools/rebuild_elastic_search.pl -a -d" 3. Run "misc/link_bibs_to_authorities.pl -v -l" twice and observe the results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #14 from Ere Maijala <ere.maijala@helsinki.fi> --- I rebased the patch on current master. Still couldn't get it to fail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- It looks like you are touching some of the same code adjusted in bug 19604 - can you take a look there and make any comments and then rebase this on top of that bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #16 from Ere Maijala <ere.maijala@helsinki.fi> --- Oh, thanks for pointing that one out. I think I'll wait to get some of the fixes into master, this is getting a bit too complicated otherwise! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20664 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20244 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Bug 19365 depends on bug 18825, which changed state. Bug 18825 Summary: Elasticsearch - Update default authority mappings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18825 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- This one is cleared to move ahead, any chance of a rebase Ere? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #18 from Ere Maijala <ere.maijala@helsinki.fi> --- Yes, I'll see what I can do. I'll probably have to rework this significantly to base this on bug 19893. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 [Bug 19893] Alternative optimized indexing for Elasticsearch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73382|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #19 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 78732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78732&action=edit Bug 19365: Fix several issues with the Elasticsearch code Also optimize it so it's actually usable. Test plan: 1. To test it properly you need biblio and authority data. You might get away with enabling AutoCreateAuthorities and BiblioAddsAuthorities so that authorities are created in the process. Another option would be to import authorities first e.g. from LoC. 2. Make sure the authority index has been properly created with "misc/search_tools/rebuild_elastic_search.pl -a -d" 3. Run "misc/link_bibs_to_authorities.pl -v -l" twice and observe the results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78732|0 |1 is obsolete| | --- Comment #20 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 78737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78737&action=edit Bug 19365: Fix several issues with the Elasticsearch code Also optimize it so it's actually usable. Test plan: 1. To test it properly you need biblio and authority data. You might get away with enabling AutoCreateAuthorities and BiblioAddsAuthorities so that authorities are created in the process. Another option would be to import authorities first e.g. from LoC. 2. Make sure the authority index has been properly created with "misc/search_tools/rebuild_elastic_search.pl -a -d" 3. Run "misc/link_bibs_to_authorities.pl -v -l" twice and observe the results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #21 from Brendan Gallagher <brendan@bywatersolutions.com> --- Talked in person with Ere about the error we found. trying Z3950 searches failed with something in this patch or with the Depends On -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78737|0 |1 is obsolete| | --- Comment #22 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 78875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78875&action=edit Bug 19365: Fix several issues with the Elasticsearch code Also optimize it so it's actually usable. Test plan: 1. To test it properly you need biblio and authority data. You might get away with enabling AutoCreateAuthorities and BiblioAddsAuthorities so that authorities are created in the process. Another option would be to import authorities first e.g. from LoC. 2. Make sure the authority index has been properly created with "misc/search_tools/rebuild_elastic_search.pl -a -d" 3. Run "misc/link_bibs_to_authorities.pl -v -l" twice and observe the results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #23 from Ere Maijala <ere.maijala@helsinki.fi> --- I fixed one issue, but I'm not sure if it's related to the Z39.50 problem because I couldn't reproduce it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #24 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 79005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79005&action=edit Bug 19365: Fix search for duplicate authorities with Elasticsearch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78875|0 |1 is obsolete| | --- Comment #25 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 79006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79006&action=edit Bug 19365: Fix several issues with the Elasticsearch code Also optimize it so it's actually usable. Test plan: 1. To test it properly you need biblio and authority data. You might get away with enabling AutoCreateAuthorities and BiblioAddsAuthorities so that authorities are created in the process. Another option would be to import authorities first e.g. from LoC. 2. Make sure the authority index has been properly created with "misc/search_tools/rebuild_elastic_search.pl -a -d" 3. Run "misc/link_bibs_to_authorities.pl -v -l" twice and observe the results. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79005|0 |1 is obsolete| | --- Comment #26 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 79007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79007&action=edit Bug 19365: Fix search for duplicate authorities with Elasticsearch Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21405 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es --- Comment #27 from Hugo Agud <hagud@orex.es> --- I am not pretty sure if this comment should be here or if it should be a new bug, however link_bibs_to_authorities.pl is working fine, but with new RDA rules, it has one inconvenience. At PERSONAL_NAMES now there is 100$e - Relator term (R) some libraries have one authoriry for each relator code, like author, translator, editor...etc link_bibs_ is not looking at $e and matchs all occurrences with the first or last match created and it creates the propertly authority for each $e, but it links wrong example --> Authority search results Results 1 to 6 of 6 Summary Used in Nombre personal: Abadal i de Vinyals, Ramon d' , 1888-1970 Details 40 record(s) Nombre personal: Abadal i de Vinyals, Ramon d' , 1888-1970 , ed. Details 0 records Nombre personal: Abadal i de Vinyals, Ramon d' , 1888-1970 , pr. Details 0 records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Hugo Agud from comment #27)
I am not pretty sure if this comment should be here or if it should be a new bug, however link_bibs_to_authorities.pl is working fine, but with new RDA rules, it has one inconvenience.
At PERSONAL_NAMES now there is 100$e - Relator term (R) some libraries have one authoriry for each relator code, like author, translator, editor...etc
link_bibs_ is not looking at $e and matchs all occurrences with the first or last match created and it creates the propertly authority for each $e, but it links wrong
example --> Authority search results Results 1 to 6 of 6
Summary Used in Nombre personal: Abadal i de Vinyals, Ramon d' , 1888-1970 Details 40 record(s) Nombre personal: Abadal i de Vinyals, Ramon d' , 1888-1970 , ed. Details 0 records Nombre personal: Abadal i de Vinyals, Ramon d' , 1888-1970 , pr. Details 0 records
I think this should be a separate bug and a separate discussion. We'd certainly not want $e to be taken into account. If it's the same person, should there not only be one authority record? I think someone acting as author and editor would be a common case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #29 from Ere Maijala <ere.maijala@helsinki.fi> --- I agree with Katrin, and we relly need to get all the fixes in and assess the situation once more after that. There are currently some many improvements waiting to make it that it's not worth it to try to manage the dependencies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Signed Off |Patch doesn't apply --- Comment #30 from Chris Cormack <chris@bigballofwax.co.nz> --- Could you do a rebase please, there we a few too many conflicts for me to fix without breaking things accidentally -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |BLOCKED --- Comment #31 from Ere Maijala <ere.maijala@helsinki.fi> --- The patch applies cleanly for me, but it requires bug 19893 to be applied first. For some reason git-bz didn't offer to follow there even though it's set as dependency. Anyway, marking BLOCKED until 19893 is done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79006|0 |1 is obsolete| | --- Comment #32 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 82282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82282&action=edit Bug 19365: Fix several issues with the Elasticsearch code Also optimize it so it's actually usable. Test plan: 1. To test it properly you need biblio and authority data. You might get away with enabling AutoCreateAuthorities and BiblioAddsAuthorities so that authorities are created in the process. Another option would be to import authorities first e.g. from LoC. 2. Make sure the authority index has been properly created with "misc/search_tools/rebuild_elastic_search.pl -a -d" 3. Run "misc/link_bibs_to_authorities.pl -v -l" twice and observe the results. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79007|0 |1 is obsolete| | --- Comment #33 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 82283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82283&action=edit Bug 19365: Fix search for duplicate authorities with Elasticsearch Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #34 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 82284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82284&action=edit Bug 19365: Index authority fields as phrases Followup change to the mappings syntax from bug 19893. Indexing as phrases allows to properly search for matching headings comprised of multiple subfields (e.g. author name with year of birth). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82282|0 |1 is obsolete| | --- Comment #35 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 82303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82303&action=edit Bug 19365: Fix several issues with the Elasticsearch code Also optimize it so it's actually usable. Test plan: 1. To test it properly you need biblio and authority data. You might get away with enabling AutoCreateAuthorities and BiblioAddsAuthorities so that authorities are created in the process. Another option would be to import authorities first e.g. from LoC. 2. Make sure the authority index has been properly created with "misc/search_tools/rebuild_elastic_search.pl -a -d" 3. Run "misc/link_bibs_to_authorities.pl -v -l" twice and observe the results. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82283|0 |1 is obsolete| | --- Comment #36 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 82304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82304&action=edit Bug 19365: Fix search for duplicate authorities with Elasticsearch Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82284|0 |1 is obsolete| | --- Comment #37 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 82305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82305&action=edit Bug 19365: Index authority fields as phrases Followup change to the mappings syntax from bug 19893. Indexing as phrases allows to properly search for matching headings comprised of multiple subfields (e.g. author name with year of birth). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82307&action=edit Bug 19365: (QA follow-up) Add UNIMARC support Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82303|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82312&action=edit Bug 19365: Fix several issues with the Elasticsearch code Also optimize it so it's actually usable. Test plan: 1. To test it properly you need biblio and authority data. You might get away with enabling AutoCreateAuthorities and BiblioAddsAuthorities so that authorities are created in the process. Another option would be to import authorities first e.g. from LoC. 2. Make sure the authority index has been properly created with "misc/search_tools/rebuild_elastic_search.pl -a -d" 3. Run "misc/link_bibs_to_authorities.pl -v -l" twice and observe the results. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82304|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82313&action=edit Bug 19365: Fix search for duplicate authorities with Elasticsearch Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82305|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82314&action=edit Bug 19365: Index authority fields as phrases Followup change to the mappings syntax from bug 19893. Indexing as phrases allows to properly search for matching headings comprised of multiple subfields (e.g. author name with year of birth). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #82307|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21826 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826 [Bug 21826] Automatic authority record generation improvements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We've fallen at the last hurdle here I'm afraid.. we need some updated/additional unit tests to cover the changes.. at a minimum Koha:: namespace changes, but I'd really love to see some minimal coverage of C4::Biblio added for the affected method too... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82312|0 |1 is obsolete| | --- Comment #43 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 82325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82325&action=edit Bug 19365: Fix several issues with the Elasticsearch code Also optimize it so it's actually usable. Test plan: 1. To test it properly you need biblio and authority data. You might get away with enabling AutoCreateAuthorities and BiblioAddsAuthorities so that authorities are created in the process. Another option would be to import authorities first e.g. from LoC. 2. Make sure the authority index has been properly created with "misc/search_tools/rebuild_elastic_search.pl -a -d" 3. Run "misc/link_bibs_to_authorities.pl -v -l" twice and observe the results. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82313|0 |1 is obsolete| | --- Comment #44 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 82326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82326&action=edit Bug 19365: Fix search for duplicate authorities with Elasticsearch Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82314|0 |1 is obsolete| | --- Comment #45 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 82327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82327&action=edit Bug 19365: Index authority fields as phrases Followup change to the mappings syntax from bug 19893. Indexing as phrases allows to properly search for matching headings comprised of multiple subfields (e.g. author name with year of birth). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #46 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 82328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82328&action=edit Bug 19365: Clean up, fix and add new tests. Moved db_dependent tests to the proper directory in the hierarchy, fixed tests to check correct results now that the authority query builder works better and added several new tests to cover changed functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21826 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82325|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82406&action=edit Bug 19365: Fix several issues with the Elasticsearch code Also optimize it so it's actually usable. Test plan: 1. To test it properly you need biblio and authority data. You might get away with enabling AutoCreateAuthorities and BiblioAddsAuthorities so that authorities are created in the process. Another option would be to import authorities first e.g. from LoC. 2. Make sure the authority index has been properly created with "misc/search_tools/rebuild_elastic_search.pl -a -d" 3. Run "misc/link_bibs_to_authorities.pl -v -l" twice and observe the results. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82326|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82407&action=edit Bug 19365: Fix search for duplicate authorities with Elasticsearch Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82327|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82408&action=edit Bug 19365: Index authority fields as phrases Followup change to the mappings syntax from bug 19893. Indexing as phrases allows to properly search for matching headings comprised of multiple subfields (e.g. author name with year of birth). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82328|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82409&action=edit Bug 19365: Clean up, fix and add new tests. Moved db_dependent tests to the proper directory in the hierarchy, fixed tests to check correct results now that the authority query builder works better and added several new tests to cover changed functionality. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82406|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82410&action=edit Bug 19365: Fix several issues with the Elasticsearch code Also optimize it so it's actually usable. Test plan: 1. To test it properly you need biblio and authority data. You might get away with enabling AutoCreateAuthorities and BiblioAddsAuthorities so that authorities are created in the process. Another option would be to import authorities first e.g. from LoC. 2. Make sure the authority index has been properly created with "misc/search_tools/rebuild_elastic_search.pl -a -d" 3. Run "misc/link_bibs_to_authorities.pl -v -l" twice and observe the results. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82407|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82411&action=edit Bug 19365: Fix search for duplicate authorities with Elasticsearch Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82408|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82412&action=edit Bug 19365: Index authority fields as phrases Followup change to the mappings syntax from bug 19893. Indexing as phrases allows to properly search for matching headings comprised of multiple subfields (e.g. author name with year of birth). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82409|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82413&action=edit Bug 19365: Clean up, fix and add new tests. Moved db_dependent tests to the proper directory in the hierarchy, fixed tests to check correct results now that the authority query builder works better and added several new tests to cover changed functionality. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82414&action=edit Bug 19365: (QA follow-up) Ensure we use a modern enough perl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Tests all pass, QA script is now happy and I can't find any regressions. It took a bit of digging through to check we hadn't inadvertently lost ny tests, but the cleanup was worthwhile. Had to add a minor followup to declare perl `use 5.010` to ensure the 'state' variables are available for compile and squash a qa script warning. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82410|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82530&action=edit Bug 19365: Fix several issues with the Elasticsearch code Also optimize it so it's actually usable. Test plan: 1. To test it properly you need biblio and authority data. You might get away with enabling AutoCreateAuthorities and BiblioAddsAuthorities so that authorities are created in the process. Another option would be to import authorities first e.g. from LoC. 2. Make sure the authority index has been properly created with "misc/search_tools/rebuild_elastic_search.pl -a -d" 3. Run "misc/link_bibs_to_authorities.pl -v -l" twice and observe the results. Sponsored-by: National Library of Finland Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82411|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82531&action=edit Bug 19365: Fix search for duplicate authorities with Elasticsearch Sponsored-by: National Library of Finland Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82412|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82532&action=edit Bug 19365: Index authority fields as phrases Followup change to the mappings syntax from bug 19893. Indexing as phrases allows to properly search for matching headings comprised of multiple subfields (e.g. author name with year of birth). Sponsored-by: National Library of Finland Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82413|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82533&action=edit Bug 19365: Clean up, fix and add new tests. Moved db_dependent tests to the proper directory in the hierarchy, fixed tests to check correct results now that the authority query builder works better and added several new tests to cover changed functionality. Sponsored-by: National Library of Finland Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82414|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 82534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82534&action=edit Bug 19365: (QA follow-up) Ensure we use a modern enough perl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Bug 19365 depends on bug 19893, which changed state. Bug 19893 Summary: Alternative optimized indexing for Elasticsearch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21826 | --- Comment #62 from Ere Maijala <ere.maijala@helsinki.fi> --- I removed dependency on 21826 since it's not absolutely really required for the fixes here. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826 [Bug 21826] Automatic authority record generation improvements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #63 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19365 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #64 from Jesse Maseto <jesse@bywatersolutions.com> --- Will need patches rebase for 18.05, if needed for backporting to 18.05. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org