[Bug 29307] New: marc record fetched twice in detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 Bug ID: 29307 Summary: marc record fetched twice in detail.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org 86 my $record = GetMarcBiblio({ biblionumber => $biblionumber }); 87 my $biblio = Koha::Biblios->find( $biblionumber ); 88 $template->param( 'biblio', $biblio ); 89 90 if ( not defined $record ) { 91 # biblionumber invalid -> report and exit 92 $template->param( unknownbiblionumber => 1, 93 biblionumber => $biblionumber ); 94 output_html_with_http_headers $query, $cookie, $template->output; 95 exit; 96 } 97 98 eval { $biblio->metadata->record }; 99 $template->param( decoding_error => $@ ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126749&action=edit Bug 29307: Remove unecessary marc record fetch on detail.pl We were fetching the MARC::Record twice here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126749|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 126791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126791&action=edit Bug 29307: Remove unecessary marc record fetch on detail.pl We were fetching the MARC::Record twice here. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Tested by checking that the MARC detail pages in the staff interface work as expected after the patch is applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi --- Comment #4 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- They don't do quite the same thing, GetMarcBiblio calls C4::Biblio::_koha_marc_update_bib_ids() and $biblio->metadata->record doesn't. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Joonas Kylmälä from comment #4)
They don't do quite the same thing, GetMarcBiblio calls C4::Biblio::_koha_marc_update_bib_ids() and $biblio->metadata->record doesn't.
What differences do you expect? The point of those tests is to not explode later basically, so we must know if the record has a valid MARCXML stored in the biblio_metadata table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 --- Comment #6 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- (In reply to Jonathan Druart from comment #5)
(In reply to Joonas Kylmälä from comment #4)
They don't do quite the same thing, GetMarcBiblio calls C4::Biblio::_koha_marc_update_bib_ids() and $biblio->metadata->record doesn't.
What differences do you expect?
Commenting on this just based on the code I read: Before this patch the detail page included biblionumbers if they were not in the original data, after this patch it doesn't. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED Depends on| |29486 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Joonas Kylmälä from comment #6)
(In reply to Jonathan Druart from comment #5)
(In reply to Joonas Kylmälä from comment #4)
They don't do quite the same thing, GetMarcBiblio calls C4::Biblio::_koha_marc_update_bib_ids() and $biblio->metadata->record doesn't.
What differences do you expect?
Commenting on this just based on the code I read: Before this patch the detail page included biblionumbers if they were not in the original data, after this patch it doesn't.
Yes, I don't think this call in GetMarcBiblio is relevant, I opened bug 29486. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio (?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29697 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126791|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131864&action=edit Bug 29307: Remove unecessary marc record fetch on detail.pl We were fetching the MARC::Record twice here. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29307 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |RESOLVED --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Will be fixed by bug 29697. *** This bug has been marked as a duplicate of bug 29697 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org