[Bug 23949] New: koha-common.init missing actions for koha-z3950-responder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Bug ID: 23949 Summary: koha-common.init missing actions for koha-z3950-responder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org For consistency, it should be calling the script for --stop and --restart actions as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 94957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94957&action=edit Bug 23949: Add missing actions for koha-z3950-responder in koha-common.init This patch makes the init script deal with koha-z3950-responder in --stop and --restart actions. Currently, only --start calls the script. To test: - Enable the server: $ koha-z3950-responder --enable kohadev - Stop koha-common $ service koha-common stop => SUCCESS: No koha-z3950-responder running - Start koha-common $ service koha-common start => SUCCESS: It is loaded (even if failing because of config issues) - Stop koha-common $ service koha-common stop => FAIL: It is still running (no --stop issued) - Repeat for restart - Apply this patch - Redo => SUCCESS: Things behave as expected! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Depends on| |13937 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94957|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 95028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95028&action=edit Bug 23949: Add missing actions for koha-z3950-responder in koha-common.init This patch makes the init script deal with koha-z3950-responder in --stop and --restart actions. Currently, only --start calls the script. To test: - Enable the server: $ koha-z3950-responder --enable kohadev - Stop koha-common $ service koha-common stop => SUCCESS: No koha-z3950-responder running - Start koha-common $ service koha-common start => SUCCESS: It is loaded (even if failing because of config issues) - Stop koha-common $ service koha-common stop => FAIL: It is still running (no --stop issued) - Repeat for restart - Apply this patch - Redo => SUCCESS: Things behave as expected! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95068&action=edit Bug 23949: Update documentation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- vagrant@kohadevbox:misc4dev(master)$ sudo koha-z3950-responder --enable kohadev cp: cannot stat '/etc/koha/z3950/*': No such file or directory Where/How is this directory created? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #4)
vagrant@kohadevbox:misc4dev(master)$ sudo koha-z3950-responder --enable kohadev cp: cannot stat '/etc/koha/z3950/*': No such file or directory
Where/How is this directory created?
I think it is missing in cp_debian_files.pl or smth -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #5)
(In reply to Jonathan Druart from comment #4)
vagrant@kohadevbox:misc4dev(master)$ sudo koha-z3950-responder --enable kohadev cp: cannot stat '/etc/koha/z3950/*': No such file or directory
Where/How is this directory created?
I think it is missing in cp_debian_files.pl or smth
What about the debian package? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 95125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95125&action=edit Bug 23949: Add z3950 directory to koha-common.install Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95028|0 |1 is obsolete| | Attachment #95068|0 |1 is obsolete| | Attachment #95125|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95133&action=edit Bug 23949: Add missing actions for koha-z3950-responder in koha-common.init This patch makes the init script deal with koha-z3950-responder in --stop and --restart actions. Currently, only --start calls the script. To test: - Enable the server: $ koha-z3950-responder --enable kohadev - Stop koha-common $ service koha-common stop => SUCCESS: No koha-z3950-responder running - Start koha-common $ service koha-common start => SUCCESS: It is loaded (even if failing because of config issues) - Stop koha-common $ service koha-common stop => FAIL: It is still running (no --stop issued) - Repeat for restart - Apply this patch - Redo => SUCCESS: Things behave as expected! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95134&action=edit Bug 23949: Update documentation Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95135&action=edit Bug 23949: Add z3950 directory to koha-common.install Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95133|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 95180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95180&action=edit Bug 23949: Add missing actions for koha-z3950-responder in koha-common.init This patch makes the init script deal with koha-z3950-responder in --stop and --restart actions. Currently, only --start calls the script. To test: - Enable the server: $ koha-z3950-responder --enable kohadev - Stop koha-common $ service koha-common stop => SUCCESS: No koha-z3950-responder running - Start koha-common $ service koha-common start => SUCCESS: It is loaded (even if failing because of config issues) - Stop koha-common $ service koha-common stop => FAIL: It is still running (no --stop issued) - Repeat for restart - Apply this patch - Redo => SUCCESS: Things behave as expected! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95134|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 95181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95181&action=edit Bug 23949: Update documentation Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95135|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 95182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95182&action=edit Bug 23949: Add z3950 directory to koha-common.install Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch makes the release notes| |koha-common script deal | |with koha-z3950-responder | |in --stop and --restart | |actions. Before this only | |--start calls the script. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org