[Bug 18468] New: When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 Bug ID: 18468 Summary: When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Discounts are not stored in $orderinfo before passing to populate prices -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 62512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62512&action=edit Bug 18468 - When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices To test: 1 - Setup a vendor with a discount 2 - Stage a file 3 - Create a basket 4 - Order from staged file 5 - Add a price but no discount 6 - Save order 7 - Note ecost is not discounted 8 - Apply patch 9 - Repeate 2-6 10 - Note ecost is discounted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62512|0 |1 is obsolete| | --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 62578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62578&action=edit Bug 18468 - When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices To test: 1 - Setup a vendor with a discount 2 - Stage a file 3 - Create a basket 4 - Order from staged file 5 - Add a price but no discount 6 - Save order 7 - Note ecost is not discounted 8 - Apply patch 9 - Repeate 2-6 10 - Note ecost is discounted Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |15503 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 [Bug 15503] Grab Item Information from Order Files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62578|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62618&action=edit Bug 18468 - When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices To test: 1 - Setup a vendor with a discount 2 - Stage a file 3 - Create a basket 4 - Order from staged file 5 - Add a price but no discount 6 - Save order 7 - Note ecost is not discounted 8 - Apply patch 9 - Repeate 2-6 10 - Note ecost is discounted Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust@univ-lyo | |n2.fr --- Comment #5 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- Hello, I'm into testing Koha 16.11.06 and i noticed the same problem. Can this patch be backported to 16.11 or shall I open a new bug ? Thanx. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to jmbroust from comment #5)
Hello, I'm into testing Koha 16.11.06 and i noticed the same problem. Can this patch be backported to 16.11 or shall I open a new bug ? Thanx.
Ccing Katrin, Rmaint 16.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Dependency is not in 16.11.x. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just noticed the earlier comments - checking. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The patch from master doesn't apply cleanly on 16.11.x and I am not sure how to resolve the conflict. Can someone take a look and provide a patch for 16.11.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The conflict in acqui/addorderiso2709.pl is quite confusing, need some help to resolve that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This patch is a follow-up for bug 15503, that is not in 16.11.x What is raised on comment 5 must be reported on another bug report as it is certainly not fixed by this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19165 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org