https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29158 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Depends on| |22435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 [Bug 22435] Clarify account_offset types by converting them to clear codes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29158 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126818&action=edit Bug 29158: (bug 22435 follow-up) Remove ref to account_offset_types.sql in intaller Caused by commit 3d6a6e79f79bfbc17807072faf0ff1d4e6aafb82 Bug 22435: (follow-up) Drop account_offset_types table that removes the file but the reference to it from the installer process. Test plan: Go through the install process and notice that the following warning does not appear in the log: [2021/10/25 09:47:58] [WARN] Something went wrong loading file /kohadevbox/koha/installer/data/mysql/mandatory/account_offset_types.sql (Couldn't read '/kohadevbox/koha/installer/data/mysql/mandatory/account_offset_types.sql' : No such file or directory at /usr/share/perl5/DBIx/RunSQL.pm line 180. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29158 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126818|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126914&action=edit Bug 29158: (bug 22435 follow-up) Remove ref to account_offset_types.sql in intaller Caused by commit 3d6a6e79f79bfbc17807072faf0ff1d4e6aafb82 Bug 22435: (follow-up) Drop account_offset_types table that removes the file but the reference to it from the installer process. Test plan: Go through the install process and notice that the following warning does not appear in the log: [2021/10/25 09:47:58] [WARN] Something went wrong loading file /kohadevbox/koha/installer/data/mysql/mandatory/account_offset_types.sql (Couldn't read '/kohadevbox/koha/installer/data/mysql/mandatory/account_offset_types.sql' : No such file or directory at /usr/share/perl5/DBIx/RunSQL.pm line 180. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29158 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Damn, I shouldn't have missed that. Works as expected, thanks for the fix.. going straight for PQA :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29158 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29158 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.