[Bug 13530] New: Typo in bulkmarcimport
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Bug ID: 13530 Summary: Typo in bulkmarcimport Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt@gmail.com Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org A typo seems to have crept in bulkmarcimport causing GetMarcFrameworkCode to fail. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hint: Line 401 the GetFrameworkcode function is has one wrong case character ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 the.invinnysible.one@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |the.invinnysible.one@gmail. | |com Status|NEW |ASSIGNED --- Comment #2 from the.invinnysible.one@gmail.com --- Will attempt to correct problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 --- Comment #3 from the.invinnysible.one@gmail.com --- Created attachment 35132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35132&action=edit bug 13530: Typo in bulkmarcimport GetFrameworkCode was incorrectly spelt as GetFrameworkcode on line 401. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 the.invinnysible.one@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from the.invinnysible.one@gmail.com --- Changed GetFrameworkcode to GetFrameworkCode on line 401. Needs signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 35143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35143&action=edit k -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35132|0 |1 is obsolete| | Attachment #35143|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 35144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35144&action=edit [PASSED QA] bug 13530: Typo in bulkmarcimport GetFrameworkCode was incorrectly spelt as GetFrameworkcode on line 401. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35144|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 35145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35145&action=edit [SIGNED-OFF] bug 13530: Typo in bulkmarcimport GetFrameworkCode was incorrectly spelt as GetFrameworkcode on line 401. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- My colleague who uses this script often is now very happy.. thanks :) I'll try to poke someone in to QA this today, as as the reporter I think that rules me out. Cheers -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to the.invinnysible.one from comment #4)
Changed GetFrameworkcode to GetFrameworkCode on line 401. Needs signoff.
Hi mysterious author, Is there a chance to get a patch with your correct name? The patch's author is Some <some.name@example.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 --- Comment #10 from the.invinnysible.one@gmail.com --- Created attachment 35170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35170&action=edit bug 13530: Typo in bulkmarcimport GetFrameworkCode was incorrectly spelt as GetFrameworkcode on line 401. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 --- Comment #11 from the.invinnysible.one@gmail.com --- (In reply to Jonathan Druart from comment #9)
(In reply to the.invinnysible.one from comment #4)
Changed GetFrameworkcode to GetFrameworkCode on line 401. Needs signoff.
Hi mysterious author, Is there a chance to get a patch with your correct name? The patch's author is Some <some.name@example.org>
My apologies, I have fixed the author name on the patch now. :-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35145|0 |1 is obsolete| | Attachment #35170|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35174&action=edit Bug 13530: Typo in bulkmarcimport GetFrameworkCode was incorrectly spelt as GetFrameworkcode on line 401. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Note that I did not test this patch, because I never user bulkmarcimport. But the fix is trivial and makes sense. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Martin Renvoize from comment #8)
I'll try to poke someone in to QA this today, as as the reporter I think that rules me out.
Where did you read that? I am not sure at all this rules exists :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #14)
(In reply to Martin Renvoize from comment #8)
I'll try to poke someone in to QA this today, as as the reporter I think that rules me out.
Where did you read that? I am not sure at all this rules exists :)
Just had a hunch it might be one.. if not then I could have QA'd it.. oops. Thnaks anyway Jonathan -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Morag, and congratulations! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x, will be in the 3.18.3 release so your code will be out in use by libraries around the world by the end of January, Morag -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13530 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org