[Bug 42411] New: "Place hold" displayed when not possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42411 Bug ID: 42411 Summary: "Place hold" displayed when not possible Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com "Hold must be item level" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42411 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42411 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197699&action=edit Bug 42411: Remove 'Place hold' button when not possible On the place hold screen, if "Hold next available item" is not possible ("Hold must be item level") then the place hold button should not be displayed Test plan: For holds and item group holds: Place a hold for a given then another one If "Hold next available item" is not possible, "Hold must be item level" is displayed and the "Place hold" button shouldn't be displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42411 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42411 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42411 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I attempted to test, but can't reproduce the problem (or understand the issue from the information provided). Can you provide more specific instructions, and anything else required to set up for testing? This is what I attempted: 1. Placed a hold on Intermediate Perl (biblionumber = 126) for Mary Burton ==> Normal hold placed 2. Attempt to place another hold on the same record for Mary: - Hold next available item section is labelled: . (Required) Hold next available item: . Required is in red and italics, there is an active "Place hold" button - Hold a specific item section: not able to selected, and each item has "X Hold must be record level" in red - Can click on the "Place hold" button, and now have two holds for Mary 3. Repeat step 2, but this time the "Place hold" is dimmed (and can't be pressed), with an alert under the page title: Cannot place hold - Too many holds for this record: Mary Burton can only place a maximum of 2 hold(s) on this record. 4. No difference after the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42411 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #3 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I think this requires that system preferences EnableItemGroupHolds and EnableItemGroups are enabled before the error occures. I could (partly) reproduce the problem when I enabled those system preferences, added a item group and then 1. Made a item-level hold for one of the items in the biblio 2. Tried to make a hold for a item group for the same patron and noticed that Place hold button was active. The text "Hold must be item level" is in it's place. I'll have to create a new sandbox to test the patch but wanted to write down my remarks beforehand. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42411 --- Comment #4 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- Now that I tested more, I cannot reproduce anymore the situation where Place hold button is dimmed. :D But the patch itself works. It removes the Place hold button from the Hold next available item and Hold next item group sections if patron already has a item level hold for the same biblio. It does not remove the Place hold button from the Hold a specific item section when patron already has biblio level hold. But the section is dimmed and inactive so that you cannot "open it" and try to click the button. These two cases act differently and I started to wonder if they should act the same way? Always remove the Place hold button or disable the whole section when that kind of hold is not possible. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org