[Bug 24175] New: Cannot cancel holds - wrong parameter passed for itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Bug ID: 24175 Summary: Cannot cancel holds - wrong parameter passed for itemnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com When searching holds we pass $self->{item}->id, which is the barcode, as the itemnumber. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 95999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95999&action=edit Bug 24175: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96000&action=edit Bug 24175: Use itemnumber when searching for holds in SIP drop_hold To test: 1 - place a hold for a patron 2 - Get SIP running https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - edit the sip_cli_emulator.pl for hold_mode from '+' to '-' 4 - Attempt to cancel hold 5 - It fails 6 - Apply patch 7 - Try again 8 - It succeeds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96372&action=edit Bug 24175: Take advantage of Koha::Item->holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95999|0 |1 is obsolete| | Attachment #96000|0 |1 is obsolete| | Attachment #96372|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96375&action=edit Bug 24175: Unit tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96376&action=edit Bug 24175: Use itemnumber when searching for holds in SIP drop_hold To test: 1 - place a hold for a patron 2 - Get SIP running https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - edit the sip_cli_emulator.pl for hold_mode from '+' to '-' 4 - Attempt to cancel hold 5 - It fails 6 - Apply patch 7 - Try again 8 - It succeeds Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96377&action=edit Bug 24175: Take advantage of Koha::Item->holds Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96378&action=edit Bug 24175: Simplify tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96375|0 |1 is obsolete| | --- Comment #8 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 96527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96527&action=edit Bug 24175: Unit tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96376|0 |1 is obsolete| | --- Comment #9 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 96528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96528&action=edit Bug 24175: Use itemnumber when searching for holds in SIP drop_hold To test: 1 - place a hold for a patron 2 - Get SIP running https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - edit the sip_cli_emulator.pl for hold_mode from '+' to '-' 4 - Attempt to cancel hold 5 - It fails 6 - Apply patch 7 - Try again 8 - It succeeds Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96377|0 |1 is obsolete| | --- Comment #10 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 96529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96529&action=edit Bug 24175: Take advantage of Koha::Item->holds Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96378|0 |1 is obsolete| | --- Comment #11 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 96530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96530&action=edit Bug 24175: Simplify tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@helsinki.fi --- Comment #12 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- I added my sign-off for the patches from Jonathan because they were not so trivial. So now waiting for someone to QA this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96527|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 96534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96534&action=edit Bug 24175: Unit tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96528|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 96535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96535&action=edit Bug 24175: Use itemnumber when searching for holds in SIP drop_hold To test: 1 - place a hold for a patron 2 - Get SIP running https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - edit the sip_cli_emulator.pl for hold_mode from '+' to '-' 4 - Attempt to cancel hold 5 - It fails 6 - Apply patch 7 - Try again 8 - It succeeds Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96529|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 96536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96536&action=edit Bug 24175: Take advantage of Koha::Item->holds Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96530|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 96537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96537&action=edit Bug 24175: Simplify tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected and passes tests and qa scripts.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | --- Comment #19 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- cant rebase for 19.05, if it is needed please supply a 19.05 patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96680&action=edit Bug 24175: [19.05.x] Unit tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24175: Simplify tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 24175: [19.05.x] Remove use of Koha::Item::Holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24175 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96681&action=edit Bug 24175: [19.05.x] Use itemnumber when searching for holds in SIP drop_hold To test: 1 - place a hold for a patron 2 - Get SIP running https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - edit the sip_cli_emulator.pl for hold_mode from '+' to '-' 4 - Attempt to cancel hold 5 - It fails 6 - Apply patch 7 - Try again 8 - It succeeds Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org