[Bug 7238] New: The SIPconfig.xml is stored in the C4/SIP dir
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 Bug #: 7238 Summary: The SIPconfig.xml is stored in the C4/SIP dir Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing AssignedTo: gmcharlt@gmail.com ReportedBy: chris@bigballofwax.co.nz QAContact: ian.walls@bywatersolutions.com I want to shift it to etc/ where it should rightfully live -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-11-17 00:18:13 UTC --- Created attachment 6323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6323 Bug 7238 : Shifting SIPconfig.xml to the etc dir and the scripts to misc/bin -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 laurenthdl <henridamien.laurent@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |henridamien.laurent@biblibr | |e.com --- Comment #2 from laurenthdl <henridamien.laurent@biblibre.com> 2011-11-17 08:17:50 UTC --- Hi, would it not be more interesting to have different directories in etc : as discussed here http://lists.koha-community.org/pipermail/koha-devel/2010-November/034735.ht... etc/services/SIP2/ And not directly in etc/ same for bin/ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-11-21 00:44:50 UTC --- Yep, the packages do that on install, the Makefile.PL could do the same thing. The main thing is to first get them out of C4/ so that you don't bust your SIP server whenever you upgrade. But if you wanted to do a patch to move them into other dirs I certainly wouldn't object. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #4 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-11-21 12:11:11 UTC --- sip_run.sh still looks for the config file in the old location. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 --- Comment #5 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-21 14:14:07 UTC --- My strategy has always been to duplicate the SIPconfig.xml to a separate file, customize, then run SIP off that. Saves merge conflicts. But, yes, having this removed completely from C4/SIP is necessary. Getting these files to respect our Make options is vital; perhaps even adding a "do you want to set up SIP2 services?" set of questions to the installer would be good. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de AssignedTo|gmcharlt@gmail.com |chris@bigballofwax.co.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 --- Comment #6 from Liz Rea <wizzyrea@gmail.com> 2012-01-01 03:44:33 UTC --- Created attachment 6998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6998 Bug 7238 Followup - fix sip_run to require path to SIPconfig.xml This requires Chris C's patch to move the scripts to the new location outside of C4. To test: run sip_run.sh with no arguments - it should fail with a message to add the path and try again. Run sip_run.sh with a path to a valid SIPconfig.xml - it should start and run. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6323|0 |1 is obsolete| | --- Comment #7 from Liz Rea <wizzyrea@gmail.com> 2012-01-01 05:37:25 UTC --- Created attachment 6999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6999 Bug 7238 : Shifting SIPconfig.xml to the etc dir and the scripts to misc/bin Signed-off-by: Liz Rea <wizzyrea@gmail.com> The scripts run with the caveat that you must specify the path to SIPconfig.xml. The followup previously attached should take care of that issue. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-02 17:24:21 UTC --- QA question: Am I right if I say it changes the signature of sip_run ? before the patch: you could run without any arg, the SIPconfig.xml was taken from C4/Sip, but you could also pass a parameter with the config file after the patch: you must provide a parameter if i'm right, this patch is an ENH, and will be for 3.8 to avoid any regression for existing users during maintenante update. Otherwise, passed QA, but i'm waiting for the answer to push -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 --- Comment #9 from Liz Rea <wizzyrea@gmail.com> 2012-02-03 00:04:16 UTC --- Paul: that is correct. My opinion is that it can wait for 3.8. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 Summary|The SIPconfig.xml is stored |move SIPconfig.xml, sip_run |in the C4/SIP dir |and sip_shutdown outside | |from C4 (NOT FOR 3.6) Severity|minor |enhancement -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 --- Comment #10 from Robin Sheat <robin@catalyst.net.nz> 2012-02-10 00:53:07 UTC --- Created attachment 7549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7549 Bug 7238 - make packages deal with SIP config This moves the SIP config to the templates directory (on package building) in anticipation of making it configurable with package tools. Prevents it being installed into /etc. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED CC| |robin@catalyst.net.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7549|0 |1 is obsolete| | --- Comment #11 from Robin Sheat <robin@catalyst.net.nz> 2012-02-10 01:32:25 UTC --- Created attachment 7551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7551 Bug 7238 - make packages deal with SIP config This moves the SIP config to the templates directory (on package building) in anticipation of making it configurable with package tools. Prevents it being installed into /etc. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 --- Comment #12 from Robin Sheat <robin@catalyst.net.nz> 2012-02-10 01:33:57 UTC --- (the update includes a change I forgot to add) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6998|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6999|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7551|0 |1 is obsolete| | --- Comment #13 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-13 01:40:29 UTC --- Created attachment 7602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7602 Bug 7238 - make packages deal with SIP config This moves the SIP config to the templates directory (on package building) in anticipation of making it configurable with package tools. Prevents it being installed into /etc. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jcamins@cpbibliography.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-15 16:24:43 UTC --- Nothing looks wrong to me on this follow-up. Will push it, however, I haven't tested it myself, trusting Robin & Jared, they're much more aware than I'm for this kind of packaging -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7238 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org