[Bug 16222] New: Add REST API folder to Makefile.PL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16222 Bug ID: 16222 Summary: Add REST API folder to Makefile.PL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: benjamin.rokseth@kul.oslo.kommune.no QA Contact: testopia@bugs.koha-community.org By installing with perl Makefile.PL you will miss the required `api` folder containing the Swagger definition files and the Mojolicious mount CGI file app.pl. This patch simply adds the `api` folder to the Makefile to install to the INTRANET_CGI_DIR To verify, simply do a `perl Makefile.PL` installation and verify that the folder SRC/api is copied to INSTALL_DIR/intranet/cgi-bin/api -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16222 --- Comment #1 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 50012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50012&action=edit Bug 16222 - Add REST API folder to Makefile.PL Add `api` folder to INTRANET_CGI_FOLDER in Makefile.PL so that the new RESTFul API introduced in bug #13799 works also when installing with make. Test plan: - apply patch and do a `perl Makefile.PL` install - observe that INSTALL_DIR/intranet/cgi-bin now has a folder `api` containing the swagger files and the api cgi mount, app.pl. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16222 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16222 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16222 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50012|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 50374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50374&action=edit Bug 16222 - Add REST API folder to Makefile.PL Add `api` folder to INTRANET_CGI_FOLDER in Makefile.PL so that the new RESTFul API introduced in bug #13799 works also when installing with make. Test plan: - apply patch and do a `perl Makefile.PL` install - observe that INSTALL_DIR/intranet/cgi-bin now has a folder `api` containing the swagger files and the api cgi mount, app.pl. Signed-off-by: Chris Cormack <chrisc@catalyst.net.z> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16222 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16222 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50374|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50383&action=edit [PASSED QA] Bug 16222 - Add REST API folder to Makefile.PL Add `api` folder to INTRANET_CGI_FOLDER in Makefile.PL so that the new RESTFul API introduced in bug #13799 works also when installing with make. Test plan: - apply patch and do a `perl Makefile.PL` install - observe that INSTALL_DIR/intranet/cgi-bin now has a folder `api` containing the swagger files and the api cgi mount, app.pl. Signed-off-by: Chris Cormack <chrisc@catalyst.net.z> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16222 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I think the solution falls short, because the koha-httpd.conf file points to the opac/ dir too. So it should be put in two different places. The best approach would be to just put it on its own dir (/usr/share/koha/api). I'll try to provide a followup. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16222 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16222 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 50477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50477&action=edit Bug 16222: (QA followup) Add /api dir for the API Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16222 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16222 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16222 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org