[Bug 25188] New: Circulation notes only displays on checkouts tab, but not on details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 Bug ID: 25188 Summary: Circulation notes only displays on checkouts tab, but not on details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When a patron note is added via "Add message" it displays on both the checkouts and the details tab. But a circulation note (Edit patron...) is only displayed on the checkouts tab. It would be nice if the circulation note also showed on the details tab. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21211 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts@ptfs-europe.c | |om Assignee|koha-bugs@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com --- Comment #1 from Lisette Scheer <lisetteslatah@gmail.com> --- On master I still see this, but rather than being on the top of the page with messages, it is under "Library Use" below the password. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 --- Comment #2 from David Roberts <david.roberts@ptfs-europe.com> --- I concur with Lisette. I also think it's a little confusing that the terminology of Opac note and Circulation note is named differently in the Add message function. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi David, can you explain a bit more? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 --- Comment #4 from David Roberts <david.roberts@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #3)
Hi David, can you explain a bit more?
Hi Katrin, sorry this is my mistake. I hadn't realised that the messages go to a completely different table. I thought they worked the same way that the OPAC and Circulation notes do, but I was wrong. Ignore me! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah right, that can be a bit confusing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 --- Comment #6 from David Roberts <david.roberts@ptfs-europe.com> --- Hi Katrin, is this still an issue? The circulation note display on the Display tab under the library use block on the right hand side. Would you like it more prominent? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think I'd make the display the same for checkouts an details in also displaying git on top - but that's more a feeling. You are right in that it displays on the page. I splitted this out of bug 21211, which was not reported by me, when fixing the tool bars :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Circulation notes only |Make circulation notes more |displays on checkouts tab, |prominent on the patron |but not on details |details tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 --- Comment #8 from David Roberts <david.roberts@ptfs-europe.com> --- I've changed the title of this bug as it has moved on from what was originally reported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 --- Comment #9 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 104312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104312&action=edit Bug 25188: Make circulation notes more prominent on the patron details tab This patch adds a more prominent circulation note to the moremember.pl details screen. To test: 1) Add a circulation note to a patron record. 2) Note that it displays prominently on the checkout tab, but only under the Library Use block on the details tab. 3) Apply the patch. 4) Check that the note is now displayed prominently at the top of the details (moremember.pl) screen. https://bugs.koha-community.org/show_bug.cgi?id=25118 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 --- Comment #10 from David Roberts <david.roberts@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #7)
I think I'd make the display the same for checkouts an details in also displaying git on top - but that's more a feeling. You are right in that it displays on the page.
I splitted this out of bug 21211, which was not reported by me, when fixing the tool bars :)
Hi Katrin - I hope this patch does what you want! :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104312|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104346&action=edit Bug 25188: Make circulation notes more prominent on the patron details tab This patch adds a more prominent circulation note to the moremember.pl details screen. To test: 1) Add a circulation note to a patron record. 2) Note that it displays prominently on the checkout tab, but only under the Library Use block on the details tab. 3) Apply the patch. 4) Check that the note is now displayed prominently at the top of the details (moremember.pl) screen. https://bugs.koha-community.org/show_bug.cgi?id=25118 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=25245 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104346|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104347&action=edit Bug 25188: Make circulation notes more prominent on the patron details tab This patch adds a more prominent circulation note to the moremember.pl details screen. To test: 1) Add a circulation note to a patron record. 2) Note that it displays prominently on the checkout tab, but only under the Library Use block on the details tab. 3) Apply the patch. 4) Check that the note is now displayed prominently at the top of the details (moremember.pl) screen. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Finally got the right patch attached to the right bug - phew. This was what i was thinking about - thx Phil. Should we get some more opinions on this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104347|0 |1 is obsolete| | --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 104358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104358&action=edit Bug 25188: Make circulation notes more prominent on the patron details tab This patch adds a more prominent circulation note to the moremember.pl details screen. To test: 1) Add a circulation note to a patron record. 2) Note that it displays prominently on the checkout tab, but only under the Library Use block on the details tab. 3) Apply the patch. 4) Check that the note is now displayed prominently at the top of the details (moremember.pl) screen. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #16 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org