[Bug 16369] New: Clean up and improve plugins template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369 Bug ID: 16369 Summary: Clean up and improve plugins template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/plugins/plugins-home.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The template for managing plugins should be revised to better comply with established interface patterns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50823&action=edit Bug 16369 - Clean up and improve plugins template This patch makes multiple changes to the plugins home page template to bring it up to date with current interface patterns. Test the following changes: - Breacrumb links have been corrected to include "Tools" in the path. Verify that this link is correct. - A toolbar has been added for an "Upload plugin" button. Uploading is an action, not a view, so it should be displayed in a toolbar. Verify that the button works correctly. - Messages are now formatted as messages rather than as headings. To test, trigger a message by, for instance, uninstalling all plugins or passing an invalid "method" parameter with the URL. - Incorrect capitalization corrected. - Plugin actions are moved to a single "Actions" dropdown menu. This includes 'Run report,' 'Run tool,' 'Configure,' and 'Uninstall.' Test that all these menu options work correctly. - The standard "Tools" sidebar menu has been added. - An "onclick" attribute has been removed in favor of defining the event in JavaScript. Test by choosing the 'Uninstall' menu item for a plugin. Test both confirm and cancel actions. Also changed: - Corrected capitalization on the tools home page. - Adding missing plugins link to the tools sidebar menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369 Arslan Farooq <arslanone@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arslanone@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Arslan Farooq <arslanone@gmail.com> --- Hi Owen, when applying the patch, it says: -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 16369 - Clean up and improve plugins template Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc Failed to merge in the changes. Patch failed at 0001 Bug 16369 - Clean up and improve plugins template When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50823|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50910&action=edit Bug 16369 - Clean up and improve plugins template This patch makes multiple changes to the plugins home page template to bring it up to date with current interface patterns. Test the following changes: - Breacrumb links have been corrected to include "Tools" in the path. Verify that this link is correct. - A toolbar has been added for an "Upload plugin" button. Uploading is an action, not a view, so it should be displayed in a toolbar. Verify that the button works correctly. - Messages are now formatted as messages rather than as headings. To test, trigger a message by, for instance, uninstalling all plugins or passing an invalid "method" parameter with the URL. - Incorrect capitalization corrected. - Plugin actions are moved to a single "Actions" dropdown menu. This includes 'Run report,' 'Run tool,' 'Configure,' and 'Uninstall.' Test that all these menu options work correctly. - The standard "Tools" sidebar menu has been added. - An "onclick" attribute has been removed in favor of defining the event in JavaScript. Test by choosing the 'Uninstall' menu item for a plugin. Test both confirm and cancel actions. Also changed: - Corrected capitalization on the tools home page. - Adding missing plugins link to the tools sidebar menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369 --- Comment #4 from Arslan Farooq <arslanone@gmail.com> --- This patch makes multiple changes to the plugins home page template to bring it up to date with current interface patterns. Test the following changes: - Breacrumb links have been corrected to include "Tools" in the path. Verify that this link is correct. - A toolbar has been added for an "Upload plugin" button. Uploading is an action, not a view, so it should be displayed in a toolbar. Verify that the button works correctly. - Messages are now formatted as messages rather than as headings. To test, trigger a message by, for instance, uninstalling all plugins or passing an invalid "method" parameter with the URL. - Incorrect capitalization corrected. - Plugin actions are moved to a single "Actions" dropdown menu. This includes 'Run report,' 'Run tool,' 'Configure,' and 'Uninstall.' Test that all these menu options work correctly. - The standard "Tools" sidebar menu has been added. - An "onclick" attribute has been removed in favor of defining the event in JavaScript. Test by choosing the 'Uninstall' menu item for a plugin. Test both confirm and cancel actions. Also changed: - Corrected capitalization on the tools home page. - Adding missing plugins link to the tools sidebar menu. ------------------------------------ I tested everything one by one, and things works OK. Did qa tools check, and I get this: http://paste.koha-community.org/431 I'm thinking may be something wrong with my set-up? ------------------------------------ While testing this patch, discovered something and created new bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16391 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Arslan Farooq from comment #4)
Did qa tools check, and I get this: http://paste.koha-community.org/431 I'm thinking may be something wrong with my set-up?
Perhaps a byproduct of kohadevbox. No errors for me, you can sign. OK koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc OK forbidden patterns OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt OK forbidden patterns OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt OK forbidden patterns OK spelling OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369 Arslan Farooq <arslanone@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Arslan Farooq <arslanone@gmail.com> --- his patch makes multiple changes to the plugins home page template to bring it up to date with current interface patterns. Test the following changes: - Breacrumb links have been corrected to include "Tools" in the path. Verify that this link is correct. - A toolbar has been added for an "Upload plugin" button. Uploading is an action, not a view, so it should be displayed in a toolbar. Verify that the button works correctly. - Messages are now formatted as messages rather than as headings. To test, trigger a message by, for instance, uninstalling all plugins or passing an invalid "method" parameter with the URL. - Incorrect capitalization corrected. - Plugin actions are moved to a single "Actions" dropdown menu. This includes 'Run report,' 'Run tool,' 'Configure,' and 'Uninstall.' Test that all these menu options work correctly. - The standard "Tools" sidebar menu has been added. - An "onclick" attribute has been removed in favor of defining the event in JavaScript. Test by choosing the 'Uninstall' menu item for a plugin. Test both confirm and cancel actions. Also changed: - Corrected capitalization on the tools home page. - Adding missing plugins link to the tools sidebar menu. ------------------------------------ I tested everything one by one, and things works OK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369 --- Comment #7 from Arslan Farooq <arslanone@gmail.com> --- Thank you Bernardo! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50910|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51093&action=edit Bug 16369 - Clean up and improve plugins template This patch makes multiple changes to the plugins home page template to bring it up to date with current interface patterns. Test the following changes: - Breacrumb links have been corrected to include "Tools" in the path. Verify that this link is correct. - A toolbar has been added for an "Upload plugin" button. Uploading is an action, not a view, so it should be displayed in a toolbar. Verify that the button works correctly. - Messages are now formatted as messages rather than as headings. To test, trigger a message by, for instance, uninstalling all plugins or passing an invalid "method" parameter with the URL. - Incorrect capitalization corrected. - Plugin actions are moved to a single "Actions" dropdown menu. This includes 'Run report,' 'Run tool,' 'Configure,' and 'Uninstall.' Test that all these menu options work correctly. - The standard "Tools" sidebar menu has been added. - An "onclick" attribute has been removed in favor of defining the event in JavaScript. Test by choosing the 'Uninstall' menu item for a plugin. Test both confirm and cancel actions. Also changed: - Corrected capitalization on the tools home page. - Adding missing plugins link to the tools sidebar menu. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|enhancement |normal --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I'd consider this patch as a bugfix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.05, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16369 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org