[Bug 17317] New: Adding "bib" type to GetAvailability method for ILSDI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Bug ID: 17317 Summary: Adding "bib" type to GetAvailability method for ILSDI Change sponsored?: Seeking developer Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: arthur.suzuki@univ-lyon3.fr QA Contact: testopia@bugs.koha-community.org CC: arthur.suzuki@univ-lyon3.fr Created attachment 55685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55685&action=edit Email conversation GetAvailability method has some unimplemented features, it is not possible to query availability by biblionumber. Only query for one item at a time is implemented. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Attachment #55685|0 |1 is obsolete| | --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Comment on attachment 55685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55685 Email conversation Obsolete email attachment in favor of URL to koha-devel archives: http://lists.koha-community.org/pipermail/koha-devel/2016-September/043075.h... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 --- Comment #2 from Arthur Suzuki <arthur.suzuki@univ-lyon3.fr> --- Created attachment 55714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55714&action=edit GetAvailability "id_type=bib" quick'n dirty implementation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Arthur Suzuki <arthur.suzuki@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Arthur Suzuki <arthur.suzuki@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Seeking developer |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 --- Comment #3 from Arthur Suzuki <arthur.suzuki@univ-lyon3.fr> --- To test this patch you should try to send a query to you opac formatted this way : http://[your-opac-domain-name]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[biblionumber]&id_type=bib You should get availability status for all the items of the matched bibliographic record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55714|0 |1 is obsolete| | --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 55775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55775&action=edit Bug 17317: ILSDI - Getavailability method with id_type=bib implementation To test this patch you should try to send a query to you opac formatted this way : http://[your-opac-domain-name]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[biblionumber]&id_type=bib You should get availability status for all the items of the matched bibliographic record. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Severity|new feature |enhancement Version|unspecified |master Assignee|koha-bugs@lists.koha-commun |arthur.suzuki@univ-lyon3.fr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 55775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55775 Bug 17317: ILSDI - Getavailability method with id_type=bib implementation Review of attachment 55775: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17317&attachment=55775) ----------------------------------------------------------------- ::: C4/ILSDI/Services.pm @@ +136,5 @@
my $msg; my $biblioitem = ( GetBiblioItemByBiblioNumber( $id, undef ) )[0]; if ($biblioitem) { + my $biblioitemnumber = $biblioitem->{'biblioitemnumber'}; + my $items = (GetItemsByBiblioitemnumber($biblioitemnumber))[0];
I think it would be better to use GetItemnumbersForBiblio instead of GetItemsByBiblioitemnumber, we just need the itemnumbers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Arthur Suzuki <arthur.suzuki@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55775|0 |1 is obsolete| | --- Comment #6 from Arthur Suzuki <arthur.suzuki@univ-lyon3.fr> --- Created attachment 55956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55956&action=edit Performance Improvement Thank you Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Arthur Suzuki <arthur.suzuki@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Hours Worked| |4.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55956|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55970&action=edit Bug 17317 ILSDI - Getavailability method with id_type=bib implementation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55971&action=edit Bug 17317: Perfomance Improvement - Use of GetItemnumbersForBiblio instead of GetItemsByBiblioitemnumber (thx Jonathan Druart) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Needs Signoff --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have just reuploaded the patches (correctly formatted). I'd like to get another signoff on these 2 patches, the structure of the XML has changed (and seems to make more sense). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55970|0 |1 is obsolete| | --- Comment #11 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 55981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55981&action=edit [SIGNED-OFF]Bug 17317: ILSDI: Getavailability method with id_type=bib implementation To test this patch you should try to send a query to you opac formatted this way : http://[your-opac-domain-name]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[biblionumber]&id_type=bib You should get availability status for all the items of the matched bibliographic record. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55971|0 |1 is obsolete| | --- Comment #12 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 55982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55982&action=edit [SIGNED-OFF]Bug 17317: Perfomance Improvement - Use of GetItemnumbersForBiblio instead of GetItemsByBiblioitemnumber (thx Jonathan Druart) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Pascale Nalon <pascale.nalon@ensmp.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pascale.nalon@ensmp.fr, | |pascale.nalon@mines-pariste | |ch.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55981|0 |1 is obsolete| | Attachment #55982|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58180&action=edit Bug 17317: Perfomance Improvement - Use of GetItemnumbersForBiblio instead of GetItemsByBiblioitemnumber (thx Jonathan Druart) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58180|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58287&action=edit Bug 17317: ILSDI: Getavailability method with id_type=bib implementation To test this patch you should try to send a query to you opac formatted this way : http://[your-opac-domain-name]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[biblionumber]&id_type=bib You should get availability status for all the items of the matched bibliographic record. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58288&action=edit Bug 17317: Perfomance Improvement - Use of GetItemnumbersForBiblio instead of GetItemsByBiblioitemnumber (thx Jonathan Druart) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Arthur! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 --- Comment #18 from Tom Misilo <misilot@fit.edu> --- Created attachment 58469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58469&action=edit Example in 3.22 Katrin, it may be a bug in 16.x if it is a bug in 3.22.10.000 no? As the ILS-DI Driver lists id_type=bib but it does not return anything. I attached a photo of what I see in 3.22.10 Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tested this feature to see if it was safe to go in by not changing the existing behaviour of GetAvailability for 'item'. return_type doesn't seem to be implemented as well? I think that the error page doesn't look good when you give an invalid bibnumber: .../cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=20000&id_type=bib <dlf:collection xsi:schemaLocation="http://diglib.org/ilsdi/1.1 http://diglib.org/architectures/ilsdi/schemas/1.1/dlfexpanded.xsd"><dlf:record><dlf:bibliographic id="20000"/><dlf:items> </dlf:items></dlf:record></dlf:collection> For item it looks like this: <dlf:collection xsi:schemaLocation="http://diglib.org/ilsdi/1.1 http://diglib.org/architectures/ilsdi/schemas/1.1/dlfexpanded.xsd"><dlf:record><dlf:bibliographic id="20000"/><dlf:items><dlf:item id="20000"><dlf:simpleavailability><dlf:identifier>20000</dlf:identifier><dlf:availabilitystatus>unknown</dlf:availabilitystatus><dlf:availabilitymsg>Error: could not retrieve availability for this ID</dlf:availabilitymsg></dlf:simpleavailability></dlf:item></dlf:items></dlf:record></dlf:collection> What do you think? return_type doesn't seem to be implemented as well? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org