[Bug 6915] New: koha_perl_deps.pl truncates long module names at 26 chars
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6915 Bug #: 6915 Summary: koha_perl_deps.pl truncates long module names at 26 chars Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 Component: Installation and upgrade (command-line installer) AssignedTo: gmcharlt@gmail.com ReportedBy: gbarniskis@gmail.com QAContact: koha-bugs@lists.koha-community.org koha_perl_deps.pl doesn't correctly report module names longer than 26 characters, truncating (at least) CGI::Session::Driver::memcached, CGI::Session::Serialize::yaml and MARC::Crosswalk::DublinCore. Test: perl koha_perl_deps.pl -a reports full module names? Proposed fix: modify the report's format statement and surrounding header and footer prints, which apply generally too much white space. A better fix might make the whole thing more flexible than fixed width columns. Patch coming as soon as git config stops hating on me. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6915 --- Comment #1 from Greg Barniskis <gbarniskis@gmail.com> 2011-09-26 17:20:15 UTC --- Created attachment 5593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5593 patch for 6915 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6915 Greg Barniskis <gbarniskis@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6915 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff AssignedTo|gmcharlt@gmail.com |gbarniskis@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6915 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5593|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@enger.priv.no> 2011-10-06 14:08:01 UTC --- Created attachment 5739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5739 Bug 6915 - [SIGNED-OFF] reduce module name truncation problem in koha_perl_deps.pl Widen module name allowance in the format statement, adjust other columns to be generous but not-so-much as before, modify report header and footer print statements to align and clarify. Very very long module names or version numbers are still subject to possible truncation. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Sign off comment: With this patch module names are not truncated, which is an improvement. Lines are still too long to fit an 80 column display, and so they wrap around, but tht is a minor annoyance compared to the truncated names. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6915 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6915 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-14 10:21:43 UTC --- QA comment : * test plan not detailled enough. Complete version with an example : Before the patch, ./koha_perl_deps.pl -i says: CGI::Session::Serialize::y 4.26 4.2 Yes After the patch, it says: CGI::Session::Serialize::yaml 4.26 4.2 Yes * agreed with magnus comment, but also noticing that the patch was not intended to fix the 80 column display * small changes in the code, nothing to comment, passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6915 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5739|0 |1 is obsolete| | --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-14 10:22:05 UTC --- Created attachment 5888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5888 Bug 6915 - [SIGNED-OFF] reduce module name truncation problem in koha_perl_deps.pl Widen module name allowance in the format statement, adjust other columns to be generous but not-so-much as before, modify report header and footer print statements to align and clarify. Very very long module names or version numbers are still subject to possible truncation. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Sign off comment: With this patch module names are not truncated, which is an improvement. Lines are still too long to fit an 80 column display, and so they wrap around, but tht is a minor annoyance compared to the truncated names. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6915 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6915 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-15 01:01:48 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org