[Bug 19233] New: Add ability to send itemnumbers in report results to batch modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Bug ID: 19233 Summary: Add ability to send itemnumbers in report results to batch modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: nick@bywatersolutions.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 66680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66680&action=edit Bug 19233 - Add ability to send itemnumbers in report results to batch modification To test: 1 - Apply patch 2 - Run a report with an itemnumber column 3 - Note there is a linked '^' after column title 4 - Hover over the '^' 5 - You should see a tooltip 'Send visible items to batch modification' 6 - Click the '^' 7 - You should be sent to batch item modification with itemnumbers that were visible in report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, will that only work if you name the column itemnumber? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta@informaticsgloba | |l.com, | |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 ByWaterSandboxes@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ByWaterSandboxes@gmail.com Status|Needs Signoff |Signed Off --- Comment #3 from ByWaterSandboxes@gmail.com --- Patch tested with a sandbox, by George <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 ByWaterSandboxes@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66680|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 --- Comment #4 from ByWaterSandboxes@gmail.com --- Created attachment 67087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67087&action=edit Bug 19233 - Add ability to send itemnumbers in report results to batch modification To test: 1 - Apply patch 2 - Run a report with an itemnumber column 3 - Note there is a linked '^' after column title 4 - Hover over the '^' 5 - You should see a tooltip 'Send visible items to batch modification' 6 - Click the '^' 7 - You should be sent to batch item modification with itemnumbers that were visible in report Signed-off-by: George <george@nekls.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #2)
Hm, will that only work if you name the column itemnumber?
My test indicates that this is the case. The column must be named "itemnumber." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 67186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67186&action=edit Bug 19233: (follow-up) Send itemnumbers in report results to batch modification This patch changes the obscure "^" symbol to a styled link with the text "Batch modify." I think the only disadvantage of this is that it takes up more space, but it is outweighed by the improved clarity. This patch also makes minor indentation corrections to new lines of HTML. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a bit of a translation issue, but I like the idea of this and can't come up with a way to avoid the problem right now. could we use a placeholder that would still allow a translated heading? "Exemplarnummer <<itemnumber>>"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67087|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 67805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67805&action=edit Bug 19233 - Add ability to send itemnumbers in report results to batch modification To test: 1 - Apply patch 2 - Run a report with an itemnumber column 3 - Note there is a linked '^' after column title 4 - Hover over the '^' 5 - You should see a tooltip 'Send visible items to batch modification' 6 - Click the '^' 7 - You should be sent to batch item modification with itemnumbers that were visible in report Signed-off-by: George <george@nekls.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67186|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 67806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67806&action=edit Bug 19233: (follow-up) Send itemnumbers in report results to batch modification This patch changes the obscure "^" symbol to a styled link with the text "Batch modify." I think the only disadvantage of this is that it takes up more space, but it is outweighed by the improved clarity. This patch also makes minor indentation corrections to new lines of HTML. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's a neat little feature, even with the translation issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67805|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69920&action=edit Bug 19233 - Add ability to send itemnumbers in report results to batch modification To test: 1 - Apply patch 2 - Run a report with an itemnumber column 3 - Note there is a linked '^' after column title 4 - Hover over the '^' 5 - You should see a tooltip 'Send visible items to batch modification' 6 - Click the '^' 7 - You should be sent to batch item modification with itemnumbers that were visible in report Signed-off-by: George <george@nekls.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67806|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69921&action=edit Bug 19233: (follow-up) Send itemnumbers in report results to batch modification This patch changes the obscure "^" symbol to a styled link with the text "Batch modify." I think the only disadvantage of this is that it takes up more space, but it is outweighed by the improved clarity. This patch also makes minor indentation corrections to new lines of HTML. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Patches have been rebased on current master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69920|0 |1 is obsolete| | --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 72566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72566&action=edit Bug 19233 - Add ability to send itemnumbers in report results to batch modification To test: 1 - Apply patch 2 - Run a report with an itemnumber column 3 - Note there is a linked '^' after column title 4 - Hover over the '^' 5 - You should see a tooltip 'Send visible items to batch modification' 6 - Click the '^' 7 - You should be sent to batch item modification with itemnumbers that were visible in report Signed-off-by: George <george@nekls.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69921|0 |1 is obsolete| | --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 72567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72567&action=edit Bug 19233: (follow-up) Send itemnumbers in report results to batch modification This patch changes the obscure "^" symbol to a styled link with the text "Batch modify." I think the only disadvantage of this is that it takes up more space, but it is outweighed by the improved clarity. This patch also makes minor indentation corrections to new lines of HTML. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- + $(".send_to_item_mod").click(function(e){ + e.preventDefault(); + $("#report_results").attr("action","/cgi-bin/koha/tools/batchMod.pl"); + $("#report_results").submit(); + }); This sounds hacky at first glance, why this trick? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #16)
+ $(".send_to_item_mod").click(function(e){ + e.preventDefault(); + $("#report_results").attr("action","/cgi-bin/koha/tools/batchMod.pl"); + $("#report_results").submit(); + });
This sounds hacky at first glance, why this trick?
Ah, I believe I was thinking we could expand the options here, allow sending the itemnumbers elsewhere as well ('Add to list','batch delete' etc.) Setting the action in the JS let me plan for different actions depending on where we send. I implemented batch-mod as a starting point -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- If not used it should be removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73344&action=edit Bug 19233: (follow-up) Don't use JS trickery to set form action -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73344|0 |1 is obsolete| | --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73345&action=edit Bug 19233: (follow-up) Use a button to submit form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73345|0 |1 is obsolete| | --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73346&action=edit Bug 19233: (follow-up) Use a button to submit form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73346|0 |1 is obsolete| | --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73347&action=edit Bug 19233: (follow-up) Use a button to submit form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73356&action=edit Bug 19233: Restore styling of the button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, enhancement, not backported for stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22167 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22167 [Bug 22167] Allow itemnumber column to be labelled differently when using bach item edit feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23197 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23197 [Bug 23197] Add more batch operation options to SQL report results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23205 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23205 [Bug 23205] Batch item operations should be available to report which return barcodes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23206 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23206 [Bug 23206] Batch patron operations for reports which return borrowernumber or cardnumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24305 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305 [Bug 24305] Batch Item modification via item number in reports does not work with CONCAT in report -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org