[Bug 25906] New: In opac-serial-issues.pl, when looking at full history, the search facet form should look good.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906 Bug ID: 25906 Summary: In opac-serial-issues.pl, when looking at full history, the search facet form should look good. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: timothy_alexis.vass@ub.lu.se QA Contact: testopia@bugs.koha-community.org Created attachment 106447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106447&action=edit What it currently looks like. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906 --- Comment #1 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 106448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106448&action=edit What it should look like. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906 --- Comment #2 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- 1. In linked stylesheet: #menu form, #search-facets form { margin: 0em; } Change margin to 1em. ----- 2. In the inline style block: #search-facets fieldset.action { padding-left: 4px; margin: .3em; } Remove padding-let and margin, set text-align to center. ----- 3. In opac-full-serial-issues: <select id="libraryfilter" name="libraryfilter" style="width:10em;"></select> <select id="subscriptionidfilter" name="subscriptionfilter" style="width:10em;" disabled="disabled"></select> Remove style="width:10em;" from these two elements. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106449&action=edit How it looks in master What version are you looking at? What I see in master doesn't match your "What it currently looks like" screenshot. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106447|0 |1 is obsolete| | --- Comment #4 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 106459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106459&action=edit How it looks in master for me Indeed my branch was behind by 466 commits. I have now pulled origin/master and this is what I currently have: root@9972e03d5da8:koha(master)$ git log commit d3f0fc135b0b73b7dcf7fee09ca30a42e2e514a3 Author: Julian Maurice <julian.maurice@biblibre.com> Date: Mon Jun 29 17:23:35 2020 +0400 Attached is what it looks like for me in Firefox. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906 --- Comment #5 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Looking at your screenshot Owen, it looks nice. 1. I still suggest to remove style="width:10em;" from the two select elements, so that they adapt to the span2 width and so that the elements stay inside the container. 2. I would also like to change the span2 to a span3 so that the space inside makes sense at widths 768px to 1200px. The .span2 select { width: 100%; } would need to apply for .span3 select too. 3. I also suggest that the Clear-button is centered. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|In opac-serial-issues.pl, |Style corrections for OP |when looking at full | |history, the search facet | |form should look good. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Style corrections for OP |Style corrections for OPAC | |serial pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106785&action=edit Bug 25906: Style corrections for OPAC serial pages This patch makes some CSS changes to the OPAC SCSS and to the OPAC "full serial issues" page to improve the style. I've expanded the in-page CSS on the full serial issues page for readability and added Template Toolkit's "collapse" filter to remove the whitespace on rendering. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Locate a serial record in the OPAC. - Click "More details" to view the issues page. - Confirm that the "view" tabs look correct, with consistent padding. - Click the "Full history" tab. - In the sidebar, the filter should have full-width dropdowns and clear button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Looks great in both Firefox and Chrome. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106785|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 107965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107965&action=edit Bug 25906: Style corrections for OPAC serial pages This patch makes some CSS changes to the OPAC SCSS and to the OPAC "full serial issues" page to improve the style. I've expanded the in-page CSS on the full serial issues page for readability and added Template Toolkit's "collapse" filter to remove the whitespace on rendering. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Locate a serial record in the OPAC. - Click "More details" to view the issues page. - Confirm that the "view" tabs look correct, with consistent padding. - Click the "Full history" tab. - In the sidebar, the filter should have full-width dropdowns and clear button. Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (15:32:29) cait: TimothyAlexis: should I add your sign-off line to bug 25906? (15:33:05) TimothyAlexis: Sure And so I did it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org