[Bug 13768] New: in quotes.tt line 14 the use of \" break the translation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13768 Bug ID: 13768 Summary: in quotes.tt line 14 the use of \" break the translation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: christophe.croullebois@biblibre.com QA Contact: testopia@bugs.koha-community.org In quotes.tt line 14 we have : var sEmptyTable = _("No quotes available. Please use the \"Add quote\" button to add a quote."); The use of \" inside double quotes breaks the js in the translated pages. i.e : in french pages in the table we have "Chargement des données..." and can't go ahead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13768 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |christophe.croullebois@bibl | |ibre.com Assignee|oleonard@myacpl.org |christophe.croullebois@bibl | |ibre.com --- Comment #1 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 36766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36766&action=edit proposed patch Bug 13768: Correction of double quotes escaped into double quotes Without the patch the translated pages for quotes.tt may have the problematic line broken. So the js is broken too. The line with bad usage of double quotes escaped : var sEmptyTable = _("No quotes available. Please use the \"Add quote\" button to add a quote."); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13768 --- Comment #2 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Test plan : without patch : 1/ in English pages go to tools/Edit quotes for QOTD feature 2/ create some quotes if there is no 3/ you must have at least 2 languages translated 4/ try with a language translated the page quotes.pl 5/ you must have the translated page broken (message charging... in the table, no use possible in the page) if no try another language With the patch : same steps 1-5 5/ the translated pages must be ok thx for testing -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13768 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36766|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 36770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36770&action=edit [SIGNED-OFF] Bug 13768: Correction of double quotes escaped into double quotes Without the patch the translated pages for quotes.tt may have the problematic line broken. So the js is broken too. The line with bad usage of double quotes escaped : var sEmptyTable = _("No quotes available. Please use the \"Add quote\" button to add a quote."); Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> diff on staff PO file -msgid "" -"No quotes available. Please use the \\\"Add quote\\\" button to add a quote." +#, fuzzy +msgid "No quotes available. Please use the 'Add quote' button to add a quote." No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13768 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13768 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13768 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36770|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36905&action=edit [PASSED QA] Bug 13768: Correction of double quotes escaped into double quotes Without the patch the translated pages for quotes.tt may have the problematic line broken. So the js is broken too. The line with bad usage of double quotes escaped : var sEmptyTable = _("No quotes available. Please use the \"Add quote\" button to add a quote."); Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> diff on staff PO file -msgid "" -"No quotes available. Please use the \\\"Add quote\\\" button to add a quote." +#, fuzzy +msgid "No quotes available. Please use the 'Add quote' button to add a quote." No koha-qa errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13768 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Christophe! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13768 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org