https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21444 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18355 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21444 --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 79547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79547&action=edit Bug 21444: Adds the permanent location To Test: 1) Be sure ReturnToShelvingCart is set to Move. 2) Check out an item. 3) Check in the item. 4) Note that only the CART location shows in the Shelving location column. 5) Apply the patch. 6) Check out an item. 7) Check in the item. 8) Note that the permant location now shows with the cart location next to in in parenthesis. 9) Try combinations of missing descriptions or missing locations from the LOC table for the item permanent location and cart. If there is no description, it should show the code in its place. If there is no location defined, it will show either the code that is stored in the item or be blank. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21444 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- I am open to suggestions on this one. I show both the permanent location for the shelving, and the cart location. I feel it might be redundant to show the cart location as well, since the item is in hand and being checked in. If there are enough objections, I will gladly remove the cart location. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21444 Olivia <olivialokm@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olivialokm@gmail.com Assignee|cbrannon@cdalibrary.org |olivialokm@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21444 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cbrannon@cdalibrary.org |ity.org | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21444 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Christopher, I'have tested it and it works nicely. I wonder if it should be Book cart (permanent location) as the first is the current... but I think both work. But I'd like to ask you to move the display logic, like setting the () to the template. I have to say that I am confused by all the checking before your patch and after - but I notice it's different than before? - $ri{'location'} = $shelflocations->{$shelfcode} if ( defined( $shelfcode ) && defined($shelflocations) && exists( $shelflocations->{$shelfcode} ) ); + my $permshelfcode = $ri{'permlocation'}; + $ri{'location'} = ( $shelflocations->{$permshelfcode} ne '' ) ? $shelflocations->{$permshelfcode} : ( $permshelfcode ) ? $permshelfcode : undef; + $ri{'location'} .= ( ( $shelflocations->{$shelfcode} ne '' ) && ( $shelfcode ne $permshelfcode ) ) ? ' (' . $shelflocations->{$shelfcode} . ')' : ( ( $shelfcode ) && ( $shelfcode ne $permshelfcode ) ) ? ' (' . $shelfcode . ')' : undef; -- You are receiving this mail because: You are watching all bug changes.