http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2426 --- Comment #5 from Galen Charlton <galen.charlton@liblime.com> 2009-05-29 19:07:58 --- [13:13] <atz> gmcharlt: would appreciate feedback on bug#2426 [13:15] <atz> basically the IndyBranches implementation for controlling "Set branch" is fractured [13:16] <atz> and whatever fix I implement will reveal that... i.e. "yuo broke it!" [13:29] <gmcharlt> atz: some thoughts about it [13:29] <gmcharlt> 1. this is a good candidate for AJAX - no need to redirect at all [13:30] <atz> good thought [13:30] <gmcharlt> 2. catalogue->setbranch is OK as a granular permission [13:30] <gmcharlt> 3. indybranches is orthogonal to user permissions in this case, but that's OK for now [13:31] <gmcharlt> although potentially it could implement the restriction by overriding the value of a particular users setbranch permission [13:31] <atz> yeah, system groups will inevitably come into play here [13:34] <atz> for (3) are you saying it is OK to leave the manage permission in play for this weird indy branches exception case? [13:35] <atz> that would make the bug an INVALID [13:35] <gmcharlt> no, the permission should go away [13:35] <atz> so basically we'll be showing the link to indy branches users, even if they can't use it [13:35] <gmcharlt> and be replaced a test on the indybranch syspref and whether or not the user is a superlibrarian or has cataloge->changebranch [13:36] <atz> superlibrarian gets all user permissions already [13:37] <gmcharlt> true [13:40] <atz> gmcharlt: what do you think about a psuedo permission for setbranch? i.e., granular permissions would populate it from catalogue:setbranch but it would still exist for non-granular [13:40] <atz> ? [13:40] <gmcharlt> sounds reasonable [13:42] <atz> i'll give it a try -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.