[Bug 27493] New: Improve structure and style of checkbox columns in tables the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Bug ID: 27493 Summary: Improve structure and style of checkbox columns in tables the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org The width of the checkbox column in most tables in the OPAC is dynamically assigned and as such is often very wide for it's minimal content. I propose to set these fields to a fixed width as we know how large a checkbox is likely to be. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115416&action=edit Bug 27493: Set column wifth for checkbox only columns This patch updates the global OPAC css such that selectcol type columns in tables are fixed width at 1ch to ensure these columns do not get unneccessarily wide. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Test plan PAGES: opac-basket, opac-messaging, opac-results, opac-search-history, opac-suggestions and opac-tags. 1/ Notice that the column containing a checkbox on each of the above pages is of a mised width, often much larger than required 2/ Apply the patch and rebuild the css file as described above 3/ Notices that the column containing a checkbox on each fo the above pages is now of a standard, sensible, width. 4/ Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27440 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve structure and style |Improve structure and style |of checkbox columns in |of checkbox columns in |tables the OPAC |tables on the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve structure and style |Improve structure and style |of checkbox columns in |of checkbox columns in |tables on the OPAC |tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115428&action=edit Bug 27493: Add styling for hidden columns I'm sure adding a 'hidden' class to a table column used to remove it from display entirely.. seems that's no longer the case so we add the CSS back in here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115416|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115753&action=edit Bug 27493: Set column wifth for checkbox only columns This patch updates the global OPAC css such that selectcol type columns in tables are fixed width at 1ch to ensure these columns do not get unneccessarily wide. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Test plan PAGES: opac-basket, opac-messaging, opac-results, opac-search-history, opac-suggestions and opac-tags. 1/ Notice that the column containing a checkbox on each of the above pages is of a mised width, often much larger than required 2/ Apply the patch and rebuild the css file as described above 3/ Notices that the column containing a checkbox on each fo the above pages is now of a standard, sensible, width. 4/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115428|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115754&action=edit Bug 27493: Add styling for hidden columns I'm sure adding a 'hidden' class to a table column used to remove it from display entirely.. seems that's no longer the case so we add the CSS back in here. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #5 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described in all locations. Whilst testing, I noticed an issue on the tooltip for opac-messaging.pl so I've logged that as another bug. Bug 27543. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115754|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115847&action=edit Bug 27493: Add styling for hidden columns I'm sure adding a 'hidden' class to a table column used to remove it from display entirely.. seems that's no longer the case so we add the CSS back in here. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115753|0 |1 is obsolete| | Attachment #115847|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115922&action=edit Bug 27493: Set column width for checkbox only columns This patch updates the global OPAC css such that selectcol type columns in tables are fixed width at 1ch to ensure these columns do not get unneccessarily wide. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Test plan PAGES: opac-basket, opac-messaging, opac-results, opac-search-history, opac-suggestions and opac-tags. 1/ Notice that the column containing a checkbox on each of the above pages is of a mised width, often much larger than required 2/ Apply the patch and rebuild the css file as described above 3/ Notices that the column containing a checkbox on each fo the above pages is now of a standard, sensible, width. 4/ Signoff Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115923&action=edit Bug 27493: Add styling for hidden columns I'm sure adding a 'hidden' class to a table column used to remove it from display entirely.. seems that's no longer the case so we add the CSS back in here. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- - Fixed typo in first patch wifth vs width - Added missing signed-off-by line from QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I don't think we need the 2 classes, "select" and "selectcol". I didn't find .select in the .scss files, and the only places it was used was opac-results.tt, where it has been removed. Owen, can you take a look please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115932&action=edit Bug 27493: (follow-up) Remove redundant class This patch modifies the templates so that instances of "class='select selectcol' are replaced with "class='selectcol'". I could find no instances of the "select" class being used in CSS or JS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31182 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31182 [Bug 31182] Result search number missing in OPAC -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org