[Bug 42169] New: Unify patron category change popups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 Bug ID: 42169 Summary: Unify patron category change popups Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com On members/memberentry.pl if you change a patron category you will get 2 pop ups, one after the other. The first is a JS alert asking if you want to update patron messaging settings. The 2nd is a modal popup aking if you want to update the patron date expiry. This isn't very good UX. It would be nice if these could be unified into a single popup or at the very least, be similar types of popups. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32581 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32581 [Bug 32581] Update dateexpiry on categorycode change -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 196159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196159&action=edit Bug 42169: Unify patron category change popups To test: 1. APPLY PATCH, restart_all 2. Go to Administration > Patron categories 3. Edit or create some categories with different Enrollment periods and messaaging preferences 4. Find or create some patrons in different categories than the ones setup in step 3. 5. Edit the patron and change the category to one setup in step 3. 6. Notice a popup asking about both patron expiratoin date and messaging preferences, both should be checked by default. 7. Confirm and check that both the patron expiration date and messaging preferences updated to the category defaults. 8. Try again, checking only one of the 2 checkboxes. Make sure things updated correctly. Try this with both checkboxes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42112 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42112 [Bug 42112] Add option for prompting for renewal, always renewing, or never renewing borrower when changing category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- What is dirty here is that I've introduced some JS to messaging-preference-form.js that is not related to messaging prefs but to expiry date. Happy for suggestions on a better way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jvinke@austinseminary.edu --- Comment #3 from John Vinke <jvinke@austinseminary.edu> --- This might be an edge case so I'm not sure what the correct course of action is here. I tested it on editing an existing patron and it worked, but it seems to not apply the changes on the Add patron form despite presenting the dialogue option. What I mean is: 1. Create 2 new patron categories with specific enrollment periods and messaging preferences. 2. Click create new patron, select the first patron type. 3. Fill out the form, but then change the patron category to the second type while editing. 4. Select one or more of the checkboxes on the dialogue. 5. Note that changes did not take effect. This seems to be because there is no existing value in expiry date. If I add something to that, and then do the steps outlined above it works like it does on the edit patron screen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to John Vinke from comment #3)
This might be an edge case so I'm not sure what the correct course of action is here. I tested it on editing an existing patron and it worked, but it seems to not apply the changes on the Add patron form despite presenting the dialogue option.
What I mean is:
1. Create 2 new patron categories with specific enrollment periods and messaging preferences. 2. Click create new patron, select the first patron type. 3. Fill out the form, but then change the patron category to the second type while editing. 4. Select one or more of the checkboxes on the dialogue. 5. Note that changes did not take effect.
This seems to be because there is no existing value in expiry date. If I add something to that, and then do the steps outlined above it works like it does on the edit patron screen.
Ah yes, that is reason enough to FQA. I will fix that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 --- Comment #5 from John Vinke <jvinke@austinseminary.edu> --- BTW - I poked around a bit more and the expiry date is a red herring. It does behave differently on the add_form and the edit_form though. Clicking on fields on the add_form before switching the patron category does seem to change the results though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 196354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196354&action=edit Bug 42169: (follow-up) When changing to a new category set messaging prefs dirty Patch from commit 6fc79c2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196159|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196354|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 --- Comment #7 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 196374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196374&action=edit Bug 42169: Unify patron category change popups To test: 1. APPLY PATCH, restart_all 2. Go to Administration > Patron categories 3. Edit or create some categories with different Enrollment periods and messaaging preferences 4. Find or create some patrons in different categories than the ones setup in step 3. 5. Edit the patron and change the category to one setup in step 3. 6. Notice a popup asking about both patron expiratoin date and messaging preferences, both should be checked by default. 7. Confirm and check that both the patron expiration date and messaging preferences updated to the category defaults. 8. Try again, checking only one of the 2 checkboxes. Make sure things updated correctly. Try this with both checkboxes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 --- Comment #8 from John Vinke <jvinke@austinseminary.edu> --- Created attachment 196375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196375&action=edit Bug 42169: (follow-up) When changing to a new category set messaging prefs dirty Patch from commit 684172e -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196374|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196375|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 --- Comment #9 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 198199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198199&action=edit Bug 42169: Unify patron category change popups To test: 1. APPLY PATCH, restart_all 2. Go to Administration > Patron categories 3. Edit or create some categories with different Enrollment periods and messaaging preferences 4. Find or create some patrons in different categories than the ones setup in step 3. 5. Edit the patron and change the category to one setup in step 3. 6. Notice a popup asking about both patron expiratoin date and messaging preferences, both should be checked by default. 7. Confirm and check that both the patron expiration date and messaging preferences updated to the category defaults. 8. Try again, checking only one of the 2 checkboxes. Make sure things updated correctly. Try this with both checkboxes. Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 --- Comment #10 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 198200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198200&action=edit Bug 42169: (follow-up) When changing to a new category set messaging prefs dirty Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198199|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198200|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 --- Comment #11 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 198201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198201&action=edit Bug 42169: Unify patron category change popups To test: 1. APPLY PATCH, restart_all 2. Go to Administration > Patron categories 3. Edit or create some categories with different Enrollment periods and messaaging preferences 4. Find or create some patrons in different categories than the ones setup in step 3. 5. Edit the patron and change the category to one setup in step 3. 6. Notice a popup asking about both patron expiratoin date and messaging preferences, both should be checked by default. 7. Confirm and check that both the patron expiration date and messaging preferences updated to the category defaults. 8. Try again, checking only one of the 2 checkboxes. Make sure things updated correctly. Try this with both checkboxes. Signed-off-by: John Vinke <jvinke@austinseminary.edu> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 --- Comment #12 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 198202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198202&action=edit Bug 42169: (follow-up) When changing to a new category set messaging prefs dirty Signed-off-by: John Vinke <jvinke@austinseminary.edu> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 --- Comment #14 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42169 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43005 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43005 [Bug 43005] Regression: Changing category from details page section doesn't trigger expiration update -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org