https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 mreid <mreid@batestech.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mreid@batestech.edu -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- Yep, we're running into this too. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 susan.reynolds@marionfl.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |susan.reynolds@marionfl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Seems relevant here that the text on the IndependentBranches syspref also has the class 'text-danger' and is also showing this low contrast color. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #5 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(... git bz apply 39274 Bug 39274 - Non public notes are low contrast in the issues table - Previous checkouts 179389 - Bug 39274: Non public notes are low contrast in the issues table - Previous checkouts Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 39274: Non public notes are low contrast in the issues table - Previous checkouts Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss M koha-tmpl/intranet-tmpl/prog/en/modules/about.tt M koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt M koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/about.tt Auto-merging koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss error: Failed to merge in the changes. Patch failed at 0001 Bug 39274: Non public notes are low contrast in the issues table - Previous checkouts Testing notes (using KTD): 1. For claim returned testing: - Set a value for the ClaimReturnedLostValue system preference - On the patron's check out section, change the columns so that the "Return claimed" one is selected, then the "Claim returned" button is shown 2. Tools home page - tags: - To show the badge for tags requring moderation, set the TagsModeration system preference to "Require" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179389|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179448&action=edit Bug 39274: Non public notes are low contrast in the issues table - Previous checkouts This patch reflects some rethinking on my part about how the Bootstrap color classes are meant to be used, and makes some changes which I hope will be more consistent with the Bootstrap 5 documentation while keeping our interface usable. The main difference is in the use of the classes "text-bg-*" and "bg-*-subtle." For example the class "bg-info-subtle" will give an element a subtle colored background. "text-bg-info" will have a more saturated background color. The "text-" part of the class is a reference to the fact that elements with that category of classes will have text color which adapts to provide correct contrast. This patch also makes a minor adjustment to the color used for "warning" type elements (e.g. <div class="alert alert-warning">. I've adjusted the color slightly in order to differentiate it from the "primary" class color we use for submit buttons. To test, apply the patch and rebuil the staff interface CSS. Clear your browser cache if necessary. Checkouts: 1. Have an item with a non-public note. 2. Check it out, it looks fine while under "Today's issues" 3. Set the issuedate to some time in the past `update issues set issuedate = '2025-03-04 15:58:46';` 4. The non-public note should appear in legible red. Return claims: 1. The "Claims" tab on the patron detail and checkout pages already used the "text-bg-*" classes but the "-success" class didn't work well with the tab background color so I removed it. I notice there is a bug in the way the classes change as the tab is activated, but that will have to be dealt with on another bug. Bibliographic details: 1. Place at least one hold and at least one article request on a title. 2. The detail view should show "Holds: 1", and "Article requests: 1" with the numbers in legible Bootstrap badges. Holds: 1. Perform a catalog search which will return multiple titles. 2. Select multiple titles and click "Place hold." 3. Select a patron to place a hold for. 4. Confirm the holds by clicking "Place hold." 5. The holds should now be shown under the heading "Existing holds," with Bootstrap badgets showing the hold count on each. Patrons requesting modification: 1. Submit an update to a patron record via the OPAC. 2. On the patrons home page in the staff interface there should be a "Patrons requesting modifications" link at the top, with a count of pending modifications shown in a Bootstrap badge. Check-ins: 1. Check in an item from a patron account with multiple other checkouts. 2. In the table of checked-in items the patron's remaining checkout count should be shown in a Bootstrap badge. SMTP servers: 1. Go to Administration -> SMTP Servers. 2. Edit at least one server so that debug mode is enabled and it is marked as a default server. 3. In the view of servers, the debug mode and default status should be shown in Bootstrap badges. Plugins: 1. Go to Administration -> Plugins. 2. Upload a plugin if necessary, and check the list of installed plugins when the plugin is disabled and when it is enabled. In both cases the status should appear in a Bootstrap badge. About page: 1. Go to the About page. 2. Under the "Server information" tab, the status of Memcached and Message broker should be shown with a background color--pale blue for okay statuses. Tools home page: 1. If necessary, go to the OPAC and submit at least one comment on a bibliographic record and tag at least one record. 2. In the staff interface, on the Tools home page, the number of tags pending approval and the number of comments awaiting moderation should show in Bootstrap badges. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179448|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 179695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179695&action=edit Bug 39274: Non public notes are low contrast in the issues table - Previous checkouts This patch reflects some rethinking on my part about how the Bootstrap color classes are meant to be used, and makes some changes which I hope will be more consistent with the Bootstrap 5 documentation while keeping our interface usable. The main difference is in the use of the classes "text-bg-*" and "bg-*-subtle." For example the class "bg-info-subtle" will give an element a subtle colored background. "text-bg-info" will have a more saturated background color. The "text-" part of the class is a reference to the fact that elements with that category of classes will have text color which adapts to provide correct contrast. This patch also makes a minor adjustment to the color used for "warning" type elements (e.g. <div class="alert alert-warning">. I've adjusted the color slightly in order to differentiate it from the "primary" class color we use for submit buttons. To test, apply the patch and rebuil the staff interface CSS. Clear your browser cache if necessary. Checkouts: 1. Have an item with a non-public note. 2. Check it out, it looks fine while under "Today's issues" 3. Set the issuedate to some time in the past `update issues set issuedate = '2025-03-04 15:58:46';` 4. The non-public note should appear in legible red. Return claims: 1. The "Claims" tab on the patron detail and checkout pages already used the "text-bg-*" classes but the "-success" class didn't work well with the tab background color so I removed it. I notice there is a bug in the way the classes change as the tab is activated, but that will have to be dealt with on another bug. Bibliographic details: 1. Place at least one hold and at least one article request on a title. 2. The detail view should show "Holds: 1", and "Article requests: 1" with the numbers in legible Bootstrap badges. Holds: 1. Perform a catalog search which will return multiple titles. 2. Select multiple titles and click "Place hold." 3. Select a patron to place a hold for. 4. Confirm the holds by clicking "Place hold." 5. The holds should now be shown under the heading "Existing holds," with Bootstrap badgets showing the hold count on each. Patrons requesting modification: 1. Submit an update to a patron record via the OPAC. 2. On the patrons home page in the staff interface there should be a "Patrons requesting modifications" link at the top, with a count of pending modifications shown in a Bootstrap badge. Check-ins: 1. Check in an item from a patron account with multiple other checkouts. 2. In the table of checked-in items the patron's remaining checkout count should be shown in a Bootstrap badge. SMTP servers: 1. Go to Administration -> SMTP Servers. 2. Edit at least one server so that debug mode is enabled and it is marked as a default server. 3. In the view of servers, the debug mode and default status should be shown in Bootstrap badges. Plugins: 1. Go to Administration -> Plugins. 2. Upload a plugin if necessary, and check the list of installed plugins when the plugin is disabled and when it is enabled. In both cases the status should appear in a Bootstrap badge. About page: 1. Go to the About page. 2. Under the "Server information" tab, the status of Memcached and Message broker should be shown with a background color--pale blue for okay statuses. Tools home page: 1. If necessary, go to the OPAC and submit at least one comment on a bibliographic record and tag at least one record. 2. In the staff interface, on the Tools home page, the number of tags pending approval and the number of comments awaiting moderation should show in Bootstrap badges. Sponsored-by: Athens County Public Libraries Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39597 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39597 [Bug 39597] When cancelling multiple holds on a bib record cancel_hold_alert has very low contrast -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|HTML text-bg-* elements are |HTML bg-* elements are low |low contrast |contrast -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39000 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 186268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186268&action=edit Bug 39274: [24.11.x] Non public notes are low contrast in the issues table - Previous checkouts This patch reflects some rethinking on my part about how the Bootstrap color classes are meant to be used, and makes some changes which I hope will be more consistent with the Bootstrap 5 documentation while keeping our interface usable. The main difference is in the use of the classes "text-bg-*" and "bg-*-subtle." For example the class "bg-info-subtle" will give an element a subtle colored background. "text-bg-info" will have a more saturated background color. The "text-" part of the class is a reference to the fact that elements with that category of classes will have text color which adapts to provide correct contrast. This patch also makes a minor adjustment to the color used for "warning" type elements (e.g. <div class="alert alert-warning">. I've adjusted the color slightly in order to differentiate it from the "primary" class color we use for submit buttons. To test, apply the patch and rebuil the staff interface CSS. Clear your browser cache if necessary. Checkouts: 1. Have an item with a non-public note. 2. Check it out, it looks fine while under "Today's issues" 3. Set the issuedate to some time in the past `update issues set issuedate = '2025-03-04 15:58:46';` 4. The non-public note should appear in legible red. Return claims: 1. The "Claims" tab on the patron detail and checkout pages already used the "text-bg-*" classes but the "-success" class didn't work well with the tab background color so I removed it. I notice there is a bug in the way the classes change as the tab is activated, but that will have to be dealt with on another bug. Bibliographic details: 1. Place at least one hold and at least one article request on a title. 2. The detail view should show "Holds: 1", and "Article requests: 1" with the numbers in legible Bootstrap badges. Holds: 1. Perform a catalog search which will return multiple titles. 2. Select multiple titles and click "Place hold." 3. Select a patron to place a hold for. 4. Confirm the holds by clicking "Place hold." 5. The holds should now be shown under the heading "Existing holds," with Bootstrap badgets showing the hold count on each. Patrons requesting modification: 1. Submit an update to a patron record via the OPAC. 2. On the patrons home page in the staff interface there should be a "Patrons requesting modifications" link at the top, with a count of pending modifications shown in a Bootstrap badge. Check-ins: 1. Check in an item from a patron account with multiple other checkouts. 2. In the table of checked-in items the patron's remaining checkout count should be shown in a Bootstrap badge. SMTP servers: 1. Go to Administration -> SMTP Servers. 2. Edit at least one server so that debug mode is enabled and it is marked as a default server. 3. In the view of servers, the debug mode and default status should be shown in Bootstrap badges. Plugins: 1. Go to Administration -> Plugins. 2. Upload a plugin if necessary, and check the list of installed plugins when the plugin is disabled and when it is enabled. In both cases the status should appear in a Bootstrap badge. About page: 1. Go to the About page. 2. Under the "Server information" tab, the status of Memcached and Message broker should be shown with a background color--pale blue for okay statuses. Tools home page: 1. If necessary, go to the OPAC and submit at least one comment on a bibliographic record and tag at least one record. 2. In the staff interface, on the Tools home page, the number of tags pending approval and the number of comments awaiting moderation should show in Bootstrap badges. Sponsored-by: Athens County Public Libraries Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #14 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.