[Bug 38164] New: Translation process in stable releases is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Bug ID: 38164 Summary: Translation process in stable releases is broken Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Keywords: RM_priority Severity: blocker Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: f.demians@tamil.fr, jonathan.druart@gmail.com, mtj@kohaaloha.com, tomascohen@gmail.com As discussed on bug 37303 we do now require yarn for running the translation scripts because of po2json. We need to fix this urgently as it means that production installations updating (and with security releases they should) can no longer install and update languages. We already had several reports in Mattermost and on the mailing list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Which versions will be affected by this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- (In reply to Magnus Enger from comment #1)
Which versions will be affected by this?
Ah, probably the ones that have bug 37303? So 24.11.00 and 24.05.04? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate, | |rel_24_11_candidate --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Magnus Enger from comment #2)
(In reply to Magnus Enger from comment #1)
Which versions will be affected by this?
Ah, probably the ones that have bug 37303? So 24.11.00 and 24.05.04?
That should be correct. I am setting keywords. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 --- Comment #4 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172714&action=edit Bug 38164: Revert "Bug 37303: Replace po2json with a JS version" This reverts commit 4eb981635453871fa2a33396391f3f75a6baa8b1. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 --- Comment #5 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172715&action=edit Bug 38164: Skip fuzzy translations This patch was envisioned by Julian Maurice. Test plan: 1. Go to `misc/translator/po` 2. es-ES-messages-js.po 3. Mark "Edit" string as fuzzy (around line 48). It should look like: ``` msgid "Edit" msgstr "Editar" ``` 4. Edit ./intranet-main.tt and add the following lines at the bottom, inside the `$(document).ready` block: ```javascript console.log(_("Edit")); console.log(__("Edit")); ``` 5. Install the templates k$ koha-translate --install es-ES --dev kohadev && restart_all 6. Enable *es-ES* by searching for `language` in the sysprefs and switch to it for the staff interface. 7. Go to the Koha home page, open the browser console => FAIL: Notice that the second log in the console is displaying the fuzzy string (i.e. is being translated when it shouldn't) 8. Apply this patch 9. Re-install the translated templates: k$ koha-translate --update es-ES --dev kohadev && restart_all 10. Repeat 7 => SUCCESS: With this patch applied both logs show the English version of the string. 11. Remove the fuzzy flag on `es-ES-messages-js.po` 12. Repeat 9 and 10 => SUCCESS: The results are similar to step 7, but in this case they are expected as the string is not marked fuzzy. 13. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172714|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 172756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172756&action=edit Bug 38164: Revert "Bug 37303: Replace po2json with a JS version" This reverts commit 4eb981635453871fa2a33396391f3f75a6baa8b1. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172715|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 172757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172757&action=edit Bug 38164: Skip fuzzy translations This patch was envisioned by Julian Maurice. Test plan: 1. Go to `misc/translator/po` 2. es-ES-messages-js.po 3. Mark "Edit" string as fuzzy (around line 48). It should look like: ``` msgid "Edit" msgstr "Editar" ``` 4. Edit ./intranet-main.tt and add the following lines at the bottom, inside the `$(document).ready` block: ```javascript console.log(_("Edit")); console.log(__("Edit")); ``` 5. Install the templates k$ koha-translate --install es-ES --dev kohadev && restart_all 6. Enable *es-ES* by searching for `language` in the sysprefs and switch to it for the staff interface. 7. Go to the Koha home page, open the browser console => FAIL: Notice that the second log in the console is displaying the fuzzy string (i.e. is being translated when it shouldn't) 8. Apply this patch 9. Re-install the translated templates: k$ koha-translate --update es-ES --dev kohadev && restart_all 10. Repeat 7 => SUCCESS: With this patch applied both logs show the English version of the string. 11. Remove the fuzzy flag on `es-ES-messages-js.po` 12. Repeat 9 and 10 => SUCCESS: The results are similar to step 7, but in this case they are expected as the string is not marked fuzzy. 13. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172756|0 |1 is obsolete| | --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 172758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172758&action=edit Bug 38164: Revert "Bug 37303: Replace po2json with a JS version" This reverts commit 4eb981635453871fa2a33396391f3f75a6baa8b1. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172757|0 |1 is obsolete| | --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 172759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172759&action=edit Bug 38164: Skip fuzzy translations This patch was envisioned by Julian Maurice. Test plan: 0. Apply the 1st patch (the revert) 1. Go to `misc/translator/po` 2. es-ES-messages-js.po 3. Mark "Edit" string as fuzzy (around line 48). It should look like: ``` msgid "Edit" msgstr "Editar" ``` 4. Edit ./intranet-main.tt and add the following lines at the bottom, inside the `$(document).ready` block: ```javascript console.log(_("Edit")); console.log(__("Edit")); ``` 5. Install the templates k$ koha-translate --install es-ES --dev kohadev && restart_all 6. Enable *es-ES* by searching for `language` in the sysprefs and switch to it for the staff interface. 7. Go to the Koha home page, open the browser console => FAIL: Notice that the second log in the console is displaying the fuzzy string (i.e. is being translated when it shouldn't) 8. Apply this patch 9. Re-install the translated templates: k$ koha-translate --update es-ES --dev kohadev && restart_all 10. Repeat 7 => SUCCESS: With this patch applied both logs show the English version of the string. 11. Remove the fuzzy flag on `es-ES-messages-js.po` 12. Repeat 9 and 10 => SUCCESS: The results are similar to step 7, but in this case they are expected as the string is not marked fuzzy. 13. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172758|0 |1 is obsolete| | --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 172760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172760&action=edit Bug 38164: Revert "Bug 37303: Replace po2json with a JS version" This reverts commit 4eb981635453871fa2a33396391f3f75a6baa8b1. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172759|0 |1 is obsolete| | --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 172761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172761&action=edit Bug 38164: Skip fuzzy translations This patch was envisioned by Julian Maurice. Test plan: 0. Apply the 1st patch (the revert) 1. Go to `misc/translator/po` 2. es-ES-messages-js.po 3. Mark "Edit" string as fuzzy (around line 48). It should look like: ``` msgid "Edit" msgstr "Editar" ``` 4. Edit ./intranet-main.tt and add the following lines at the bottom, inside the `$(document).ready` block: ```javascript console.log(_("Edit")); console.log(__("Edit")); ``` 5. Install the templates k$ koha-translate --install es-ES --dev kohadev && restart_all 6. Enable *es-ES* by searching for `language` in the sysprefs and switch to it for the staff interface. 7. Go to the Koha home page, open the browser console => FAIL: Notice that the second log in the console is displaying the fuzzy string (i.e. is being translated when it shouldn't) 8. Apply this patch 9. Re-install the translated templates: k$ koha-translate --update es-ES --dev kohadev && restart_all 10. Repeat 7 => SUCCESS: With this patch applied both logs show the English version of the string. 11. Remove the fuzzy flag on `es-ES-messages-js.po` 12. Repeat 9 and 10 => SUCCESS: The results are similar to step 7, but in this case they are expected as the string is not marked fuzzy. 13. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164
Victor Grousset/tuxayo <victor@tuxayo.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |victor@tuxayo.net
--- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Testing notes: 1st apply the reverting patch.
> 7.
I get
- Editar
- Editar
ok, that's the bug
> 10. «With this patch applied both logs show the
> English version of the string.»
I get
- Editar
- Edit
????? :o
> 12.
I get
- Editar
- Editar
ok
I looked at the test plan of bug 37303 and it says «second log in the console
is displaying the fuzzy string» 😵💫 😵💫 😵💫 😵💫
(the order of _() and __() was the same)
It seems the thing is working and there is uncertainly of behavior of __() and
_() regarding which is/are being affected by the initial issue.
Anyway, it's the same output on main with po2json JS installed.
As far as not needing yarn on production it works :)
(there is still something suspicious about _() outputting fuzzy strings)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks Aleisha for the signoff, I merged both. As for QA, the yarn.lock file isn't reverted or updated. So we have po2json not in package.json anymore but still in the yarn.lock. And po2json isn't listed as a dependency of anything else. So it's almost certain it's an issue. But xt/verify-yarnlock.t is passing ?!?!?!?!?!?!?! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 172762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172762&action=edit Bug 38164: Update yarn.lock for removal of po2json.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Apparently to sync yarn.lock with package.json on can just run `yarn` In our setup in KTD that's: sudo yarn --modules-folder ../node_modules/ (maybe there is a better way to currently use yarn) KTD start works. Translating work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37303 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 [Bug 37303] Fuzzy translations displayed on the UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #12)
(there is still something suspicious about _() outputting fuzzy strings)
_("") picks from -staff-prog.po, not -messages-js.po -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #14)
Created attachment 172762 [details] [review] Bug 38164: Update yarn.lock for removal of po2json.js
Skipped this patch, this is a task for RM/RMaints. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172760|0 |1 is obsolete| | Attachment #172761|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172766&action=edit Bug 38164: Revert "Bug 37303: Replace po2json with a JS version" This reverts commit 4eb981635453871fa2a33396391f3f75a6baa8b1. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172767&action=edit Bug 38164: Skip fuzzy translations This patch was envisioned by Julian Maurice. Test plan: 0. Apply the 1st patch (the revert) 1. Go to `misc/translator/po` 2. es-ES-messages-js.po 3. Mark "Edit" string as fuzzy (around line 48). It should look like: ``` msgid "Edit" msgstr "Editar" ``` 4. Edit ./intranet-main.tt and add the following lines at the bottom, inside the `$(document).ready` block: ```javascript console.log(_("Edit")); console.log(__("Edit")); ``` 5. Install the templates k$ koha-translate --install es-ES --dev kohadev && restart_all 6. Enable *es-ES* by searching for `language` in the sysprefs and switch to it for the staff interface. 7. Go to the Koha home page, open the browser console => FAIL: Notice that the second log in the console is displaying the fuzzy string (i.e. is being translated when it shouldn't) 8. Apply this patch 9. Re-install the translated templates: k$ koha-translate --update es-ES --dev kohadev && restart_all 10. Repeat 7 => SUCCESS: With this patch applied both logs show the English version of the string. 11. Remove the fuzzy flag on `es-ES-messages-js.po` 12. Repeat 9 and 10 => SUCCESS: The results are similar to step 7, but in this case they are expected as the string is not marked fuzzy. 13. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- IMO we are only postponing the problem to the next time we will need yarn. It would be better to try with alternative approaches. But I do understand that we want to provide a quick solution now, however I also know that we won't deal with the yarn issue as we are lacking manpower and so will hit this one again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- A note regarding node-po2json deb package: we don't want it I think, see bug 37303 comment 21 => we don't want to be stuck with v0.4.5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 --- Comment #22 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #20)
IMO we are only postponing the problem to the next time we will need yarn.
I think this patch should target 24.05. And we should find a solution for 24.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #22)
(In reply to Jonathan Druart from comment #20)
IMO we are only postponing the problem to the next time we will need yarn.
I think this patch should target 24.05. And we should find a solution for 24.11
That means I would not push it to main, but the RMaints pick it up directly from here. Correct? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 --- Comment #24 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #23)
(In reply to Tomás Cohen Arazi (tcohen) from comment #22)
(In reply to Jonathan Druart from comment #20)
IMO we are only postponing the problem to the next time we will need yarn.
I think this patch should target 24.05. And we should find a solution for 24.11
That means I would not push it to main, but the RMaints pick it up directly from here. Correct?
Exactly. This was a stopgap for stable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translation process in |[24.05] Translation process |stable releases is broken |in stable releases is | |broken --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Handing over to @ping Lucas then! Should we open a separate bug for the 24.11 fix? We need to keep sight of it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Main |24.05 Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38179 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Jonathan Druart from comment #17)
(In reply to Victor Grousset/tuxayo from comment #14)
Created attachment 172762 [details] [review] [review] Bug 38164: Update yarn.lock for removal of po2json.js
Skipped this patch, this is a task for RM/RMaints.
Right, that makes sense especially with backports and changes due to yarn versions. Like SCSS and DBIC. Not a problem then. Still something to keep in mind because having to sync yarn.lock after package.json changes isn't mentioned. https://wiki.koha-community.org/wiki/Release_management https://wiki.koha-community.org/wiki/Release_maintenance Especially since xt/verify-yarnlock.t doesn't cover this case (opened Bug 38170 for that) ----- (In reply to Tomás Cohen Arazi (tcohen) from comment #22)
(In reply to Jonathan Druart from comment #20)
IMO we are only postponing the problem to the next time we will need yarn.
I think this patch should target 24.05. And we should find a solution for 24.11
Are we talking about finding a solution about fuzzy strings or "the next time we will need yarn" as in the next time a node package would be of use for us in production? It seems you both weren't in the same issue. As for the fuzzy strings thing, the fixed po2json.pl might be enough. VS po2json.js which has a similar amount of code as our .pl but even 1.0.0-beta-3 has dependencies on fixed versions https://npmgraph.js.org/?q=po2json%401.0.0-beta-3 po2json.pl has also dependencies on stuff that isn't on fixed version but that doesn't look much maintained: https://metacpan.org/pod/JSON https://metacpan.org/pod/Locale::PO Maybe it's ok, it's just interfaces for reasonably simple file formats. Anyway both are not in a great shape themselves and the dependencies they use (.pl => the dependencies themselves, .js => the fact that they are fixed). The biggest difference is po2json.pl can be maintained by us without having to fork it (it already is) and is easier to integrate into Koha (it already is) than a node lib. If we find a non trivial advantage for one, that could easily supersede the above IHMO. Especially if we are sure we will end up having to use node libs in production. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 --- Comment #27 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #20)
IMO we are only postponing the problem to the next time we will need yarn.
It would be better to try with alternative approaches. But I do understand that we want to provide a quick solution now, however I also know that we won't deal with the yarn issue as we are lacking manpower and so will hit this one again.
We shouldn't need "yarn" with a deployed/installed Koha. In the case of bug 37303, "yarn run po2json" wouldn't work anyway, even if "yarn" were installed, since po2json isn't installed in the deployed/installed Koha environment. Plus "yarn run po2json" is just running the "bin/po2json" file which is just being executed using node, which is also not available with a deployed/installed Koha. So at the end of the day what we're really trying to do is run "node <path_to_po2json_proj>/bin/po2json". When we're developing, we need to be thinking more about the deployment environment and not just the development environment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 --- Comment #28 from David Cook <dcook@prosentient.com.au> --- At this point, I don't know if the Javascript "po2json" is our only option or not. If it is, then the question should be... do we make NodeJS an additional prod (not just dev) dependency of Koha? (Keeping in mind we already have a million dependencies.) For what it's worth, I have a small PHP project where I have added NodeJS as a dependency, because there is some functionality that I can only access using Nodejs. So I do understand the merit of doing that. But... if we did do that... we'd need to think a lot about how we structure the source code. We'd be supporting another complete ecosystem in prod. That's big. If we do this, I'd recommend that we use our existing package.json to *bundle po2json* (or our own customized po2json) into a single script, so that in prod we'd just have 1 file to manage. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 --- Comment #29 from David Cook <dcook@prosentient.com.au> --- Tomas has pointed out bug 38179 to me, so I'll move my discussion over to there, and not clog up this backporting work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[24.05] Translation process |Translation process is |in stable releases is |broken |broken | --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Udpated the bug slightly. We decided on bug 38179 to also use this fix for main. It is also an URGENT bug fix for 24.05, but not below. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.05 released in| | --- Comment #32 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #33 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 37303 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Bug 38164 depends on bug 37303, which changed state. Bug 37303 Summary: Fuzzy translations displayed on the UI https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |Pushed to stable --- Comment #34 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Fridolin Somers from comment #33)
Depends on Bug 37303 not in 23.11.x
You need to pick the second patch only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |wainuiwitikapark@catalyst.n | |et.nz Resolution|--- |FIXED --- Comment #35 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org