[Bug 18528] New: Patron card creator: switch form fields for card height and card width
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 Bug ID: 18528 Summary: Patron card creator: switch form fields for card height and card width Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org The form to create or edit a card template has a confusing sequence of fields for page and card height and width: Page width - Page height - Card height - Card width Switch Card height and Card width to make it more intuitive. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron card creator: switch |Patron card creator |form fields for card height |template: switch form |and card width |fields for card height and | |card width -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 63014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63014&action=edit Confusing fields for height and width -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18465 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 63017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63017&action=edit Bug 18528: Patron card creator template: switch form fields for card height and card width This patch changes the sequnce of form fields for card height and card width. To test: - Apply patch - Edit or create a patron card template - Verify that the fields display in sequence Page height - Page width -Card height - Card width -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|cnighswonger@foundations.ed |veron@veron.ch |u | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63017|0 |1 is obsolete| | --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 63262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63262&action=edit Bug 18528: Patron card creator template: switch form fields for card height and card width This patch changes the sequnce of form fields for card height and card width. To test: - Apply patch - Edit or create a patron card template - Verify that the fields display in sequence Page height - Page width -Card height - Card width Followed test plan, worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 --- Comment #4 from Marc Véron <veron@veron.ch> --- Still applies on current master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 --- Comment #5 from Marc Véron <veron@veron.ch> --- Still applies on current master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63262|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 67664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67664&action=edit Bug 18528: Patron card creator template: switch form fields for card height and card width This patch changes the sequnce of form fields for card height and card width. To test: - Apply patch - Edit or create a patron card template - Verify that the fields display in sequence Page height - Page width -Card height - Card width Followed test plan, worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org