[Bug 22359] New: Improve usability of 'change calculation' (bug 11373)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Bug ID: 22359 Summary: Improve usability of 'change calculation' (bug 11373) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 11373 Target Milestone: --- There has been some discussion about the usability of the change calcualation feature from bug 11373. Adding a bug to collect comments and suggestions in a central spot in hope that we will be able to improve things prior to the 19.05 release :) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 [Bug 11373] Add "change calculation" feature to the fine payment forms -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'll start: 1) I am not a fan of the extra step the modal adds: - you click 'confirm' - modal appears to 'confirm' There is a lot of text on the modal which I think makes it hard to 'parse' quickly. It also feels a bit 'extra' as the change was already shown before I clicked 'confirm'. - Could we improve/simplify the text? - Could we add keyboard shortcuts to yes/no like in other spots? - could we make the amount stand out more visually as this is the most important information? 2) For me it's not clear what goes into which input field and I think it might get worse with translation. We got: Amount paid : (additonal space should be removed) Collect from patron: It's not clear to me what does input fields each are meant for :( Should it be: Collect_ed_ from patron? - Could we improve the labels to be more clear? - Could it make sense to set the fields apart a bit visually as the change calculation is optional? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I totally agree here, I just haven't had a moment to comment before now.. I'd really like this functionality cleaned up.. I think I even put a mockup screenshot in the original bug if I remember correctly with how I perceived it looking. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Not sure how to get this moving, but I feel we should not release with the feature as is. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |19.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87591&action=edit Screenshot showing partial payment There has been no reaction to this so far from the initial developers, I am updating it to a bug as I think we will get negative feedback on it as it stands now :( To show one of the issues I have added a screenshot. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- To repeat steps from screenshot: - Have an account with multiple fines & charges - Click 'Pay amount' - Enter the Amount paid Suggestion: Leave amount collected empty and only calculate 'change to give' if it's entered. I'd also love some visual separation to make the Amount paid stand out more and show that the other 2 fields belong together. Also: Collect form patron > Collected from patron Amount paid : > Amount paid: -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I fail to trigger the described modal from comment#2 right now. Wonder if we already changed something there? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Found the mmodal... it appears when you click confirm. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight@lboro.ac.uk --- Comment #8 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Talked to the chaps here (mostly techies who hang around libraries!) after seeing some discussion about this on IRC this morning and we couldn't see what the point of the "collected" option was? If you collect 20 currency units in order to pay 5 currency units off a 15 currency unit bill in order to leave 10 currency units due, does Koha really need to record the 20, rather than just the 5 unit payment? Surely the person in the library handling this would be able to do the 15 unit change themselves? Or are people somehow linking Koha payment records to EPOS transactions? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the idea was to help calculate, but the GUI right now seems confusing compared to the 'before' and would require extra input. Looking at the screenshot I think what I did 'wrong' was: I wanted to pay a partial amount of the amount outstanding. Use case: "But I only have 6.00 with me..." So I said: - Pay amount - Amount paid: 6.00 - I didn't change the other input fields - I shoudl have changed: Amount collect_ed_ to say 6.00 - Change would have been: 0.00 But having to enter 2 fields to have the display make sense seems not good to me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|19.05 |--- Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95619&action=edit Bug 22359: Improvements to payment collection inputs This patch attempts to clarify the uses of the various input fields on the paycollect screens. It does this by adding validation to the form such that entering a 'collected' value that is lower than the 'paid' value is now forbidden. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95619|0 |1 is obsolete| | --- Comment #11 from Michal Denar <black23@gmail.com> --- Created attachment 96394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96394&action=edit Bug 22359: Improvements to payment collection inputs This patch attempts to clarify the uses of the various input fields on the paycollect screens. It does this by adding validation to the form such that entering a 'collected' value that is lower than the 'paid' value is now forbidden. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target, | |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart@bugs.koha-c | |ommunity.org QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96394|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97229&action=edit Bug 22359: Improvements to payment collection inputs This patch attempts to clarify the uses of the various input fields on the paycollect screens. It does this by adding validation to the form such that entering a 'collected' value that is lower than the 'paid' value is now forbidden. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- That was a 'fun' rebase... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24479 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479 [Bug 24479] New POS doesn't follow CurrencyFormat -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #15 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Giving this a bump for speedy QA and backport. We've got folks broadly confused about what "Amount paid" and "Collect from patron" mean. Will put in a new bug to consider alternate wording, but this patch would at least prevent them from accidentally paying more than intended. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Andrew Fuerste-Henry from comment #15)
Giving this a bump for speedy QA and backport. We've got folks broadly confused about what "Amount paid" and "Collect from patron" mean. Will put in a new bug to consider alternate wording, but this patch would at least prevent them from accidentally paying more than intended.
Did you test the patch? Could you add your stamp on it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Just tested, this did not work for me. What I did: - Create manual invoice for $100 - Click Pay on that specific fee - Leave amount paid at $100 - Set collect from patron to $50 - Submit payment - Koha marks the entire fine as paid off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #18 from Michal Denar <black23@gmail.com> --- Field "Collected from patron" is used for calculation how much change back to patron if pay more that "Amount being paid". This patch don't solve situation if librarian want to make partial write off (Collected from patron < Amount being paid). From my point of view patch works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97229|0 |1 is obsolete| | --- Comment #19 from Michal Denar <black23@gmail.com> --- Created attachment 97840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97840&action=edit Bug 22359: Improvements to payment collection inputs This patch attempts to clarify the uses of the various input fields on the paycollect screens. It does this by adding validation to the form such that entering a 'collected' value that is lower than the 'paid' value is now forbidden. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Michal Denar from comment #19) Michal, I'm having trouble reconciling what you say in comment #18 and what you say in comment #19. In #18 you say "This patch don't solve situation if librarian want to make partial write off (Collected from patron < Amount being paid)." I read that as you saying amount collected *should* be allowed to be less than amount being paid. In #19 you say "It does this by adding validation to the form such that entering a 'collected' value that is lower than the 'paid' value is now forbidden." I read that as you saying amount collected *should not* be allowed to be less than amount being paid. So I'm not understanding something. Right now, with this patch applied I am still able to make a payment where amount being paid is $10 and amount collected is $5. Koha treats this as a payment of $10. It does not in any way indicate that I have taken actual payment for $5 and essentially forgiven the other $5. I think this makes for very misleading bookkeeping. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm investigating this at the moment as I'm also now seeing some very strange behaviour.. I think something may have gone awry in the rebase. The intention was indeed to prevent collection of less than payment prescribed. The validation routines seems to break on decimals is where I'm at currently.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #22 from Michal Denar <black23@gmail.com> --- I partically agree with Andrew that solution and texts are "inaccurate". But "Collected from patron" has field for calculation function. So if we talk about partially write off feature, we should use clear way that every librarian user understand from UI&texts. Maybe like https://prnt.sc/qs0raw -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97840|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97873&action=edit Bug 22359: Improvements to payment collection inputs This patch attempts to clarify the uses of the various input fields on the paycollect screens. It does this by adding validation to the form such that entering a 'collected' value that is lower than the 'paid' value is now forbidden. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97874&action=edit Bug 22359: Prevent undercollection at the server This patch adds some additional handling to prevent undercollection of fees at the server side. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Michal Denar from comment #22)
I partically agree with Andrew that solution and texts are "inaccurate". But "Collected from patron" has field for calculation function. So if we talk about partially write off feature, we should use clear way that every librarian user understand from UI&texts. Maybe like https://prnt.sc/qs0raw
I think that's a different enhancement and should be logged as it's own bug.. I'm really just trying to clarify the existing functionality as it stands... I've attached a followup that prevents undercollection at the server end and returns an error message. However, I'm still stuck on the clientside validation, it seems that our jquery validate library simply falls over at a value of 100 for 'minimum'.. I've reported a bug upstream and spend ages trying to debug it. Bug: https://github.com/jquery-validation/jquery-validation/issues/2311 Fiddle: https://jsfiddle.net/ashimema/1uxysdap/17/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #26 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- See bug 24495 for changing the wording on this interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97873|0 |1 is obsolete| | --- Comment #27 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97877&action=edit Bug 22359: Improvements to payment collection inputs This patch attempts to clarify the uses of the various input fields on the paycollect screens. It does this by adding validation to the form such that entering a 'collected' value that is lower than the 'paid' value is now forbidden. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97874|0 |1 is obsolete| | --- Comment #28 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97878&action=edit Bug 22359: Prevent undercollection at the server This patch adds some additional handling to prevent undercollection of fees at the server side. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #29 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm signing this off, as it did block me from submitting a payment where collected < paid. But one non-blocking bit of weirdness -- it gives me different error messages depending on whether or not I'm paying off the whole fine. If amount being paid = total amount payable and amount collected < amount being paid, Koha lets me click confirm and then pops up a big yellow alert saying "You must collect a value greater than or equal to [amount being paid]". If amount being paid < total amount payable and amount collected < amount being paid, Koha immediately makes amount collected red and adds a little red message next to it reading "Please enter a value greater than or equal to [amount being paid]." So, it works, but the inconsistency is weird. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97877|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97885&action=edit Bug 22359: Improvements to payment collection inputs This patch attempts to clarify the uses of the various input fields on the paycollect screens. It does this by adding validation to the form such that entering a 'collected' value that is lower than the 'paid' value is now forbidden. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97878|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97886&action=edit Bug 22359: Prevent undercollection at the server This patch adds some additional handling to prevent undercollection of fees at the server side. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The issues should all be fixed now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97885|0 |1 is obsolete| | --- Comment #33 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97888&action=edit Bug 22359: Improvements to payment collection inputs This patch attempts to clarify the uses of the various input fields on the paycollect screens. It does this by adding validation to the form such that entering a 'collected' value that is lower than the 'paid' value is now forbidden. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97886|0 |1 is obsolete| | --- Comment #34 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97889&action=edit Bug 22359: Prevent undercollection at the server This patch adds some additional handling to prevent undercollection of fees at the server side. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #35 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- It works! Great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Andrew Fuerste-Henry from comment #29)
I'm signing this off, as it did block me from submitting a payment where collected < paid. But one non-blocking bit of weirdness -- it gives me different error messages depending on whether or not I'm paying off the whole fine.
If amount being paid = total amount payable and amount collected < amount being paid, Koha lets me click confirm and then pops up a big yellow alert saying "You must collect a value greater than or equal to [amount being paid]".
If amount being paid < total amount payable and amount collected < amount being paid, Koha immediately makes amount collected red and adds a little red message next to it reading "Please enter a value greater than or equal to [amount being paid]."
So, it works, but the inconsistency is weird.
I somehow missed this comment.. did you mean the wording in the yellow alert box was inconsistent? I can happily fix that here as a followup.. just wanted to clarify what you meant.. That box should now only appear if you have javascript disabled, but it's nice to know we're catching things in that case too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #37 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I meant it was inconsistent in that sometimes it gave that big yellow box and sometimes it just gave some red alert text within the payment form. I don't have strong feeling about this, but it would be a little cleaner if it always errored out in the same way. I've got no problem with pushing this as-is, maybe changing it in another bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Aha, I see.. so at this point if you have javascript enabled you should only ever see the client-side validation.. i.e. the red hints in the form itself. If you have javascript disabled you should only ever see the yellow alert box.. i.e. the serverside validation will be triggered. Hopefully, that makes sense -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Note to self.. opening a bug to add the same logic to the point of sale page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519 [Bug 24519] Change calculation and validation in Point of Sale should match Paycollect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11373 |24208 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 [Bug 11373] Add "change calculation" feature to the fine payment forms https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208 [Bug 24208] Remove change calculation for writeoffs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97888|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98833&action=edit Bug 22359: Improvements to payment collection inputs This patch attempts to clarify the uses of the various input fields on the paycollect screens. It does this by adding validation to the form such that entering a 'collected' value that is lower than the 'paid' value is now forbidden. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97889|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98834&action=edit Bug 22359: Prevent undercollection at the server This patch adds some additional handling to prevent undercollection of fees at the server side. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased... again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #43 from Kyle M Hall <kyle@bywatersolutions.com> --- Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt line 453: unexpected end of input at /kohadevbox/koha/C4/Templates.pm line 122 FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt OK filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid FAIL valid_template parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt line 453: unexpected end of input -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98833|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99323&action=edit Bug 22359: Improvements to payment collection inputs This patch attempts to clarify the uses of the various input fields on the paycollect screens. It does this by adding validation to the form such that entering a 'collected' value that is lower than the 'paid' value is now forbidden. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98834|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99324&action=edit Bug 22359: Prevent undercollection at the server This patch adds some additional handling to prevent undercollection of fees at the server side. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99325&action=edit Bug 22359: (follow-up) Fix rebase error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99323|0 |1 is obsolete| | Attachment #99324|0 |1 is obsolete| | Attachment #99325|0 |1 is obsolete| | --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 99337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99337&action=edit Bug 22359: Prevent undercollection at the server This patch adds some additional handling to prevent undercollection of fees at the server side. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99389&action=edit Bug 22359: Improvements to payment collection inputs This patch attempts to clarify the uses of the various input fields on the paycollect screens. It does this by adding validation to the form such that entering a 'collected' value that is lower than the 'paid' value is now forbidden. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99337|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99390&action=edit Bug 22359: Prevent undercollection at the server This patch adds some additional handling to prevent undercollection of fees at the server side. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize@ptfs-europe |glasklas@gmail.com |.com | CC| |glasklas@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|glasklas@gmail.com |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_target, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.04 released in| | CC| |joy@bywatersolutions.com --- Comment #51 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x for 19.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #52 from Lucas Gass <lucas@bywatersolutions.com> --- this is missing a dependency for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25746 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org