[Bug 41402] New: Do not hide all items if there is a pref OpacMaxItemsToDisplay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41402 Bug ID: 41402 Summary: Do not hide all items if there is a pref OpacMaxItemsToDisplay Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org If there are too much items to process according to OpacMaxItemsToDisplay, ALL items are hidden. It is a bit weird to display every single of the n-1 items, but none of the n items once OpacMaxItemsToDisplay is reached. I propose to change the behaviour of this syspref to only display the first OpacMaxItemsToDisplay items and have a link to see more. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41402 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 190288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190288&action=edit Bug 41402: Do not hide all items if there is a pref OpacMaxItemsToDisplay Test plan: 1. Set OpacMaxItemsToDisplay to 3. 2. Add multiple items on a record. 3. Visit http://koha-ktd:8080/cgi-bin/koha/opac-detail.pl?biblionumber=YOUR_BIBLIONUM..., notice every items are hidden. 4. Apply patch 5. Visit the same page, notice that the 3 first items are displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41402 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41402 --- Comment #2 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Note :
From a technical point of view, there is no real change concerning the load. All items were formerly fetched and none were processed. Now, all items are still fetched and OpacMaxItemsToDisplay are processed, which is supposed to be low enough to guarantee correct response time.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41402 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41402 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190288|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 190314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190314&action=edit Bug 41402: Do not hide all items if there is a pref OpacMaxItemsToDisplay Test plan: 1. Set OpacMaxItemsToDisplay to 3. 2. Add multiple items on a record. 3. Visit http://koha-ktd:8080/cgi-bin/koha/opac-detail.pl?biblionumber=YOUR_BIBLIONUM..., notice every items are hidden. 4. Apply patch 5. Visit the same page, notice that the 3 first items are displayed Signed-off-by: David Nind <you@example.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41402 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |baptiste.wojtkowski@biblibr | |e.com Severity|enhancement |normal Text to go in the| |This fixes the number of release notes| |items shown for a record in | |the OPAC when | |OpacMaxItemsToDisplay is | |used. It should only show | |the number of items in the | |system preference. Instead, | |it was showing no items if | |the number was reached. | | | |Example: With a record that | |has four items and | |OpacMaxItemsToDisplay set | |to three, no items were | |shown and you had to click | |"View all the physical | |items". Now it works as | |expected, three items are | |shown and you click "View | |all the physical items" to | |see all four items. CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Changed bug from an enhancement to normal (as it is a bug), also changed the assignee. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41402 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190314|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 190321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190321&action=edit Bug 41402: Do not hide all items if there is a pref OpacMaxItemsToDisplay Test plan: 1. Set OpacMaxItemsToDisplay to 3. 2. Add multiple items on a record. 3. Visit http://koha-ktd:8080/cgi-bin/koha/opac-detail.pl?biblionumber=YOUR_BIBLIONUM..., notice every items are hidden. 4. Apply patch 5. Visit the same page, notice that the 3 first items are displayed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41402 --- Comment #6 from David Nind <david@davidnind.com> --- My sign-off line was incorrect, so have updated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41402 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41402 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190321|0 |1 is obsolete| | --- Comment #7 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 192293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192293&action=edit Bug 41402: Do not hide all items if there is a pref OpacMaxItemsToDisplay Test plan: 1. Set OpacMaxItemsToDisplay to 3. 2. Add multiple items on a record. 3. Visit http://koha-ktd:8080/cgi-bin/koha/opac-detail.pl?biblionumber=YOUR_BIBLIONUM..., notice every items are hidden. 4. Apply patch 5. Visit the same page, notice that the 3 first items are displayed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41402 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41402 --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 192307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192307&action=edit Not tidied patch for QA For the QA, I provide here the not tidied patch, since it is totally unreadable after tidying -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41402 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192307|0 |1 is obsolete| | --- Comment #9 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 192309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192309&action=edit Not tidied patch for QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41402 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org