https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30732 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30732 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30207 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30732 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Failed QA --- Comment #2 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Sorry, Kyle, I can't get this to work - I restarted services before testing. - I set up a hold and suspended it - I logged into a limited staff account with only place_hold permission - I tried to resume the hold and on both pages got, "Your request could not be processed. Check the logs." - I logged back in as the superlibrarian account and resumed the hold - I logged back into the staff account (with only place_hold permission) - I tried to suspend the hold - this time I got the suspension date box, but any attempt to suspend it (with or without a date) caused the, "Your request could not be processed. Check the logs." error to show. I cleared the hold and placed a new one via the limited staff account, but the same error occurred. I also wondered if it was a cache thing, so as well as clearing the cache, I tried in a different browser - but no joy. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30732 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30732 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- I've amended by test plan! I should have wrote to use the "all" versions of the suspend and resume buttons! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30732 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140562|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 140601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140601&action=edit Bug 30732: Librarians with only "place_holds" permission can not suspend and resume holds If a librarian only has the place_holds permission, they can see the buttons for placing and suspending holds on moremember.pl and circulation.pl, but cannot use them. Test Plan: 1) Give your librian only the place_holds permission 2) Attempt to "suspend all" and "resume all" holds on moremember.pl and circulation.pl 3) Note you cannot 4) Apply this patch 5) Restart all the things! 6) Test again, note you can now suspend and resume holds! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30732 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #7)

With * this will work with either, place_holds and modify_holds_priority permission, not only with place_holds.

Was this the intended behaviour?

Also: if you have neither, you can still see the buttons. We should add permission checks there as well, so people don't get into the situation in the first place where they get stuck on missing permissions (could be a separate bug).

Indeed. I think the solution is hide the button unless the patron has place_holds. We can just set the script permission to be for place_holds too, right? If you think that's a good course of action Katrin, I will make those changes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30732 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Indeed *** This bug has been marked as a duplicate of bug 31893 *** -- You are receiving this mail because: You are watching all bug changes.