[Bug 32262] New: smart-rules: Some rules can be created but are not visible on interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32262 Bug ID: 32262 Summary: smart-rules: Some rules can be created but are not visible on interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com See e.g. bug 30794 and bug 27945. On 30794 you can create a rule with all inputs blank for a patron category under 'Default checkout, hold policy by patron category'. You wont see it. Same for creating an rule for open_article_request_limit outside the interface though (bad practice generally) with itemtype NULL iirc. You wont see it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32262 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30794, 27945 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27945 [Bug 27945] Limit the number of active article requests per patron category https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794 [Bug 30794] 'Default checkout, hold and return policy' overrides Unlimited holds in 'Default checkout, hold policy by patron category' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32262 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Hum, CirculationRules.Search() never returns an undefined value and, more generally, methods from the TT plugins return an empty string when we actually return undef... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32262 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Ok, perl returns an empty string for undef in a string context. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32262 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144143&action=edit Bug 32262: Handle non-existing circ rules Some rules are not displayed on the UI, even if they exist in the DB, that's confusing. That's because we are implicitely returning 'undef' from CirculationRules.Search, and perl returns an empty string for undef in a string context. Which means "rules.defined" is always true. This patch is ugly and really hope somebody else will come with a better solution. Test plan: I don't know, search for regressions on the circ rule UI?... :D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32262 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32262 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Note that want_rule flag could have unexpected behaviours -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35458 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org