[Bug 14075] New: Undefined value creates noisy warns in C4::AuthoritiesMarc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 Bug ID: 14075 Summary: Undefined value creates noisy warns in C4::AuthoritiesMarc Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org If sortby is not set and left as undefined, there are a bunch of noisy errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 38624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38624&action=edit Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc This match sets $sortby (previously undefined value) as an empty string to get rid of the warns. To test: 1) Go to a URL such as http://localhost:8080/cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operator=contains&value=a&marclist=any&and_or=and 2) Notice the warns in the error log 3) Apply patch 4) Reload URL 5) Notice page still works but no warns in error log -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 38624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38624 Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc Review of attachment 38624: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14075&attachment=38624) ----------------------------------------------------------------- ::: C4/AuthoritiesMarc.pm @@ +18,4 @@
use strict; use warnings; +use lib '.';
Why this addition? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to M. Tompsett from comment #2)
Comment on attachment 38624 [details] [review] Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc
Review of attachment 38624 [details] [review]: -----------------------------------------------------------------
::: C4/AuthoritiesMarc.pm @@ +18,4 @@
use strict; use warnings; +use lib '.';
Why this addition?
Oops forgot to take that out when I was experimenting earlier! My bad -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38624|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 38626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38626&action=edit Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc This match sets $sortby (previously undefined value) as an empty string to get rid of the warns. To test: 1) Go to a URL such as http://localhost:8080/cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operator=contains&value=a&marclist=any&and_or=and 2) Notice the warns in the error log 3) Apply patch 4) Reload URL 5) Notice page still works but no warns in error log -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14076 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 38626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38626 Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc Review of attachment 38626: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14075&attachment=38626) ----------------------------------------------------------------- ::: C4/AuthoritiesMarc.pm @@ -18,4 @@
use strict; use warnings; -use lib '.';
Now you lost your change, because you obsoleted the other patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Attachment #38624|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 --- Comment #6 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to M. Tompsett from comment #5)
Comment on attachment 38626 [details] [review] Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc
Review of attachment 38626 [details] [review]: -----------------------------------------------------------------
::: C4/AuthoritiesMarc.pm @@ -18,4 @@
use strict; use warnings; -use lib '.';
Now you lost your change, because you obsoleted the other patch.
Of course oops my mistake again,thanks for fixing that -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38624|0 |1 is obsolete| | Attachment #38626|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38628&action=edit Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc This match sets $sortby (previously undefined value) as an empty string to get rid of the warns. To test: 1) Go to a URL such as http://localhost:8080/cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operator=contains&value=a&marclist=any&and_or=and 2) Notice the warns in the error log 3) Apply patch 4) Reload URL 5) Notice page still works but no warns in error log Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: I would have done $sortby //= ''; But this works too. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38628|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38660&action=edit Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc This match sets $sortby (previously undefined value) as an empty string to get rid of the warns. To test: 1) Go to a URL such as http://localhost:8080/cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operator=contains&value=a&marclist=any&and_or=and 2) Notice the warns in the error log 3) Apply patch 4) Reload URL 5) Notice page still works but no warns in error log Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: I would have done $sortby //= ''; But this works too. :) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |jonathan.druart@biblibre.co | |m Assignee|oleonard@myacpl.org |aleishaamohia@hotmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #11 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org